Kris Borchers
d1505e3434
Dialog: Move call to _focusTabbable and triggering of open and focus events into the _show callback. Fixes #6756 - Dialog: show: "blind" with link in content doesn't animate properly. Fixes #8051 - Dialog: 'Explode' dialog animation causes crash in IE 6, 7 and 8. Fixes #4421 - Dialog: Focus lost from dialog which uses show-effect
2013-01-30 12:30:37 -06:00
David Sullivan
55360eeb7e
Dialog: modified _createOverlay to _appendTo instead of document.body. Fixed #8984 - Modal dialogs display behind overlay when using appendTo option
2013-01-26 11:34:51 -05:00
David Petersen
649f105229
Dialog: Don't handle overlays on destory if there are not any. Fixed : #9004 - failed in _destroyOverlay when I destroy a modal dialog thau was never opened. Fixed : #9000 Dialog leaves broken event handler after close/destroy in certain cases
2013-01-24 13:43:02 -06:00
Kris Borchers
34409e7ddd
Updating to jQuery 1.9.0
2013-01-17 00:28:41 -06:00
Mike Sherov
0d4022bceb
Tests: Convert single quotes to double quotes.
2012-12-26 08:08:48 -05:00
Mike Sherov
6d88d264be
Dialog Tests: Fix test fails due to window measurements in FF and IE7
2012-12-22 15:46:57 -05:00
Mike Sherov
48d7d53f7b
Dev: stop loading *_tickets.js in the test suite.
2012-12-22 12:56:19 -05:00
Mike Sherov
fec36fd214
Dev: remove todos from datepicker and dialog testsuite
2012-12-12 03:16:33 -05:00
Scott González
b9f206dbcf
Dialog: Cleanup.
2012-12-11 16:23:18 -05:00
Scott González
245a82d5aa
Dialog tests: More async focus handling to deal with IE8.
2012-12-10 15:31:56 -05:00
Scott González
0f0ec001aa
Dialog tests: Updated markup for deprecated tests to match standard tests.
2012-12-10 08:53:13 -05:00
Mike Sherov
9f76446775
Dev: remove unnecessary simulated drag delegation in test suite
2012-12-08 21:27:37 -05:00
Mike Sherov
5dee8dee30
Dev: Change incorrect references in test suite from #main to #qunit-fixture.
2012-12-08 13:19:36 -05:00
Mike Sherov
e83a89dd7d
Dev: Remove *_tickets.js test files and move the associated tests to the proper locations.
2012-12-07 20:06:29 -05:00
Scott González
d4551bc3b8
Dialog: Respect maxHeight when determining size on open. Fixes #4820 - Dialog: Auto height does not respect the maxHeight option.
2012-12-07 16:57:03 -05:00
Scott González
70b16ef445
Dialog: Added appendTo option. Fixes #7948 - Dialog: Allow dialog to be attached to a element other than body.
2012-12-07 14:54:21 -05:00
Scott González
f59f5a8b12
Dialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed.
2012-12-05 11:53:34 -05:00
Scott González
3c2acc3227
Dialog: Remove width, min-height, height styles on destroy. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed.
2012-12-04 10:03:05 -05:00
Scott González
050e71bdd8
Revert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers."
...
This reverts commit d687a1b10d
.
2012-12-04 09:21:33 -05:00
Jörn Zaefferer
1e8baf5683
Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist.
2012-12-04 01:08:34 +01:00
Jörn Zaefferer
d687a1b10d
Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers.
2012-12-04 00:35:47 +01:00
Jörn Zaefferer
13505e5945
Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM.
2012-11-30 13:08:56 +01:00
Scott González
ee8d20ea06
Dialog: Moved resizable handle test from resizable.
2012-11-26 16:27:18 -05:00
Kris Borchers
a68d5ca31d
Dialog: Add unit test to cover #8789 and #8838 .
2012-11-26 12:14:29 +01:00
Jörn Zaefferer
a09f5c07f5
Dialog: Follow-up to 9fe3a62d8
- also deprecate string notation for position option.
2012-11-26 10:28:25 +01:00
Jörn Zaefferer
f3525afe0e
Dialog: Update focus-tabbable test with a timer workaround to get IE8 to pass.
2012-11-26 10:28:25 +01:00
Jörn Zaefferer
5aac8f563f
Dialog: Add missing unit test for aria-describedby attribute
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091
Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option.
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0
Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported.
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9
Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
299681e8f0
Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b694409e76
Dialog: Extend visual test to verify DOM position restore on destroy; overhaul unit test for destroy method.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
999617343f
Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
fed2972027
Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value.
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf
Dialog: Use button widget for close button (was already listed as dependency)
2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e
Dialog: Focus tabbable only when dialog lost focus before.
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733
Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change.
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4632780435
Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test
2012-11-26 10:26:11 +01:00
Scott González
8c36603305
Dialog tests: Work around inconsistent handling of non-breaking spaces in IE7/8 with jQuery <1.8.
2012-11-15 10:47:36 -05:00
Scott González
fb6119e182
Upgrade jQuery to 1.8.3.
2012-11-14 15:22:01 -05:00
Mike Sherov
543abc9b1f
Dev: clean up dialog test suite with new helper methods. Fixes #8803 - Dev: re-enable the dialog test suite
2012-11-09 15:02:26 -05:00
Scott González
f5870712c1
Updated all widgets to use proper data keys when getting plugin instances.
2012-11-09 13:28:13 -05:00
Mike Sherov
3df9ea29e6
Dev: remove globals from tests and moved test helpers to correct location - Fixed #8770 Dev: Remove globals and Standardize Test Suite
2012-11-03 16:17:16 -04:00
Scott González
2a68a7d2bc
Dialog tests: Removed stack option.
2012-10-26 14:38:27 -04:00
Scott González
d68ef5e4e1
Tests: Removed old code that kept bad test suites out of TestSwarm.
2012-10-26 13:47:34 -04:00
Scott González
68cab60fa7
Removed bgiframe.
2012-10-26 10:53:17 -04:00
Nate Eagle
3829a37ca1
Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:
...
Fixes #3534 - Dialog: Modal dialog disables all input elements on page.
Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.
Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.
Fixes #5388 - Dialog: Don't change z-index when already at the top.
Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.
Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.
Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.
Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.
Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).
Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.
Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.
Fixes #8583 - Dialog: Mouse event wrongly stopped.
Fixes #8722 - Dialog: Remove stack option.
Fixes #8729 - Dialog: Remove zIndex option.
2012-10-24 16:56:19 -04:00
Mike Sherov
e1230997aa
Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
...
Squashed commit of the following:
commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 10:34:28 2012 -0400
put back in fake args for signatures that we want to keep
commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 08:10:20 2012 -0400
changes per @scott_gonzalez
commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:54:05 2012 -0400
clean up unused vars in ui directory
commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:37:42 2012 -0400
clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Trey Hunner
49f9b849b9
Remove trailing whitespace and add final newlines
2012-10-21 22:45:41 -04:00
David Petersen
35dc9307fc
Dialog: Use _hide() to make sure close event gets triggered. Fixes #8684 - jQuery dialog with hide options does not trigger close event.
2012-10-17 20:28:27 -04:00
Scott González
a638acb583
Upgrade jQuery to 1.8.2.
2012-09-20 21:41:47 -04:00
Scott González
1e6b2b2298
Upgrade jQuery to 1.8.0.
2012-08-13 09:19:09 -04:00
Scott González
b073cda1a5
Dialog tests: Fixed calls to $.contains() that were passing jQuery objects instead of elements.
2012-07-13 15:52:32 -04:00
Scott González
5ae668fdb6
Tests: Enable QUnit.config.requireExpects.
2012-06-27 11:32:48 -04:00
kborchers
240b22b143
Dialog: Use new uniqueId method for generating id's
2012-05-29 23:11:42 -05:00
Jay Merrifield
cab4c467d9
Dialog: Handle escape for all overlays. Fixes #8300 - Dialog: Incorrect behavior for ESCAPE with multiple modal dialogs.
2012-05-07 09:44:26 -04:00
Scott González
b042f8ebd6
Tests: Moved loadResources to TestHelpers.
2012-04-23 10:43:01 -04:00
Scott González
7a5a77da50
Tests: Rename {widget}_defaults.js -> {widget}_common.js
2012-04-23 10:15:17 -04:00
Jörn Zaefferer
ce3c7fab93
Update to official qunit composite addon
2012-04-21 17:49:11 +02:00
Scott González
e9d5079b04
Tests: Move commonWidgetTests() to TestHelpers.
2012-04-19 13:03:21 -04:00
Scott González
0a5a9090f8
Tests: Lint.
2012-04-19 10:28:26 -04:00
Scott González
89ff5c5232
Upgrade jQuery to 1.7.2.
2012-03-22 09:45:22 -04:00
Jörn Zaefferer
72023dd045
Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal.
2012-02-29 18:36:40 +01:00
Alberto Monteiro
a4b7feabd3
Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position
2011-12-15 17:52:49 -03:00
James Khoury
ce0afde900
Dialog: Modified the dialog._size() to use outerHeight in calculating the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set.
2011-11-28 16:52:10 -05:00
Scott González
54fb1441fe
Upgrade jQuery to 1.7.1.
2011-11-22 08:43:09 -05:00
Scott González
50dab05784
Upgrade jQuery to 1.7.
2011-11-09 10:18:33 -05:00
Scott González
dcac8c1f29
Tests: Added ability to run tests against minified files via ?min=1
2011-10-28 15:58:33 -04:00
Scott González
efe964d86e
Upgraded jQuery to 1.6.4.
2011-10-18 09:38:27 -04:00
Corey Frang
dfe75e1b55
Dialog: Update to 96e5c24
- keyup apparently doesn't work like I thought it would everywhere, switching back to keydown.
2011-08-20 18:05:39 -05:00
Corey Frang
96e5c241e1
Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog
2011-08-19 06:03:59 -05:00
Scott González
6fb68568be
Tests: Cleanup.
2011-08-03 21:43:52 -04:00
Scott González
4adb9026ea
Tests: Cleanup.
2011-08-03 17:12:44 -04:00
Scott González
bea74f2ae7
Tests: Added test suites to run individual widget tests against all supported jQuery versions.
2011-08-02 20:41:50 -04:00
Scott González
d92b61e865
Tests: Added ability to run tests suites against different versions of jQuery core.
2011-07-28 07:34:31 -04:00
Scott González
daadc343be
Upgrade jQuery to 1.6.2.
2011-07-25 11:46:45 -04:00
Scott González
da84672db8
.attr() -> .prop()
2011-06-08 17:02:57 -04:00
Scott González
325ee6e871
Widget: define a null default for the create callback.
2011-04-25 14:04:30 -04:00
Jay Merrifield
f9996682b5
Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.
2011-03-08 09:42:10 -05:00
Douglas Neiner
15c97e0b76
Dialog: Added a class to dialog wrapper when it is currently displaying buttons, includes unit tests for changes. Fixed #7057 - An extra class is needed on the dialog wrapper to specify when a buttonset is showing
2011-03-03 09:37:16 -05:00
Richard Worth
593799d6e3
Switched to latest stable jQuery 1.5.1
2011-03-02 20:49:20 -05:00
jzaefferer
c37637ee99
Use #qunit-fixture instead of deprecated #main. Fixes #7031 - Tests use
2011-02-23 12:46:13 +01:00
jzaefferer
1c7ab042fa
Disable dialog tests on TestSwarm until we can get some running in IE6
...
without freezing the browser.
2011-02-21 22:26:38 +01:00
jzaefferer
a1ebed70e3
Unit tests: Add QUnit toolbar for hiding passed tests
2011-02-21 20:39:35 +01:00
Scott González
b42125af43
Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose.
2010-12-10 14:31:36 -05:00
Scott González
0e15f573d6
Revert "Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError."
...
This reverts commit 22671ad4f8
.
2010-12-10 13:42:29 -05:00
Scott González
22671ad4f8
Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError.
...
This should be reverted in jQuery UI 1.9.
2010-12-08 12:36:19 -05:00
Scott González
22cf318e40
Dialog position tests: Use Math.round() instead of Math.floor().
2010-12-03 09:14:27 -05:00
Scott González
fce1f97f76
Upgraded jQuery to 1.4.4.
2010-11-12 09:19:26 -05:00
Jay Merrifield
dfb3544297
Dialog: Make sure the overlay instance still exists before trying to remove it. Fixes #6645 - Dialog: Missing element not found check in overlay code.
2010-11-12 08:16:41 -05:00
Scott González
19f9c3a559
Upgraded jQuery to 1.4.3.
2010-10-21 22:29:28 -04:00
Scott González
7d9d2b551f
External: Updated bgiframe to 2.1.2. Fixes #6190 - Dialog demos don't work in IE9 because of bgiframe.
2010-10-19 23:05:13 -04:00
John Firebaugh
e66cdfcf59
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:18:46 -04:00
Scott González
c090802cc1
Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."
...
This reverts commit 67b1db14c9
.
Reverting so I can commit again with the proper author.
2010-10-04 09:18:21 -04:00
Scott González
67b1db14c9
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:15:40 -04:00
Scott González
0c82f7ec2c
Dialog tests: Enabling in TestSwarm.
2010-09-07 12:28:36 -04:00
Scott González
0050f234a8
Dialog: Fixed test for default title. Some browsers were returning an actual non-breaking space and some were returning the string " ".
2010-09-07 09:49:58 -04:00
Scott González
d80e2236f6
Dialog: Reduced size of dialogs in height/width tests.
2010-09-07 08:58:20 -04:00
Scott González
2365d03cef
Dialog: Fixed a broken maxHeight test.
...
The size tests are fragile because they require the browser window to be large enough to contain the dialog.
2010-09-02 08:41:28 -04:00
Scott González
de02aa34a8
Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event.
2010-09-02 08:35:40 -04:00