Commit Graph

196 Commits

Author SHA1 Message Date
Florian Gutmann
42d33f2f86 Dialog: fix small memory leak when having lot's of instances. Fixes #7793 - Small memory leak in ui dialog. 2011-10-14 11:18:48 -04:00
Corey Frang
dfe75e1b55 Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thought it would everywhere, switching back to keydown. 2011-08-20 18:05:39 -05:00
Corey Frang
96e5c241e1 Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog 2011-08-19 06:03:59 -05:00
Scott González
19a9de7e66 Merge branch 'master' into core-1.6.1
Conflicts:
	demos/menubar/default.html
	tests/unit/autocomplete/autocomplete.html
	tests/visual/effects/effects.all.html
	ui/jquery.ui.menu.js
	ui/jquery.ui.popup.js
2011-07-25 11:53:14 -04:00
Scott González
0dc4a48762 Dialog: Append the dialog to the body early to make sure styles from the classes get applied. 2011-07-12 09:16:22 -04:00
Scott González
da84672db8 .attr() -> .prop() 2011-06-08 17:02:57 -04:00
Scott González
6a5b21fda2 All: Moved version numbers into prototypes. Fixed #7436 - Widget: Store version numbers on instances. 2011-05-28 15:39:55 -04:00
Jay Merrifield
e34dbfeef0 Dialog: Removed the height() tinkering which stops the dialog from shrinking. Fixes #5916 - Dialog: shrinks on drag in IE in standards mode, worse in quirksmode. 2011-05-26 23:30:56 -04:00
David Murdoch
c7eae7b264 Dialog: Make close() a noop if the dialog is already closed. Fixes #7327 - Dialog box size and close animation bugs. 2011-05-26 19:29:11 -04:00
Jörn Zaefferer
1c193085e1 Merge remote branch 'kborchers/bug_3623' 2011-05-18 17:07:02 +02:00
Scott González
a0f16a00b9 Dialog: Reduce old overlay dimensions to 0x0 to avoid sizing issues. Fixes #5637 - Dialog: Dimensions of reused overlay may cause scrollbars. 2011-05-18 09:34:50 -04:00
kborchers
331c4602a9 Dialog: Create modal overlay after dialog is shown and check scrollHeight and offsetHeight in all IE versions. Fixed #4995 - Modal Dialog's overlay dissapears in IE when content is tall 2011-05-12 15:14:58 -05:00
kborchers
29b36bb409 Dialog: Changed IE6 overlay width adjustment to apply to all IE versions. Fixed #3623 - Opening a Modal Dialog shows a horizontal scroll bar 2011-05-12 13:31:15 -05:00
Kato Kazuyoshi
27f943bf36 Dialog: 'NO-BREAK SPACE' (U+00A0) is not 'SPACE' (U+0020). 2011-05-07 16:02:06 +09:00
Adam Baratz
51df02ee4e Dialog: remove unneeded DOM manipulations. Fixed #7258 - optimize initialization. 2011-05-02 18:03:14 -04:00
Jay Merrifield
f9996682b5 Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs. 2011-03-08 09:42:10 -05:00
Douglas Neiner
15c97e0b76 Dialog: Added a class to dialog wrapper when it is currently displaying buttons, includes unit tests for changes. Fixed #7057 - An extra class is needed on the dialog wrapper to specify when a buttonset is showing 2011-03-03 09:37:16 -05:00
Scott González
3e370a4467 Dialog: Use ._focusable() and ._hoverable(). 2011-01-24 21:58:40 -05:00
Scott González
6e0482a9cb Updated copyright year. 2011-01-17 09:13:18 -05:00
Scott González
e0b52831fc Updated widgets to use new methods from $.Widget. 2011-01-15 06:34:07 -05:00
Scott González
56c4c6aca9 Change destroy to _destroy and remove calls to $.Widget.prototype.destroy in widgets with simple destroy methods. 2011-01-14 17:11:22 -05:00
Scott González
04667b1518 Dialog: Fixed creation of close button in IE.
Thanks dkiselev.
2011-01-11 14:34:17 -05:00
Max Schnur
727d00dec8 Dialog: Modified close button binding to use event.preventDefault() instead of return false. Fixes #6766 - Dialog: Clicks on close button don't bubble. 2010-12-20 09:00:28 -05:00
Scott González
c614889b30 Dialog: Coding standards. 2010-12-17 19:53:22 -05:00
Scott González
ca0ac5a64f All: Remove workaround for .offset() setter bug from older versions of jQuery. 2010-12-11 15:19:25 -05:00
Scott González
b42125af43 Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose. 2010-12-10 14:31:36 -05:00
Scott González
0e15f573d6 Revert "Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError."
This reverts commit 22671ad4f8.
2010-12-10 13:42:29 -05:00
Scott González
22671ad4f8 Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError.
This should be reverted in jQuery UI 1.9.
2010-12-08 12:36:19 -05:00
Scott González
b9e34f726a Dialog: Don't hide the dialog in _size if it started visible. Fixes #6717 - Dialog: Adding a button makes the dialog disappear in IE6. 2010-12-03 08:31:06 -05:00
jamiejag
8bb412dd4a Dialog: Ensure dialogs have a z-index when calculating the max z-index. Fixex #5955 - Dialog: Closing UI dialog when z-index is not defined in any .ui-dialog class, causes NaN to be used as Z-index, throwing an error. Fixes #4652 - Dialog: Event loss in subsequent dialog calls (FF3). 2010-11-19 09:02:01 -05:00
Scott González
c2139fc2e6 Dialog: Added some missing semicolons. 2010-11-12 12:57:34 -05:00
Jay Merrifield
dfb3544297 Dialog: Make sure the overlay instance still exists before trying to remove it. Fixes #6645 - Dialog: Missing element not found check in overlay code. 2010-11-12 08:16:41 -05:00
Scott González
302728bd87 Dialog: Fixed logic for mimicking minHeight. Fixes #6150 - Dialog height:auto does not work in IE6. 2010-10-05 16:20:43 -04:00
John Firebaugh
e66cdfcf59 Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7. 2010-10-04 09:18:46 -04:00
Scott González
c090802cc1 Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."
This reverts commit 67b1db14c9.

Reverting so I can commit again with the proper author.
2010-10-04 09:18:21 -04:00
Scott González
67b1db14c9 Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7. 2010-10-04 09:15:40 -04:00
Scott González
d7670b9407 Dialog: Don't pass props to jQuery when creating buttons.
Thanks jitter.
2010-10-01 11:19:24 -04:00
Scott González
cd7f10d480 Dialog: Set the type on buttons. Fixes #6128 - Dialog: Buttons are not type="button". 2010-09-30 10:17:52 -07:00
Scott González
e8e3168a39 Dialog: Batch size-related option settings. 2010-09-27 15:15:20 -04:00
Scott González
98a98a05d1 Dialog: Don't call draggable.destroy if we're not currently draggable. Fixes #6069 - DIALOG windows 1.8.5 draggapble problem. 2010-09-20 09:16:29 -04:00
Scott González
52e543a637 Dialog: If the browser doesn't support minHeight, use height to set the minHeight. Fixes #6027 - Dialog: minHeight isn't properly handled on init in IE6. 2010-09-07 09:33:09 -04:00
Scott González
de02aa34a8 Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event. 2010-09-02 08:35:40 -04:00
Scott González
95a34593f9 Dialog: Added additional syntax for creating buttons. Fixes #4344 - Dialog: Enhanced Button Option. 2010-08-31 10:17:53 -04:00
Scott González
79ee6f0d7b Dialog: When using the title attribute, update the title option. Fixes #5877 - Dialog: when using the title attribute, the title option should be updated. 2010-08-27 18:02:11 -04:00
Scott González
af9864dcc4 Dialog: Don't return true when we don't want to cancel events. Fixes #3523 - Dialog: onclick return value ignored. 2010-08-27 16:49:07 -04:00
Ziling Zhao
c5770c0e84 Dialog: modified so that minWidth is respected. Fixes #5531 - dialog width should be at least minWidth on creation. 2010-07-30 15:14:48 -04:00
Scott González
58ae7ce2fd Revert "Use pushStack in widget method. Fixes #5732 - make the widget method maintain the stack"
This reverts commit ea58cd5ac0.
2010-07-30 12:38:18 -04:00
jzaefferer
ea58cd5ac0 Use pushStack in widget method. Fixes #5732 - make the widget method maintain the stack 2010-07-30 14:26:58 +02:00
Scott González
61e0aeac7e Dialog: Wrap buttons in a div so we can float the div instead of the individual buttons. Fixes #4529 - dialog buttons are accessed in wrong order using tab. 2010-07-29 20:56:28 -04:00
Scott González
70c4857cc5 Revert "Dialog: Don't set specific dimensions on the overlay - let it expand based on 100% dimensions. Fixes #3623 - Opening a Modal Dialog shows a horizontal scroll bar."
This reverts commit b548d34e14.
2010-07-21 08:01:06 -04:00
Scott González
b548d34e14 Dialog: Don't set specific dimensions on the overlay - let it expand based on 100% dimensions. Fixes #3623 - Opening a Modal Dialog shows a horizontal scroll bar. 2010-07-20 22:05:05 -04:00
Scott González
64d90b4a71 Dialog: Adjusted logic for finding the first tabbable element. Fixes #5767 - On open, the first tabbable element inside the dialog was never being focused in favor of the dialog container. 2010-07-16 16:57:46 -04:00
Scott González
4ad7154bee Dialog: Fixed whitespace. 2010-07-16 08:55:03 -04:00
Ben Hollis
6de9a5368c Dialog: allow setting position with ui.position arguments. Fixes #5459 - Dialog: expose .position() API 2010-07-14 16:29:28 -04:00
Scott González
8a5d4ca321 All: Added http://jqueryui.com/about to header comments. 2010-07-14 15:45:45 -04:00
Scott González
2c7a9e9ff3 Dialog: Verify that we get a string back from .attr( "title" ) before using the return value. Fixes #5742 - Form field with name="title" moved to title area. 2010-07-14 15:28:01 -04:00
Scott González
21aad10e6a All: Define a local undefined variable inside the main closure. 2010-07-13 09:57:58 -04:00
Jon Palmer
f560862666 Dialog: add resize call when changing button options for correct height adjustment. Fixes remaining issues in #4846 - Setting Dialog height shorter after init hides button pane 2010-07-11 06:42:46 +08:00
Scott González
536ae6189b Updated copyright headers to make it clear that you can choose between MIT and GPLv2. Also added a link to http://jquery.org/license. 2010-07-09 09:01:04 -04:00
Scott González
b297b3fa6a Fixed size calculations for dialogs.
Fixes #5392 - Dialog explicit height doesn't match given value from set option.
2010-03-25 21:58:08 -04:00
Scott González
596d1ef581 Dialog: Use .height(0) instead of .hide(0) when determining the size of the non-content area of a dialog.
Partial fix for #5392 - Dialog explicit height doesn't match given value from set option.
2010-03-22 07:53:34 -04:00
Richard Worth
aa6fb14854 Dialog: quiet JSLint 2010-03-12 01:10:57 +00:00
Richard Worth
7898303437 dialog: corrected typo in ui.position property for drag events. Updated unit tests tracking fix of #5291 2010-03-11 20:48:21 +00:00
Jörn Zaefferer
d3a8c96428 Filter properties to forward to dialog events on resize and drag etc. - fix for #5291 2010-03-05 17:56:34 +00:00
Jörn Zaefferer
eaeb580d82 Pass through resizable and draggable ui objects in dialog - partial fix for #5291 2010-03-05 17:47:06 +00:00
Scott González
eb93c743de Dialog: Fixed modal overlay instance tracking.
Fixes #5228 - $.inArray's parameter.
Fixes #5263 - Dialog Close Then Destroy Destroys Overlay Twice, Causes Exceptions Later.
2010-03-03 02:11:37 +00:00
Scott González
83b16f528f Dialog: Use .height() to calculate height of dialog before drag.
Fixes #5221 - Buttons disappear after dragging dialog.
2010-02-24 17:16:02 +00:00
Brant Burnett
350853179f Dialog: ESC key event was not being canceled after it was handled (Fixed #4922 window.location.reload() doesn't work in dialog's close callback when it's triggered by ESC in Firefox) 2010-02-22 18:39:12 +00:00
Brant Burnett
e2202847c6 Dialog: Changed height measurement to hide content because IE quirks mode ignores height: 0 (Fixed #4350 No Scrollbars in IE in Quirksmode) 2010-02-22 17:37:08 +00:00
Brant Burnett
53ab4fb5de Dialog: Overlays are now cached for reuse with subsequent dialogs (Fixed #5185: .ui-widget-overlay CSS selector causes consistent large memory leak in IE) 2010-02-17 16:22:19 +00:00
Scott González
c9f30818af Dialog: Update the internal flag for whether or not the dialog is open before triggering the close event.
Fixes #5184 - isOpen in dialogclose event is true.
2010-02-16 02:13:38 +00:00
Scott González
f2a9deb611 Dialog: Prevent the titlebar from displaying above the top of the document.
Fixes #5141 - Position of Dialog is off the page when viewport is smaller then dialog.
2010-02-06 02:02:03 +00:00
Jörn Zaefferer
7321aa017d cleaning up dependency listings 2010-02-03 23:30:37 +00:00
Brant Burnett
d549ba6d43 Datepicker: No longer dependent on dialog in order to close datepicker when dialog is closed (Refixed #4453 UI Datepicker inside UI Dialog Issue) 2010-02-01 20:59:24 +00:00
Brant Burnett
5b61537e6e Datepicker: Fixed #4453 UI Datepicker inside UI Dialog Issue 2010-02-01 16:10:41 +00:00
Brant Burnett
58a3a99e1e Dialog: Changed overlay to use zIndex() to test which events to cancel (fixed #4363 Datepicker Month/Year Dropdowns Not Working In Safari In A Dialog) 2010-01-29 21:18:57 +00:00
Scott González
65b063b039 Prevent the default styles for resizable elements from totally killing dialog positioning (finally).
Fixes #5084 - 2 dialogs pos false on close.
2010-01-28 03:06:43 +00:00
Richard Worth
3eaf9daaca Deprecated beforeclose option instead of removing it for now, fixes reopened #4669 - Dialog: beforeclose option should be beforeClose. 2010-01-27 10:31:17 +00:00
Richard Worth
074153407d Happy New Year 2010-01-20 14:04:26 +00:00
Scott González
010385b2fa Dialog, position: Removed bgiframe option; always use bgiframe when available.
Fixes #5071 - Remove bgiframe option from all plugins.
2010-01-19 23:25:38 +00:00
Scott González
415141fe89 Dialog: Added button to the list of dependencies. 2010-01-17 18:26:43 +00:00
Scott González
296deed1c2 Dialog: Moved autoOpen detection to the new _init() method. 2010-01-15 22:17:34 +00:00
Scott González
7d96a0d096 Widget factory: Changed _create to _init.
Partial fix for #5064 - Widget: make multiple instantiation more useful.
2010-01-15 18:58:20 +00:00
Scott González
c313289d00 Dialog: workaround for positioning bug. 2010-01-15 02:16:21 +00:00
Scott González
1c31a26b56 Replaced stackfix with bgiframe.
Fixes #5061 - Remove stackfix.
2010-01-14 18:09:07 +00:00
Scott González
fb577af2a2 Dialog: force the dialog to be visible before trying to position it so we can get the current offset (required for using .offset() as a setter). 2010-01-07 04:49:25 +00:00
Scott González
b413302c00 2010-01-07 04:47:17 +00:00
Scott González
90fb45dffa Merged in /branches/dev r3251:3620 (excluding autocomplete, modal, tooltip, menu; including menu static tests). 2010-01-07 03:19:50 +00:00
Scott González
06e29401b8 Split mouse into its own file and udpdated dependency lists.
Fixes #5023 - Split mouse code into its own file.
2009-12-22 19:51:24 +00:00
Andrew Powell
0225029288 ui.dialog: replaced   with   for xhtml compliance (fixes #4970 -XHTML Compliance :   should be  ) 2009-11-21 16:59:08 +00:00
Scott González
fd976793a9 Dialog: Fixed position parsing. 2009-09-30 02:48:09 +00:00
Chi Cheng
21051b35c1 Dialog: fixes a typo. 2009-09-27 16:01:44 +00:00
Jörn Zaefferer
122a6cdd5f dialog: fixed _position regression; wrote a test for the default positon, which still needs some tuning 2009-09-19 14:03:53 +00:00
Richard Worth
af178c00f1 dialog: fixed enable and disable methods 2009-09-19 09:35:53 +00:00
Jörn Zaefferer
20201c2854 dialog: filter invalid option-position values, convert title argument to string (ala closeText) 2009-09-17 14:56:03 +00:00
Richard Worth
e2d873e6f0 renamed all ui.*.js files to jquery.ui.*.js, all effects.*.js files to jquery.effects.*.js per announcement and discussion here http://groups.google.com/group/jquery-ui-dev/msg/d565a0c56e0cb935 2009-09-17 10:39:12 +00:00