Commit Graph

6141 Commits

Author SHA1 Message Date
Mike Sherov
22bd9fc704 Button Tests: move aria-pressed test to correct module 2012-11-26 20:24:31 -05:00
Fabrício Matté
caacf8f504 Button: Let change handler handle display and aria update. Fixed #5518 - Button: Incorrect state after double click in Firefox 2012-11-26 20:15:53 -05:00
Scott González
0cc81978b2 Fixed order of authors. 2012-11-26 16:41:26 -05:00
David Petersen
6121683d80 Tabs: Calculate border and padding on tabs container. Fixed #8836: Height overflows parent with heightStyle: 'fill'. 2012-11-26 16:35:07 -05:00
Scott González
ee8d20ea06 Dialog: Moved resizable handle test from resizable. 2012-11-26 16:27:18 -05:00
Scott González
f0c203a9a0 Autocomplete demo: Combobox cleanup. 2012-11-26 16:13:21 -05:00
Jörn Zaefferer
ca88fc1f65 Fix AUTHORS.txt, remove the various duplicate entries - follow-up to 2ca5fbf8 2012-11-26 13:07:30 +01:00
TJ VanToll
0cd470b0d5 Resizable: Modified the default z-index value of resizable handles. Fixed #7960 - Dialog: Modal dialogs do not disable resizables on the page. 2012-11-26 12:42:44 +01:00
Kris Borchers
a68d5ca31d Dialog: Add unit test to cover #8789 and #8838. 2012-11-26 12:14:29 +01:00
Jörn Zaefferer
7e9060c109 Dialog: Extract setting the title into a _title method, use .text() to prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
60486ac632 Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE. 2012-11-26 10:28:25 +01:00
Kris Borchers
d179cbaf32 Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
ec1f1bde76 Dialog: Follow-up to c77ca67 - exclude button options from properties to create the button. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
a09f5c07f5 Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
f3525afe0e Dialog: Update focus-tabbable test with a timer workaround to get IE8 to pass. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
73533d9bbc Dialog: Exclude deprecated units from phantomjs 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
5aac8f563f Dialog: Add missing unit test for aria-describedby attribute 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
32a893128d Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
41c2afd66b Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0 Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9 Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
299681e8f0 Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b694409e76 Dialog: Extend visual test to verify DOM position restore on destroy; overhaul unit test for destroy method. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
d8b98ec3bb Dialog: Tiny code improvements 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
e3dcaf28eb Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0bc73b74b6 Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
972f5c192c Dialog: Button is now a fixed dependency, so remove the check 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0ae6fc1e02 Dialog: Remove useless tmp vars. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
625a111fb9 Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
4c9caa8169 Dialog: Extract button pane creation into _createButtonPane 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1d6ce644e0 Dialog: Refactor _create, extracting title bar creation in _createTitlebar 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
f0acaac230 Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7a0353500a Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1001504249 Dialog: Remove outdated TODO 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
c8aef203cb Dialog: Have _makeResizable look at options instead of passing handles. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
16a79c1b9c Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7e964be80c Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
f7d3a51589 Dialog: Only add the new dialogClass, not the base classes when changing the option. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
324d54dd32 Dialog: Use $.isEmptyObject() to check if there a button-option properties 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4e03321fd7 Dialog: Trigger focus event when dialog is moved to top. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
b6cefc797e Dialog: Remove deprecated disableSelection() usage. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
4632780435 Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2062a18db6 Dialog: Inline code review 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
0a25b2c448 Dialog: move to top when opening again, and focus as if opened from scratch. 2012-11-26 10:26:11 +01:00