Commit Graph

3577 Commits

Author SHA1 Message Date
Mike Sherov
d8077dc562 Draggable: Ensure parent is correct after dragging through sortable
Fixes #10669
2014-11-08 20:27:05 -05:00
Mike Sherov
20a6368449 Droppable: Remove $.ui.intersect()
Fixes #10534
2014-11-05 18:17:52 -05:00
Scott González
6a242ab4eb Tabs: Suppress automatic activation when navigating with COMMAND
Fixes #9621
Closes gh-1383
2014-11-04 12:07:46 -05:00
Felix Nagel
979373983b Selectmenu: Copy title attributes
Fixes #10435
Closes gh-1298
2014-11-04 08:40:15 -05:00
Scott González
809cc0f8d0 Selectmenu: Properly parse value from options
Fixes #10684
2014-11-04 08:37:07 -05:00
TJ VanToll
f656aebe3f Sortable: Redetermine floating flag when recalculating positions
This addresses a bug where users initialize empty sortable lists are
add items dynamically. In this situation refresh() should recognize the
position and orientation of the new items.

Fixes #7498
Closes gh-1381
2014-11-04 08:15:26 -05:00
Felix Nagel
fb4124b7af Selectmenu: Introduce _renderButtonItem() method
Fixes #10142
Closes gh-1299
2014-11-04 08:02:48 -05:00
Lisa Seacat DeLuca
2500bb39c2 Theme: Carat should be named caret
Fixes #10683
Closes gh-1382
2014-11-03 13:40:58 -05:00
TJ VanToll
e9643f6bfc Selectmenu: Re-add wrappers to menu items 2014-10-25 10:10:38 -07:00
TJ VanToll
4ac7b1f679 Autocomplete: Re-add wrappers to menu items 2014-10-25 10:10:38 -07:00
TJ VanToll
de2ef2a585 Menu: Wrap menu items in a <div>
This avoids styling issues where ui-state-focus rules apply to submenus.

Fixes #10162
Closes gh-1342
2014-10-25 10:10:30 -07:00
Mohammed Alshehri
06231cf762 Datepicker: Fixed month names and firstDay value in Arabic locale
Fixes #10035
Closes gh-1246
2014-10-22 17:04:57 -04:00
Scott González
1fb08790a6 Selectmenu: Remove broken tabindex code 2014-10-22 12:27:37 -04:00
Scott González
6d7589351e All: Drop support for IE7
Fixes #9838
Closes gh-1365
2014-10-21 09:06:58 -04:00
Scott González
faf87d9924 Core: Remove .zIndex()
Fixes #9156
2014-10-20 19:29:35 -04:00
Scott González
89ed68fb05 Core: Removed .focus( delay )
Fixes #9649
2014-10-20 19:26:01 -04:00
Chen Eshchar
e5e3ca4240 DatePicker: datepicker_instActive released on instance destroy
Fixes #10668
Closes gh-1362
2014-10-20 09:17:40 -04:00
Scott González
d4a437e4b0 Selectmenu: Preserve text selection and button focus on click
Fixes #10639
Closes gh-1358
2014-10-16 08:13:53 -04:00
Scott González
8825d93dc8 Tooltip: Properly track hiding and closing for delegated tooltips
Fixes #10602
Closes gh-1353
2014-10-09 10:40:58 -04:00
Jyoti Deka
6833a31697 Slider: Don't allow a slider's value to exceed its max
Fixes #9376
Closes gh-1016
2014-10-08 09:04:41 -04:00
Scott González
02c37d3aef Datepicker: Fix French locale
Thanks Jérémy M

Fixes #10651
Closes gh-1357
2014-10-07 10:53:49 -04:00
Trisha Crowley
c48b18b388 Menu: Typeahead now accounts for leading whitespace
Fixes #10649
Closes gh-1356
2014-10-07 07:45:01 -04:00
TJ VanToll
29c72fc256 Menu: Remove a redundant check
Closes gh-1355
2014-10-03 10:03:12 -04:00
TJ VanToll
6b6b49f678 Menu: Maintain focus on already selected item during typeahead
Fixes #10644
Closes gh-1354
2014-10-03 09:30:49 -04:00
Simen Bekkhus
e3e5a9ffa6 Menu: Filter out non-items when typing
Fixes #10571
Closes gh-1329
2014-09-29 14:36:46 -04:00
Scott González
b20387ab36 Datepicker: Fix currentText in Greek locale
Thanks Nikos Kalogridis

Fixes #10620
Closes gh-1349
2014-09-22 09:44:03 -04:00
Jörn Zaefferer
ddc666ce8b Menu: Ignore mouseenter events while typeahead is actice
Prevents focusing the wrong item when typeahead causes a scroll while the mouse
is over an item in the menu.

Fixes #10458
2014-08-27 13:44:08 -03:00
Alexander Schmitz
1abf9fc71f Widget: Ensure window and document are defined in _getCreateOptions()
Closes gh-1320
2014-08-27 09:08:01 -04:00
Mike Sherov
52a1de5caa Sortable: cancelHelperRemoval only considers helper, not placeholder
Refs #9675
2014-08-26 09:52:00 -04:00
Mike Sherov
aada9d5ae7 Draggable: Whitespace and naming cleanup of connectToSortable 2014-08-26 09:52:00 -04:00
Mike Sherov
a611dd8971 Draggable: Refresh sortables when draggable is added or removed
Since a sortable grows or shrinks when a draggable element is added
to it, refresh the cached positions of sortables whenever an element
is added or removed from the sortable.

Refs #9675
2014-08-25 18:23:11 -04:00
Mike Sherov
368fc8395b Draggable: Clarify comments and whitespace in connectToSortable 2014-08-25 18:23:11 -04:00
Mike Sherov
e8c99b9abf Draggable: Ensure sortable revert still works after draggable is removed
Fixes #9481
2014-08-25 08:26:57 -04:00
Mike Sherov
27ed20715f Draggable: Ensure css is always restored after connectToSortable drag
Fixes #9675
2014-08-25 08:24:56 -04:00
Mike Sherov
1cc380778b Draggable: Ensure correct widget removes helper in connectToSortable 2014-08-24 21:30:49 -04:00
Mike Sherov
c7bec85cfa Draggable: append divs to iframe parent for iframefix
This allows the blocking div to move with the iframe in
most situations, whereas appending to the body wouldn't.

Fixes #9671
2014-08-24 07:19:38 -04:00
Mike Sherov
df7e32fe37 Draggable: Check all parents for fixed positioning when scrolling
Fixes #9612
2014-08-23 15:34:04 -04:00
Mike Sherov
95546c5d04 Draggable: No cloning in connectToSortable and ensure correct position
Draggables now forcefully recalculate their position when dragged out
of a sortable. Sortables now override draggable position when a
draggable is dragged into it. Lastly, no longer remove sortable helper
when dragging a draggable out, which allows us to not use a clone.

Fixes #7734
Fixes #8809
Closes gh-1322
2014-08-23 15:08:54 -04:00
Mike Sherov
a62612ce42 Draggable: Clean spacing and names in connectToSortable drag callback 2014-08-22 17:31:29 -04:00
Scott González
849c6fd537 Accordion: Avoid memory leak during refresh
Ref #10056
Closes gh-1319
2014-08-21 09:06:56 -04:00
Scott González
2e8e52dec1 Tabs: Avoid memory leak during refresh
Fixes #10056
Ref gh-1319
2014-08-21 09:06:49 -04:00
Scott González
b397294d42 Widget: Avoid memory leaks when unbinding events with ._off()
Ref #10056
Ref gh-1319
2014-08-21 09:06:41 -04:00
Mike Sherov
e12e3e12b1 Mouse: Only detect out of document mouseups after a mousemove
This prevents the firing of mouseup in the case of IE<9, which will
fire a mousemove event if content is placed under the cursor on
mousedown.

Fixes #7778
2014-08-20 11:19:36 -04:00
Scott González
233f08e07f Datepicker: Fix month names in Persian locale
Fixes #10562
Closes gh-1221
2014-08-20 10:11:06 -04:00
Mike Sherov
451dded230 Draggable: Ensure helper is positioned even if its the element itself
Fixes #9446
2014-08-19 15:15:21 -04:00
Uri Gilad
8eca7b8f45 Draggable: Set explicit width/height instead of right/bottom css.
Fixes #7772
2014-08-18 15:30:54 -04:00
Mike Sherov
48ea2aadad Draggable: Ensure overflow:visible containments are correctly measured
Fixes #7016
2014-08-17 14:38:05 -04:00
Mike Sherov
d10440fe44 Draggable: Only focus the draggable if the event occurs on a handle
Refs #10527
2014-08-17 14:13:20 -04:00
TJ VanToll
075421d6d9 Draggable: Only blur the focused element if the event occurs on a handle
Fixes #10527
2014-08-17 14:13:20 -04:00
Mike Sherov
b5846bece3 Draggable: Recalculate hash offset on start after plugins run
Fixes #6884
2014-08-16 21:27:16 -04:00
Mike Sherov
cdcb391f4e Draggable: Fix whitespace in trigger function 2014-08-16 21:22:58 -04:00
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Jörn Zaefferer
54004c85d0 Build: Update jscs and fix some code style issues
Disables the checks for casing and line length, since those need a lot
more effort to address. For variable naming the fix isn't obvious to me.
There's way too many lines over 100 chars.
2014-08-14 14:12:12 +02:00
Andrei Picus
1cfebf803b Sortable: fire "over" and "out" even when a connectWith hasn't changed
Fixes #9335
2014-08-13 20:27:26 -04:00
Mike Sherov
4dad6bb99d Droppable: Account for draggable margins when detecting hover
Fixes #6876
2014-08-13 19:36:07 -04:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
be4c0fc324 Draggable: clean up whitespace in scroll option 2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
67e4b44b29 Core: provide "includeHidden" parameter in $.ui.scrollParent
Even though the user is unable to scroll via the UI, authors
may have custom scrollbars that programmatically set scrollTop.
Therefore, overflow:hidden can be considered a scrollParent.
2014-08-12 19:30:09 -04:00
Mike Sherov
0ad31ca469 Resizable: fix JSCS violations 2014-08-11 09:51:45 -04:00
Will Holley
87081b855c Droppable: only consider pointer location with tolerance "pointer"
Fixes #4977
Closes gh-991
2014-08-10 21:00:33 -04:00
TJ VanToll
36e4bfd516 Autocomplete: Use $.trim instead of jQuery.trim for consistency
Fixes #10525
2014-08-08 08:47:25 -04:00
Mike Sherov
05ab5d7818 Draggable: Fix several whitespace issues 2014-08-06 17:51:43 -04:00
Scott González
32bef7ad4e Tooltip: Treat the tooltip as closing until it's fully removed
This ensures that we don't trigger the close event twice if the tooltip is
destroyed during the hide animation.

Closes gh-1306
2014-08-06 15:01:58 -04:00
Mike Sherov
7c8790dcc8 Resizable: account for padding & border in grids.
Fixes #10437
2014-08-05 14:16:11 -04:00
Jyoti Deka
750a8fd0c2 Resizable: Fix containment width with relative parent.
Refs #10140
Closes gh-1303
2014-08-04 10:04:50 -04:00
Mike Sherov
2779212a0e Resizable: Fix containment calculation with relative parent
Remove an incorrect fix introduced in 47cd5b6f that causes
width calculations to be incorrect once the correct fix
was introduced in c03cb807

Fixes #10140
2014-08-04 08:18:35 -04:00
Scott González
d6d15b4558 Core: Fix focusable detection for image maps
The attribute selector requires quotes to be valid, but only new (unreleased)
Sizzle has this requirement.
2014-07-30 10:03:53 -04:00
Scott González
749a6a5667 Selectmenu: Preserve text selection when interacting with the widget
Fixes #10144
Closes gh-1295
2014-07-29 13:19:28 -04:00
Scott González
45e13ed208 Selectmenu: Properly set width for button
Fixes #10145
Closes gh-1296
2014-07-29 13:17:30 -04:00
Yermo Lamers
930bc7df66 Autocomplete: ESCAPE should not change content of a MultiLine
Fixes #9790
Closes gh-1190
2014-07-24 17:00:55 -04:00
Scott González
5beae72e77 Resizable: Fix size/position changes in resize event
Fixes #10351
Closes gh-1292
2014-07-24 16:21:51 -04:00
Scott González
9bb51d308e Position: Support positioning within document with jQuery 1.6.x
Fixes #10071
Closes gh-1294
2014-07-24 16:05:18 -04:00
Frederik Elvhage
f7429edfe9 Widget: Improve performance of cleanData method
Fixes #9546
Closes gh-1291
2014-07-24 12:07:12 -04:00
TJ VanToll
c399f1f77a Datepicker: Abstract mouseover logic to avoid explicit event trigger
The reliance on `.mouseover()` caused an issue in some circumstances
(see #5816). The removal of `.mouseover()` broke keyboard navigation
(see #10319).

Fixes #10319
Closes gh-1290
2014-07-23 15:10:37 -04:00
Scott González
69f25dbff7 Dialog: Track the instance as soon as the dialog is opened
Fixes #10152
2014-07-23 11:10:14 -04:00
Scott González
acfda4be52 Dialog: Fix stacking of modal dialog overlays
Fixes #10138
Closes gh-1286
2014-07-17 11:30:31 -04:00
Jyoti Deka
ffe60e39db Resizable: Remove accidental exposure of internal data in events
Fixes #10148
Closes gh-1279
2014-07-16 19:14:16 -04:00
Monika Piotrowicz
b4fb51199d Tabs: Work around bad Safari/VoiceOver heuristics
Move disabled tab click handlers from the container to the tablist to
prevent panel contents from being announced as clickable.

Fixes #10098
Closes gh-1261
2014-07-16 16:09:22 -04:00
TJ VanToll
3ca32b2ad8 Draggable: Manage ui-draggable-handle correctly in nested instances 2014-07-15 15:49:15 -04:00
TJ VanToll
7594a31425 Draggable: Only apply ui-draggable-handle within the draggable instance
Fixes #10212
Closes gh-1284
2014-07-15 15:49:00 -04:00
Scott González
2447cabd59 Effect: Create a local jQuery variable to make jQuery Color work
Fixes #10199
Closes gh-1282
2014-07-15 09:30:21 -04:00
Rodrigo Menezes
5730374238 Datepicker: reject dates with two year digits when expecting 'yy'
Fixes #8353
Closes gh-1248
2014-07-14 09:34:33 -04:00
Scott González
15baf024c3 Slider: Reset positioning when orientation changes
Fixes #10105
Closes gh-1268
2014-07-02 17:17:05 -04:00
Scott González
450d75f912 Datepicker: Define en and en-US locales based on defaults
Fixes #6682
Closes gh-1269
2014-06-16 16:42:43 +02:00
Jörn Zaefferer
226cc3e9e5 Dialog: Honor preventDefault when managing focus
If event.isDefaultPrevented() is true, the focus management is
completely skipped, assuming the user manages focus manually.

Fixes #10103
Closes gh-1265
2014-06-10 13:59:45 +02:00
Jörn Zaefferer
a0b84767a7 Dialog: Fix shift-tab handling, focus the correct element
Copy-paste error introduced in df6110c0d4

Updates the tabbing test to be more specific about which element should
have focus, instead of only checking if focus is within the dialog.

Ref #9646
Ref #10103
Closes gh-1264
2014-06-10 13:54:58 +02:00
Timo Tijhof
6c4005280d Dialog: Fix off() -> unbind() for jQuery 1.6 compat
Follows-up c9815f13b4.

Fixes #10072
Closes gh-1256
2014-05-27 16:05:04 -04:00
David Petersen
796a8b37e2 Spinner: Don't change value when changing min/max options
Fixes #9703
Closes gh-1252
2014-05-26 11:31:31 -05:00
David Petersen
f5e8041ebf Tabs: Move aria-expanded from active panel to active tab
Fixes #9622
Closes gh-1251
2014-05-19 11:36:21 -04:00
Scott González
54323e08e3 Widget: Remove misleading comment 2014-05-14 12:39:45 -04:00
TJ VanToll
48001a8c46 Autocomplete: Search if the user retypes the same value
Fixes #7434
Closes gh-1238
2014-05-12 13:37:13 -04:00
Scott González
8029a9763c All: Fix typos
Closes gh-1237
2014-05-07 12:28:34 -04:00
Jörn Zaefferer
b22280385c Menu: Use item.outerHeight() in _scrollIntoView
Fixes #9991
2014-05-06 15:06:56 +02:00
Rafael Xavier de Souza
f0b4967388 Datepicker: Remove unnecessary mouseover trigger
Fixes #5816
Closes gh-974
2014-05-02 17:29:20 +02:00
Scott González
fd7e1e3040 Selectmenu: Default disabled option to null 2014-04-21 10:32:49 -04:00
Daniel DeGroff
23d7d50f37 Button: Remove ui-state-active when disabling buttons
Fixes #9602
Closes gh-1151
2014-04-21 09:14:54 -04:00
Scott González
62812d9c67 Selectmenu: Simplify selection of focused item via keyboard
Don't go through menu to select the currently focused item.

Renamed _selectMenu() to _selectFocusedItem() for clarity.

Closes gh-1224
2014-04-18 12:37:06 -04:00
Scott González
1272fca9ef Selectmenu: Don't use active items at all
Menus only use active items for nested menus which selectmenu doesn't support.
Selectmenu should only be working with focused items.

Ref gh-1224
2014-04-18 12:37:06 -04:00
Scott González
1849655980 Selectmenu: Cleanup
Ref gh-1224
2014-04-18 12:36:45 -04:00