Commit Graph

5378 Commits

Author SHA1 Message Date
Jörn Zaefferer
5aac8f563f Dialog: Add missing unit test for aria-describedby attribute 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
32a893128d Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
41c2afd66b Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0 Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9 Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
299681e8f0 Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b694409e76 Dialog: Extend visual test to verify DOM position restore on destroy; overhaul unit test for destroy method. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
d8b98ec3bb Dialog: Tiny code improvements 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
e3dcaf28eb Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0bc73b74b6 Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
972f5c192c Dialog: Button is now a fixed dependency, so remove the check 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0ae6fc1e02 Dialog: Remove useless tmp vars. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
625a111fb9 Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
4c9caa8169 Dialog: Extract button pane creation into _createButtonPane 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1d6ce644e0 Dialog: Refactor _create, extracting title bar creation in _createTitlebar 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
f0acaac230 Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7a0353500a Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1001504249 Dialog: Remove outdated TODO 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
c8aef203cb Dialog: Have _makeResizable look at options instead of passing handles. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
16a79c1b9c Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7e964be80c Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
f7d3a51589 Dialog: Only add the new dialogClass, not the base classes when changing the option. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
324d54dd32 Dialog: Use $.isEmptyObject() to check if there a button-option properties 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4e03321fd7 Dialog: Trigger focus event when dialog is moved to top. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
b6cefc797e Dialog: Remove deprecated disableSelection() usage. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
4632780435 Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2062a18db6 Dialog: Inline code review 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
0a25b2c448 Dialog: move to top when opening again, and focus as if opened from scratch. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
8ee8046c02 Dialog: Keep focus inside modal dialog, by handling focus events on elements outside of it 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2a887e4321 Dialog: Improve accessibilty - add an aria-describedby attribute on the dialog if there is nothing yet in the dialog content. Partial fix for: 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
62ae078f14 Build: Install shell dependencies in the right direcytory. Update trac instructions to point out that only minutes and seconds need to be changed. Fixes #8848 - Build: release.js fails to require shelljs/global. 2012-11-25 23:35:30 +01:00
Corey Frang
d7adc2bae9 Effects Core: Upgrading jQuery Color to 2.1.1 2012-11-23 11:18:07 -06:00
Jörn Zaefferer
2ca5fbf82c Add missing authors 2012-11-23 15:01:16 +01:00
TJ VanToll
421aeaa081 Slider: Explicitly apply opacity filter to disabled handles. Fixed #6727 - Slider: Visual issues with disabled slider in IE8 2012-11-22 22:45:03 -05:00
Corey Frang
a217bd3b16 Effects: Making sure outerHeight and outerWidth make it through to the .size() implementation in all cases - Fixes IE8 effects failure 2012-11-22 04:12:30 -06:00
kborchers
d3bc471688 Progressbar: Add ability to set value: false for an indeterminate progressbar. Fixes #7624 - Progressbar: Support value: false for indeterminate progressbar 2012-11-21 21:48:17 -06:00
Mike Sherov
509259a66e Button: add explanatory comment for when we bind to blur 2012-11-21 19:58:59 -05:00
Mike Sherov
70e013830d Button tests: fix IE7 fail for latest focus tests 2012-11-21 19:29:22 -05:00
TJ VanToll
93abe02b60 Button: Fixing handling of the disabled options on refresh method calls. Fixed #8828 - Button: Refresh does not re-enable disabled button. 2012-11-21 19:24:24 -05:00
Samuel Bovée
cb748b4a6f Slider: factorize code with Widget method call. Fixed #8772 - Wrong slider UI state when disabled at init 2012-11-21 19:18:00 -05:00
Mike Sherov
f13b5dfa7f Button: add blur event to buttons. Fixes #8559 - Button: Button doesn't remove active state when using keyboard. 2012-11-21 19:14:04 -05:00
Scott González
c348f2890c Button tests: Whitespace. 2012-11-20 12:52:26 -05:00
Mike Sherov
3c6c22b179 CSS: remove spaces from opacity filters so themeRoller can replace properly 2012-11-20 08:07:03 -05:00
Anika Henke
010e09fa62 CSS: Reformatted CSS to use better coding standard 2012-11-19 21:31:28 -05:00