Commit Graph

33 Commits

Author SHA1 Message Date
Jörn Zaefferer
a09f5c07f5 Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Scott González
8c36603305 Dialog tests: Work around inconsistent handling of non-breaking spaces in IE7/8 with jQuery <1.8. 2012-11-15 10:47:36 -05:00
Mike Sherov
543abc9b1f Dev: clean up dialog test suite with new helper methods. Fixes #8803 - Dev: re-enable the dialog test suite 2012-11-09 15:02:26 -05:00
Mike Sherov
3df9ea29e6 Dev: remove globals from tests and moved test helpers to correct location - Fixed #8770 Dev: Remove globals and Standardize Test Suite 2012-11-03 16:17:16 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Scott González
5ae668fdb6 Tests: Enable QUnit.config.requireExpects. 2012-06-27 11:32:48 -04:00
Scott González
0a5a9090f8 Tests: Lint. 2012-04-19 10:28:26 -04:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
James Khoury
ce0afde900 Dialog: Modified the dialog._size() to use outerHeight in calculating the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set. 2011-11-28 16:52:10 -05:00
Scott González
6fb68568be Tests: Cleanup. 2011-08-03 21:43:52 -04:00
Scott González
325ee6e871 Widget: define a null default for the create callback. 2011-04-25 14:04:30 -04:00
Douglas Neiner
15c97e0b76 Dialog: Added a class to dialog wrapper when it is currently displaying buttons, includes unit tests for changes. Fixed #7057 - An extra class is needed on the dialog wrapper to specify when a buttonset is showing 2011-03-03 09:37:16 -05:00
Scott González
22cf318e40 Dialog position tests: Use Math.round() instead of Math.floor(). 2010-12-03 09:14:27 -05:00
Scott González
0c82f7ec2c Dialog tests: Enabling in TestSwarm. 2010-09-07 12:28:36 -04:00
Scott González
0050f234a8 Dialog: Fixed test for default title. Some browsers were returning an actual non-breaking space and some were returning the string "&nbsp;". 2010-09-07 09:49:58 -04:00
Scott González
d80e2236f6 Dialog: Reduced size of dialogs in height/width tests. 2010-09-07 08:58:20 -04:00
Scott González
2365d03cef Dialog: Fixed a broken maxHeight test.
The size tests are fragile because they require the browser window to be large enough to contain the dialog.
2010-09-02 08:41:28 -04:00
Scott González
95a34593f9 Dialog: Added additional syntax for creating buttons. Fixes #4344 - Dialog: Enhanced Button Option. 2010-08-31 10:17:53 -04:00
Scott González
79ee6f0d7b Dialog: When using the title attribute, update the title option. Fixes #5877 - Dialog: when using the title attribute, the title option should be updated. 2010-08-27 18:02:11 -04:00
Scott González
61e0aeac7e Dialog: Wrap buttons in a div so we can float the div instead of the individual buttons. Fixes #4529 - dialog buttons are accessed in wrong order using tab. 2010-07-29 20:56:28 -04:00
Scott González
2366a81740 Dialog: Fixed tests for position option. 2010-07-16 08:55:03 -04:00
Ben Hollis
6de9a5368c Dialog: allow setting position with ui.position arguments. Fixes #5459 - Dialog: expose .position() API 2010-07-14 16:29:28 -04:00
Scott González
b3a095d3ef Removed use of .data() for getting/setting options in tests; using each plugin's option method instead. Fixes #4853 - Remove use of .data() for options in tests. 2009-11-09 01:50:23 +00:00
Jörn Zaefferer
122a6cdd5f dialog: fixed _position regression; wrote a test for the default positon, which still needs some tuning 2009-09-19 14:03:53 +00:00
Richard Worth
5c87e2e448 dialog unit tests: options closeOnEscape, draggable 2009-09-19 10:16:08 +00:00
Scott González
2b8109e119 Fixed dialog tests to use same instead of equals for hashes. 2009-03-28 00:37:16 +00:00
Richard Worth
52005f42dd dialog unit tests: split tests into individual files 2009-02-04 04:35:18 +00:00
Richard Worth
43ab3a04e5 unit tests: created separate file for each module: core, common widget, events, methods, options, tickets 2009-02-02 14:36:08 +00:00