Commit Graph

26 Commits

Author SHA1 Message Date
Jörn Zaefferer
2aabd427eb Tests: Fix style issues with missing or multiple line breaks
As pointed out by jscs, after a esformatter run. The latter doesn't
address these, so fixing them manually.
2015-01-24 17:10:20 +01:00
Brian J. Dowling
9660b43c01 Tests: Fix andenable a couple of unit tests: dialog, tooltip, draggable
Some unit tests were disabled in phantomjs. Dialog and draggable
depended on a larger viewPort. Tooltip just worked, that was reenabled
as well.

Closes gh-1173
2014-02-11 19:47:29 +01:00
Jörn Zaefferer
90135b27f8 Widget tests: Use instance method. Also replace a few instances of $.data in widget implementations. 2013-03-19 16:53:35 +01:00
Kris Borchers
2a8494fc81 Dialog Tests: Cleanup el -> element 2013-01-30 23:44:25 -06:00
Kris Borchers
e886e4a9c1 Dialog Tests: Add test to ensure dialog keeps focus when clicking a modal overlay 2013-01-30 23:44:03 -06:00
Mike Sherov
0d4022bceb Tests: Convert single quotes to double quotes. 2012-12-26 08:08:48 -05:00
Mike Sherov
e83a89dd7d Dev: Remove *_tickets.js test files and move the associated tests to the proper locations. 2012-12-07 20:06:29 -05:00
Kris Borchers
a68d5ca31d Dialog: Add unit test to cover #8789 and #8838. 2012-11-26 12:14:29 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Scott González
f5870712c1 Updated all widgets to use proper data keys when getting plugin instances. 2012-11-09 13:28:13 -05:00
Mike Sherov
3df9ea29e6 Dev: remove globals from tests and moved test helpers to correct location - Fixed #8770 Dev: Remove globals and Standardize Test Suite 2012-11-03 16:17:16 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
David Petersen
35dc9307fc Dialog: Use _hide() to make sure close event gets triggered. Fixes #8684 - jQuery dialog with hide options does not trigger close event. 2012-10-17 20:28:27 -04:00
Scott González
0a5a9090f8 Tests: Lint. 2012-04-19 10:28:26 -04:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
Scott González
b42125af43 Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose. 2010-12-10 14:31:36 -05:00
Scott González
de02aa34a8 Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event. 2010-09-02 08:35:40 -04:00
Richard Worth
7898303437 dialog: corrected typo in ui.position property for drag events. Updated unit tests tracking fix of #5291 2010-03-11 20:48:21 +00:00
Richard Worth
3eaf9daaca Deprecated beforeclose option instead of removing it for now, fixes reopened #4669 - Dialog: beforeclose option should be beforeClose. 2010-01-27 10:31:17 +00:00
Jörn Zaefferer
219c81a208 dialog: fixed dragStop test (was using dragStart instead of dragStop, copy&paste FTF) 2009-09-14 14:54:15 +00:00
Scott González
a716261ab6 Dialog: Changed beforeclose option to beforeClose. Fixes #4669 - Dialog: beforeclose option should be beforeClose. 2009-07-11 00:36:36 +00:00
Scott González
1a03453654 Widget factory: Force event types to be lowercase. Fixes #4668 - All event types should be lowercase even if the corresponding callback is camelcase. 2009-07-11 00:30:46 +00:00
Scott González
2ebc73e2b7 Dialog: Use _trigger for drag and resize events instead of executing callbacks directly. Fixed #4629 - Dialog events not being triggered. 2009-07-10 20:00:06 +00:00
Scott González
44ec979713 Widget factory: Convert falsy data values to an empty hash in _trigger. Fixes #4650: ui hash not always provided in events/callbacks. 2009-07-04 03:39:19 +00:00
Richard Worth
52005f42dd dialog unit tests: split tests into individual files 2009-02-04 04:35:18 +00:00
Richard Worth
43ab3a04e5 unit tests: created separate file for each module: core, common widget, events, methods, options, tickets 2009-02-02 14:36:08 +00:00