Commit Graph

1888 Commits

Author SHA1 Message Date
Scott González
50efd6e1b0 Menu: Ignore mouse events triggered due to page scrolling
Fixes #9356
Closes gh-1806
2017-05-02 15:16:17 -04:00
Scott González
a3e953b495 Menu: Don't focus dividers when wrapping via keyboard navigation
Fixes #15157
Closes gh-1804
2017-05-02 15:12:04 -04:00
Alexander Schmitz
abc9e7ce2f Button: Fix backcompat when called on collection of mixed elements
Fixes #15109
Closes gh-1808
2017-05-02 15:11:24 -04:00
Scott González
adcf9b6f6e Labels: Handle empty sets
Fixes #15184
2017-05-02 12:42:49 -04:00
Scott González
0d25a36eec Menu: Close menus immediately on selection or click outside
Fixes #15034
Closes gh-1807
2017-04-25 06:33:00 -04:00
Scott González
b3c0a7f71d Widget: Handle Object.create(null) for options objects
Fixes #15179
Closes gh-1809
2017-04-24 12:41:29 -04:00
Konstantin Dinev
c426b9a203 Resizable: Keep user-provided handles on destroy
Closes gh-1798
Ref gh-1795
2017-04-17 14:58:12 -04:00
Konstantin Dinev
278d1e1108 Resizable: Keep user defined handles on _setOption
Fixes #15084
Closes gh-1795
2017-02-24 14:30:58 -05:00
Scott González
a3b9129be1 Spinner: Ignore mousewheel events when not focused
Fixes #15139
Closes gh-1794
2017-02-21 12:45:19 -05:00
Scott González
a2b25ef6ca Selectmenu: Don't render options with the hidden attribute
Fixes #15098
2016-11-16 12:52:15 -05:00
Michał Gołębiowski
4673c8808b Build: Add jQuery 3.1.1
Closes gh-1766
2016-11-02 12:52:22 -04:00
Scott González
0627eb3645 Form: Rename from .form() to ._form() since its not for public use
Fixes #15074
Closes gh-1760
2016-10-11 10:15:04 -04:00
Kevin Cupp
87eab46a58 Sortable: Setting table row placeholder height to be same as sorted row
Fixes #13662
Closes gh-1578
2016-10-04 15:22:14 -04:00
milk54
b9ffc34710 Tabs: Remove presentation role
Fixes #10122
Closes gh-1748
2016-09-29 10:15:19 -04:00
Sergei Ratnikov
c481400f22 Resizable: Fix aspectRatio cannot be changed after initialization.
Fixes #4186
Closes gh-1750
2016-09-28 11:55:13 -04:00
Alexander Schmitz
89af4c292e Widget: Untrack classes elements when they are removed from the DOM
Fixes #15043
Closes gh-1744
2016-09-13 15:11:34 -04:00
Ryan Oriecuia
8c66934434 Draggable: Fix spurious blur in dialogs on mousedown
I was running into a problem with a popup menu control in a dialog; clicks
weren't working (but keyboard was working fine). It turned out that the menu
was getting destroyed before the click event could fire.

Tracked down the issue to the way draggable blurs focused controls; it was
doing the blur before it ran through the logic to figure out if the drag was
actually on the handle. I've moved the blur below these checks, so it'll only
blur things if it actually needs to handle the drag. Otherwise, it asserts no
opinion on what should and shouldn't be focused, which seems like the way
things ought to be.

Also, added a unit test to check for the expected behavior.

Fixes #15046
Closes gh-1730
2016-09-13 08:53:00 -04:00
Scott González
51461d5238 Slider: Add demo for custom handle
Fixes #15023
Closes gh-1740
2016-09-13 08:41:33 -04:00
Scott González
4e39014803 Dialog: Fix code style 2016-08-31 11:22:54 -04:00
Scott González
d2ce363200 Dialog: Allow for subpixel calculation errors in tests
Tests were failing in IE 10-11 with values that were off by 0.01 pixels.

Closes gh-1737
2016-08-31 11:01:39 -04:00
Scott González
3a45a47968 Effects: Adjust animation duration in tests
With jQuery 3 using `requestAnimationFrame()`, the `setTimeout()` timing
for short animations wasn't working consistently. This resulted in infrequent
failures everywhere (but infrequent enough that it's hard to even notice), but
consistent failures in IE and Edge. Bumping up the duration and running the
assertions in the middle seems to give consistent results.

Eventually, we should refactor this to use `requestAnimationFrame()` in the
tests themselves to avoid problems like this.

Closes gh-1738
2016-08-30 16:37:24 -04:00
Felix Nagel
ac9ca9e52c Menu: Support number pad keyboard input
Fixes #15031
Closes gh-1732
2016-08-24 11:56:26 -04:00
Scott González
3dd8a09b44 Widget: instance() should return undefined for empty sets
Fixes #15019
2016-08-04 09:04:49 -04:00
Scott González
6c754b4b5b Dialog: Support deprecated button options
Fixes #15016
Closes gh-1723
2016-07-25 08:38:51 -04:00
Scott González
ea44d84975 Build: Add jQuery 3.1.0 2016-07-08 13:02:10 -04:00
Scott González
3b066697bc Tests: Only test latest patch versions for jQuery Core in TestSwarm
Adds some missing tests to TestSwarm and `all.html`.
2016-07-08 12:51:44 -04:00
Scott González
4d9779342e Resizable: Avoid Array#map() in tests for IE8 2016-07-07 10:18:18 -04:00
Scott González
92451b44c1 Tooltip: Allow tracking tooltips to be off by a fraciton of a pixel
Closes gh-1718
2016-07-07 09:16:52 -04:00
Scott González
dc8b1c8bb9 Tests: Add jQuery 3.0.0 to missing systems 2016-07-07 09:07:54 -04:00
Scott González
ba91b324ab Effects: Fix timing of .animateClass() assertion 2016-07-06 16:29:43 -04:00
Scott González
9d807ba109 Tabs: Remove test for Ajax URLs containing hashes
This hasn't been a problem for a long time and jQuery no longer removes
the hash in 3.0.0, so the test started to fail even though the actual
code is working just fine.

Ref #3627
Ref jquery/jquery#1732
2016-07-06 13:09:15 -04:00
Gabriel Schulhof
3a9a3c7c5b Controlgroup: Correctly handle non-empty child class key
Fixes #14984
Closes gh-1713
2016-07-06 09:42:31 -04:00
Alexander Schmitz
8a79fc8784 Controlgroup: Add "only" position to class generator functions
Fixes #14972
Closes gh-1711
2016-06-09 14:10:40 -04:00
Scott González
3c860f95aa All: Replace non-breaking spaces with regular spaces 2016-06-08 13:03:42 -04:00
Alexander Schmitz
abc2a755f9 Checkboxradio: Use new ui-state-checked class in checkboxradio
Using `ui-state-highlight` caused a conflict with dialog

Fixes #14955
Closes gh-1712
Closes gh-1704
2016-06-06 11:34:52 -04:00
Alexander Schmitz
7d5e6d2496 Controlgroup: Fix rendering of labels
Fixes #14967
Closes gh-1703
2016-05-26 09:15:48 -04:00
Alexander Schmitz
81a8e30c07 Controlgroup: Fix issues with compatibility with spinner
Fixes #14966
2016-05-26 09:15:48 -04:00
Alexander Schmitz
04b670e6cc Controlgroup: Don't remove existing classes classes
unless its a corner class

Fixes #14960
2016-05-26 09:15:48 -04:00
Michał Gołębiowski
468f1e3abe Build: Add jQuery 1.12/2.2 to the test configuration
Ref gh-1706
2016-05-25 16:42:06 -04:00
Scott González
50d910b848 Focusable: Detect disabled fieldsets
Fixes #14970
Closes gh-1705
2016-05-25 15:32:18 -04:00
Scott González
fbc79e1bda Tabs: Fix test 2016-05-25 08:41:08 -04:00
Scott González
010f5f9d13 Tooltip: Fix re-enabling of delegated tooltips
Fixes #14950
Closes gh-1699
2016-04-21 10:59:27 -04:00
Amanpreet Singh
10741ef7f8 Widget: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
92f122d5b1 Tooltip: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
bfcd6358fe Tabs: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
b5028f02bf Spinner: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
749f95ee0a Sortable: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
38d473708b Slider: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
d00c5641b9 Selectmenu: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
b6392d6a6d Selectable: Shift to use no globals 2016-04-14 00:14:57 +05:30
Amanpreet Singh
611e3648b5 Resizeable: Shift to use no globals 2016-04-14 00:14:43 +05:30
Amanpreet Singh
b7b53d2163 Progressbar: Shift to use no globals 2016-04-14 00:08:29 +05:30
Amanpreet Singh
059b5b17a1 Position: Shift to use no globals 2016-04-14 00:08:29 +05:30
Amanpreet Singh
8127030ed4 Menu: Shift to use no globals 2016-04-14 00:08:28 +05:30
Amanpreet Singh
f0c8b77123 Form: Shift form-reset-mixin to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
3dd45b1ae6 Effects: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
8470b6a965 Droppable: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
46f607af97 Draggable: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
86fd11d5a7 Dialog: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
e8e8867707 Datepicker: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
20b6e976fb Core: Shift to no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
290f0e73be Controlgroup: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
e089b1dd49 Checkboxradio: Shift to use no globals 2016-04-14 00:06:12 +05:30
Amanpreet Singh
fd1c236c0f Autocomplete: Shift to use no globals 2016-04-14 00:06:11 +05:30
Amanpreet Singh
f375fd1300 Button: Shift to no globals 2016-04-14 00:06:11 +05:30
Amanpreet Singh
d83db4f528 Accordion: Shift to use no globals 2016-04-14 00:06:11 +05:30
Scott González
57f801f1de Menu: Don't reset active element until after triggering blur event
This ensures that `ui.item` actually exists in the `blur` event.

Fixes #14945
Closes gh-1696
2016-04-13 11:08:21 -04:00
Konstantin Dinev
623b64eefc Resizable: Implement setOption for handles
Fixes #3423
Closes gh-1666
2016-03-30 14:08:41 -04:00
Mukul Hase
a1905e2c5e Slider: Fixed max value miscalculation
Fixes #12852
Closes gh-1664
2016-03-30 13:28:04 -04:00
Alexander Schmitz
bff8277fbc Selectmenu: Prepend icon and move overflow to text span
Fixes #14938
Closes gh-1685
2016-03-30 11:53:28 -04:00
Jörn Zaefferer
4866e14922 Menu: Remove active class from top-level item when menu is blurred
This issue was introduced by 0bbd156918,
which reduced the use of ui-state-focus and ui-state-active to using
only ui-state-focus. This introduced the issue addressed here.

The fix is more of a workaround. With test test in place, we can
investigate a better solution in the future.

Fixes #14919
2016-03-11 18:27:58 +01:00
Alexander Schmitz
20466d5027 Selectmenu: Fixed selectmenu icon float right
Also removes the icon space as its not needed with a floated icon

Fixes #14914
Closes gh-1671
2016-02-24 11:29:44 -05:00
Alyosha Pushak
c87653bc24 Accordion: Correct height calculated when closed
Fixes #11938
Closes gh-1536
Closes gh-1616
2016-02-09 14:40:29 -05:00
Scott González
63c103dd54 Draggable: Improve detection for when to blur the active element
Fixes #12472
Fixes #14905
Closes gh-1548
2016-02-09 13:37:26 -05:00
Scott González
8fc3ba22ba Datepicker: Fix flaky test 2016-02-09 11:28:31 -05:00
Michał Gołębiowski
15586ea752 Build: Use jquery-git in place of jquery-compat-git
jQuery Compat is not going to get released after all; jQuery UI should be tested
against jquery-git instead of jquery-compat-git.

Closes gh-1646
2015-11-14 06:12:55 -05:00
Scott González
e77fbe5388 Checkboxradio: Properly find radio groups from the associated form
Fixes #9973
Closes gh-1631
2015-10-29 11:19:13 -04:00
Jörn Zaefferer
f1b643ec67 Button: Add tests for button with html markup
Ref gh-1632
Ref jquery/api.jqueryui.com#281
2015-10-29 15:45:26 +01:00
Jörn Zaefferer
9644e7bae9 Dialog: Escape closeText option before passing it to button
Ref gh-1632
Fixes jquery/api.jqueryui.com#281
2015-10-28 19:48:35 +01:00
Scott González
65f4176249 Checkboxradio: Fix error tests with jQuery 1.7.0 2015-10-28 09:23:28 -04:00
Scott González
a640fae24e Controlgroup: Add compound test suite for all jQuery versions 2015-10-28 09:16:31 -04:00
Scott González
926f3c6c3a Checkboxradio: Add compound test suite for all jQuery versions 2015-10-28 09:15:11 -04:00
Scott González
6e0b2a580d Controlgroup: Test cleanup 2015-10-27 16:32:30 -04:00
Scott González
d4b0699578 Checkboxradio: Test cleanup 2015-10-27 16:05:52 -04:00
Leonardo Balter
60fa118955 Tests: Fix improper async sortable test
Caught when testing jQuery UI against the new QUnit version, where start throws
an error if called with a non-numeric error.

Closes gh-1630
2015-10-27 13:55:55 -04:00
Scott González
33398fa4f1 Draggable: Skip window bubbling test in IE 8
IE 8 implements DOM Level 2 Events which only has events propagate
up to the document, not the window.

Ref #10818
Ref gh-1621
Closes gh-1627
2015-10-27 11:12:14 -04:00
Scott González
81a002991e Tabs: Handle overly-precise values in tests in IE
Closes gh-1628
2015-10-27 11:06:48 -04:00
Jörn Zaefferer
39853fda45 Selectmenu: Handle form resets
Fixes #12236
Ref gh-1550
2015-10-27 10:28:04 -04:00
Jörn Zaefferer
09fde89a24 Controlgroup: Fix create and destroy for controlgroupLabel
Creating the label broke while doing a refactoring, the lack of tests
allowed that to go unnoticed. Shouldn't happen again with the extra
tests, covering both controlgroupLabel and spinner.
2015-10-26 10:09:20 -04:00
Jörn Zaefferer
3570cc5a2b Tests: Fix button space assertions on IE8
IE8 still doesn't keep the space in the text (or HTML) representation.
We don't really care, so adding more trims in these tests as well.
2015-10-25 11:25:00 -04:00
Jörn Zaefferer
56d6ddc2ba Draggable: Fix options tests
These failed when running through tests/unit/all.html, due to the smaller
iframe. Reducing a browser window enough triggered the same issue. Making
the top offset much smaller fixes that.

The rest is fixing bad indent and adds a missing module call.
2015-10-25 11:22:40 -04:00
Hannah Methvin
a1d69208ba Mouse: Don't stop propagation of mouseup
Fixes #10818
2015-10-18 12:36:43 -04:00
Jyoti Deka
4c5cd2018d Slider: Add missing unit test cases for values method
Closes gh-1573
2015-10-17 16:08:29 -04:00
Scott González
1007ee811c Autocomplete: Whitespace 2015-10-16 14:14:45 -04:00
Scott González
548fbf570c Autocomplete: Close the menu on any outside interactions
This ensures that the menu will close if the user interacts with a
draggable, resizable, etc. element since those interactions don't
change focus.

Ref #6642
Closes gh-1614
2015-10-16 14:09:05 -04:00
Jörn Zaefferer
52d9ec6c4d Checkboxradio: Add ui-state-highlight class to icon on create
This was already toggled in _toggleClasses, but that isn't called
on create.
2015-10-08 14:03:00 -04:00
Jörn Zaefferer
9ff3d8fb90 Controlgroup: Fix refresh method tests by adding text content to button
In IE8, the empty elements cause issues. Adding text content makes
sense, since empty elements are useless.
2015-10-08 14:03:00 -04:00
Jörn Zaefferer
81c4fdfecd Button: Can't test for " " in IE8, just make sure the element exists 2015-10-08 14:02:59 -04:00
Jörn Zaefferer
44eb0ccba9 Checkboxradio: Fix label option tests by trimming DOM text
IE8 is inconsistent in outputting space through .html() and .text()
methods, but since it renders it correctly, we can just ignore it.
2015-10-08 14:02:59 -04:00
Jörn Zaefferer
dc2bede254 Checkboxradio: Fix invalid markup in core tests 2015-10-08 14:02:59 -04:00