Commit Graph

209 Commits

Author SHA1 Message Date
Jörn Zaefferer
1096f19f37 Dialog: Keep track of instances to focus when elements outside the dialog get focus. Works with inheritance. Adds tests for both. Fixes #9241 - Dialog: UI dialog inheritance causes undefined property '_focusTabbable' in IE9 2013-11-20 16:04:13 +01:00
Jörn Zaefferer
9fd0e86820 Dialog: Update code style, adding whitespace around string arguments and array indices 2013-11-15 16:48:31 +01:00
Jörn Zaefferer
0e5a2e126a Dialog: Restore focus to the previously focused element when window regains focus. Fixes #9101 - Dialog: Track last focused element instead of always focusing the first tabbable element 2013-11-15 08:16:24 +01:00
Scott González
d6f85644d4 Dialog: Move option category hashes into the widget prototype. 2013-10-24 09:19:41 -04:00
Scott González
ed09ee5b75 Dialog: Added note explaining that _on() is safe to use for shared handlers because of stacking. 2013-10-03 12:09:50 -04:00
Jörn Zaefferer
e263ebda99 Dialog: Switch back to shuffling z-index, but only look at .ui-front siblings.
Fixes #9166 - Dialog: moveToTop implementation resets flash/video/iframe/scroll
Fixes #9364 - Dialog: Click of element with tooltip scrolls the dialog to the top
2013-10-02 17:02:28 +02:00
TJ VanToll
2dfe85d3e2 Dialog: Safe activeElement access.
Fixed #9420 - Dialog: Close causes blur of window in IE9
Fixed #8443 - Dialog: "unspecified error" when using ie9 and iframe
2013-10-01 09:22:07 +03:00
Scott González
e628d0e4ba Dialog: Capitalize default value for closeText option. Fixes #9500 - Dialog: Capitalize 'close' for closeText option. 2013-08-15 16:56:49 -04:00
Scott González
c9815f13b4 Dialog: Search the correct document for focus trapping. Fixes #9439 - Dialog: Context is not respected for modals. 2013-08-07 08:57:36 -04:00
Scott González
16c375d374 Dialog: Use proper position data after drag and resize. Fixes #9351 - Dialog: Incorrect value for position option after resize. 2013-05-31 15:01:15 -04:00
TJ VanToll
c19e7b3496 Dialog: Add type="button" to the close button. Fixed #9312: Dialog: closes on enter in textbox in IE. 2013-05-23 19:57:32 -04:00
Scott González
fadf2b312a All: Remove inline JSHint settings. 2013-04-22 12:35:21 -04:00
Scott González
0cc40d799f Dialog: Removed deprecated position handling. Fixes #8825 - Dialog: Remove array and string notations for position option. 2013-03-15 06:41:06 -04:00
Scott González
51eb28e76e Dialog: Extract check for which elements can gain focus into its own method for overriding. Fixes #9087 - Dialog: Allow registering elements outside a dialog for use when a modal dialog is open. 2013-02-20 17:35:48 -05:00
Scott González
5e1b8dc71a Dialog: Don't hard-code widget data key. Fixes #9097 - UI dialog inheritance. 2013-02-18 16:07:15 -05:00
Scott González
a7353e7c9b Dailog: Cover iframes during drag and resize. Fixes #7650 - Dialog cannot be dragged properly with IFRAME. 2013-02-03 08:55:34 -05:00
Scott González
8724092e50 Dialog: Don't use ._on() for modal event handlers. Fixes #9048 - Dialog: broken focusin event handler when beforeclose event of a modal opens another modal. 2013-02-02 19:32:42 -05:00
Scott González
7bbda71a32 Dialog: Check for empty array in addition to empty object when checking if there are buttons. Fixes #9043 - Dialog: Buttonpane shown with no buttons when modifying native prototypes. 2013-02-01 08:59:55 -05:00
Scott González
62cda1f95d Dialog: Set the _isOpen flag immediately in open(). Fixes #8958 - Dialog: Double ui-widget-overlay when opening modal dialog triggers an event opening same dialog. 2013-01-31 17:20:19 -05:00
Kris Borchers
d1505e3434 Dialog: Move call to _focusTabbable and triggering of open and focus events into the _show callback. Fixes #6756 - Dialog: show: "blind" with link in content doesn't animate properly. Fixes #8051 - Dialog: 'Explode' dialog animation causes crash in IE 6, 7 and 8. Fixes #4421 - Dialog: Focus lost from dialog which uses show-effect 2013-01-30 12:30:37 -06:00
David Sullivan
55360eeb7e Dialog: modified _createOverlay to _appendTo instead of document.body. Fixed #8984 - Modal dialogs display behind overlay when using appendTo option 2013-01-26 11:34:51 -05:00
Scott González
c53198c209 Dialog: Allow interaction with datepickers from modal dialogs. Fixes #8989 - Dialog: Cannot change month/year in datepicker within modal. 2013-01-25 08:51:13 -05:00
David Petersen
649f105229 Dialog: Don't handle overlays on destory if there are not any. Fixed: #9004 - failed in _destroyOverlay when I destroy a modal dialog thau was never opened. Fixed: #9000 Dialog leaves broken event handler after close/destroy in certain cases 2013-01-24 13:43:02 -06:00
Scott González
83cbf97978 Update copyright year to 2013. 2013-01-10 08:52:20 -05:00
Mike Sherov
74d7eac2da All: Convert single quotes to double quotes. 2012-12-25 12:01:09 -05:00
Scott González
0f111a2ac4 Dialog: Spacing. 2012-12-12 08:47:21 -05:00
Scott González
b9f206dbcf Dialog: Cleanup. 2012-12-11 16:23:18 -05:00
Scott González
d4551bc3b8 Dialog: Respect maxHeight when determining size on open. Fixes #4820 - Dialog: Auto height does not respect the maxHeight option. 2012-12-07 16:57:03 -05:00
Scott González
70b16ef445 Dialog: Added appendTo option. Fixes #7948 - Dialog: Allow dialog to be attached to a element other than body. 2012-12-07 14:54:21 -05:00
Scott González
b239298946 Allow higher cyclomatic complexity in functions that sanely use switch statements. 2012-12-06 14:31:21 -05:00
Scott González
f59f5a8b12 Dialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed. 2012-12-05 11:53:34 -05:00
Scott González
3c2acc3227 Dialog: Remove width, min-height, height styles on destroy. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed. 2012-12-04 10:03:05 -05:00
Scott González
050e71bdd8 Revert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers."
This reverts commit d687a1b10d.
2012-12-04 09:21:33 -05:00
Jörn Zaefferer
9bd44301d3 Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties. 2012-12-04 01:17:00 +01:00
Jörn Zaefferer
1e8baf5683 Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist. 2012-12-04 01:08:34 +01:00
Jörn Zaefferer
d687a1b10d Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers. 2012-12-04 00:35:47 +01:00
Jörn Zaefferer
13505e5945 Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM. 2012-11-30 13:08:56 +01:00
Jörn Zaefferer
24d9141597 Dialog: Use consistent code for appending to body 2012-11-29 17:40:31 +01:00
Jörn Zaefferer
7e9060c109 Dialog: Extract setting the title into a _title method, use .text() to prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
60486ac632 Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE. 2012-11-26 10:28:25 +01:00
Kris Borchers
d179cbaf32 Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
ec1f1bde76 Dialog: Follow-up to c77ca67 - exclude button options from properties to create the button. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
a09f5c07f5 Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
32a893128d Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
41c2afd66b Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0 Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9 Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
d8b98ec3bb Dialog: Tiny code improvements 2012-11-26 10:28:23 +01:00