Commit Graph

123 Commits

Author SHA1 Message Date
Paul Capron
f5d38e2e05
Focusable: Fix handling of visibility: collapse
"collapse" is similar to "hidden", with a slight difference in the case
of tr/tbody/td/colgroup elements.
See https://www.w3.org/TR/CSS22/visufx.html#visibility
See https://www.w3.org/TR/CSS22/tables.html#dynamic-effects
See https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Table_example

"visibility: collapse" elements are always not focusable, though.

Commit d3025968f3 introduced a regression by testing with `!== "hidden"`
instead of `=== "visible"`.

Closes gh-1843
2020-10-14 23:53:11 +02:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Michał Gołębiowski-Owczarek
98b539171b All: Migrate away from deprecated/removed Core APIs
Summary of the changes:

* Build: Add jQuery 3.2.0-3.4.1 to versions UI can be tested against
* Build: Load jQuery & Migrate via HTTPS
* Build: Add package-lock.json to .gitignore
* Build: Update jQuery Migrate from 3.0.0 to 3.1.0
* Build: Allow to run tests against jQuery 3.x-git
* Build: Fix formatting according to JSCS rules
* Build: Disable JSCS for the inlined jQuery Color
* All: Switch from $.isArray to Array.isArray (jQuery.isArray will be
  removed in jQuery 4.0)
* All: Switch from `$.isFunction( x )` to `typeof x === "function"`
  (jQuery.isFunction will be removed in jQuery 4.0)
* All: Inline jQuery.isWindow as it'll be removed in jQuery 4.0
* Effects: Fix a timing issue in a variable declaration. Previously,
  a jQuery object was created, chained & assigned to a variable that
  was then accessed in a callback used inside of this chained
  definition. Due to a timing difference in when the callback fired for
  the first time in latest jQuery master, it was being called before
  the variable was defined.
* Tests: Make dialog & draggable unit tests less strict (newest jQuery
  returns fractional results in some cases, making comparisons fail when
  there's a tiny difference)
* All: Migrate from $.trim to bare String.prototype.trim (jQuery.trim
  will be deprecated in jQuery 3.5)

Closes gh-1901
2019-12-08 22:23:08 +01:00
Scott González
adcf9b6f6e Labels: Handle empty sets
Fixes #15184
2017-05-02 12:42:49 -04:00
Scott González
0627eb3645 Form: Rename from .form() to ._form() since its not for public use
Fixes #15074
Closes gh-1760
2016-10-11 10:15:04 -04:00
Scott González
50d910b848 Focusable: Detect disabled fieldsets
Fixes #14970
Closes gh-1705
2016-05-25 15:32:18 -04:00
Amanpreet Singh
20b6e976fb Core: Shift to no globals 2016-04-14 00:06:12 +05:30
Scott González
d3025968f3 Focusable: Fix handling of visibility: inherit
Ref #14596
Ref gh-1583
Closes gh-1605
2015-09-29 12:48:11 -04:00
Weston Ruter
0db243a736 Core: Remove ancestor visibility requirement from :focusable selector
* Check computed visibility in addition to :visible
* Add tests for nested visibility override

Fixes #14596
Closes gh-1583
2015-09-24 08:13:59 -04:00
Alexander Schmitz
fe5534b347 Core: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:24 -04:00
Alexander Schmitz
37602d7e64 Core: Movie uniqueId into its own module and deprecate core module
uniqueId was the last thing in the core module, and it is now just a helper
which require all the modules it used to contain.

Closes #9647
2015-08-08 00:29:37 -04:00
Alexander Schmitz
6064a5e048 Core: Move tabbable into its own module
Ref #9647
2015-08-08 00:29:37 -04:00
Alexander Schmitz
2c92f10747 Core: Move labels into its own module
Ref #9647
2015-08-08 00:29:36 -04:00
Alexander Schmitz
64076ecfb5 Core: Move form method into its own module
Ref #9647
2015-08-08 00:29:36 -04:00
Alexander Schmitz
475ccefd97 Core: Move focusable into its own module
Ref #9647
2015-08-08 00:29:36 -04:00
Alexander Schmitz
f0260fd91b Core: Move data selector from core into its own module
Ref #9647
2015-08-08 00:29:36 -04:00
Alexander Schmitz
803eaf29f7 Core: Add $.fn.labels, $.fn.form, and $.ui.escapeSelector methods
$.fn.labels and $.fn.form mimic the native labels and form properties
$.ui.escapeSelector is for escaping attributes and urls for use as selectors

Closes gh-1546
2015-05-05 21:43:57 -04:00
Scott González
6231b161b9 Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.
2015-04-17 12:13:38 -04:00
Scott González
9fb04e42a2 Core: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:24:45 -04:00
Scott González
500f6b4992 Tests: Switch to the new qunit-composite module
This module was created from our existing implementation.

Closes gh-1532
2015-04-07 09:03:36 -04:00
Scott González
899d90709a Tests: Handle jQuery git returning null for empty attributes
jQuery now returns `null` for empty attributes instead of `undefined`.

Closes gh-1516
2015-03-25 15:55:53 -04:00
Jörn Zaefferer
9d0f44fd7b All: Drop support for jQuery 1.6.x
Affects core, effects, position and widget. Only position has unit tests
that fail with jQuery 1.6 without the workaround.

Drops the 1.6.x copies jQuery of jQuery and removes them from the select
in the testsuites.

Fixes #10723
Closes gh-1422
2015-01-13 15:05:54 +01:00
Scott González
faf87d9924 Core: Remove .zIndex()
Fixes #9156
2014-10-20 19:29:35 -04:00
Scott González
89ed68fb05 Core: Removed .focus( delay )
Fixes #9649
2014-10-20 19:26:01 -04:00
Mike Sherov
d8a79a5e0e Effects tests: Add clip visual test
Closes gh-1338
2014-09-03 14:46:52 -04:00
Mike Sherov
aa425ab95d Build: Pull in jquery.simulate.js from Bower
Fixes #10563
2014-08-22 17:01:50 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
Scott González
06fe70b10a Core: Ensure forms in tests have some actual content
Empty forms have no height, so they're considered hidden in jquery-git as of
jquery/jquery@10399ddcf8
2014-07-30 10:16:29 -04:00
Scott González
9895cb58b4 Core: Clean up selector tests 2014-07-30 09:45:00 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
df6110c0d4 Core: Deprecate .focus( n ), replace in dialog with explicit timeouts
Fixes #9646
2014-02-21 19:57:34 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Scott González
afeaf565bb Core tests: Explicitly focus the body during delayed .focus() test to avoid an issue in IE 8. 2013-07-09 14:13:24 -04:00
Bruno M. Custódio
0d5eaab9bb Updating jQuery to 1.10.2.
Adding jQuery 1.10.0, 1.10.1, 1.10.2, 2.0.0, 2.0.1, 2.0.2 and 2.0.3 to the
tests directory.
2013-07-05 08:42:37 -04:00
Scott González
932caaf2dd Core: Deprecated .zIndex(). Fixes #9061 - Core: Deprecate .zIndex(). 2013-03-15 07:01:24 -04:00
Bruno M. Custódio
b440979ba6 Updating 'jQuery' to 1.9.1. 2013-02-05 13:47:59 +00:00
Kris Borchers
34409e7ddd Updating to jQuery 1.9.0 2013-01-17 00:28:41 -06:00
Scott González
48a790a327 Core: Resume focus test based on the event, not the callback. 2013-01-08 07:54:11 -05:00
Mike Sherov
0d4022bceb Tests: Convert single quotes to double quotes. 2012-12-26 08:08:48 -05:00
Scott González
2841541362 Core tests: Handle async focus in IE. 2012-12-10 10:34:44 -05:00
Scott González
fb6119e182 Upgrade jQuery to 1.8.3. 2012-11-14 15:22:01 -05:00
Scott González
86a958d3aa Core: Update :focsable and :tabbable to handle parents with no height/width, but visible overflow. Fixes #8643 - :focusable pseudo-selector does not find elements if parent has 0x0 dimension. 2012-10-23 15:12:54 -04:00
Scott González
a638acb583 Upgrade jQuery to 1.8.2. 2012-09-20 21:41:47 -04:00
Scott González
1e6b2b2298 Upgrade jQuery to 1.8.0. 2012-08-13 09:19:09 -04:00
Scott González
5ae668fdb6 Tests: Enable QUnit.config.requireExpects. 2012-06-27 11:32:48 -04:00
Scott González
abbf6a79a9 Tests: Update support comments. 2012-06-25 14:51:51 -04:00
Scott González
0e550f16bb Core tests: Updated support comments. 2012-06-25 14:46:45 -04:00
Jörn Zaefferer
8f6c656c28 Core: Make uniqueId test pass in IE6/7 with jQuery 1.6, where undefined id is returned as empty string 2012-06-19 17:08:38 +02:00