Commit Graph

26 Commits

Author SHA1 Message Date
Paul Capron
f5d38e2e05
Focusable: Fix handling of visibility: collapse
"collapse" is similar to "hidden", with a slight difference in the case
of tr/tbody/td/colgroup elements.
See https://www.w3.org/TR/CSS22/visufx.html#visibility
See https://www.w3.org/TR/CSS22/tables.html#dynamic-effects
See https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Table_example

"visibility: collapse" elements are always not focusable, though.

Commit d3025968f3 introduced a regression by testing with `!== "hidden"`
instead of `=== "visible"`.

Closes gh-1843
2020-10-14 23:53:11 +02:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Scott González
50d910b848 Focusable: Detect disabled fieldsets
Fixes #14970
Closes gh-1705
2016-05-25 15:32:18 -04:00
Amanpreet Singh
20b6e976fb Core: Shift to no globals 2016-04-14 00:06:12 +05:30
Scott González
d3025968f3 Focusable: Fix handling of visibility: inherit
Ref #14596
Ref gh-1583
Closes gh-1605
2015-09-29 12:48:11 -04:00
Weston Ruter
0db243a736 Core: Remove ancestor visibility requirement from :focusable selector
* Check computed visibility in addition to :visible
* Add tests for nested visibility override

Fixes #14596
Closes gh-1583
2015-09-24 08:13:59 -04:00
Alexander Schmitz
fe5534b347 Core: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:24 -04:00
Alexander Schmitz
6064a5e048 Core: Move tabbable into its own module
Ref #9647
2015-08-08 00:29:37 -04:00
Alexander Schmitz
475ccefd97 Core: Move focusable into its own module
Ref #9647
2015-08-08 00:29:36 -04:00
Alexander Schmitz
f0260fd91b Core: Move data selector from core into its own module
Ref #9647
2015-08-08 00:29:36 -04:00
Alexander Schmitz
803eaf29f7 Core: Add $.fn.labels, $.fn.form, and $.ui.escapeSelector methods
$.fn.labels and $.fn.form mimic the native labels and form properties
$.ui.escapeSelector is for escaping attributes and urls for use as selectors

Closes gh-1546
2015-05-05 21:43:57 -04:00
Scott González
9fb04e42a2 Core: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:24:45 -04:00
Scott González
9895cb58b4 Core: Clean up selector tests 2014-07-30 09:45:00 -04:00
Mike Sherov
0d4022bceb Tests: Convert single quotes to double quotes. 2012-12-26 08:08:48 -05:00
Scott González
86a958d3aa Core: Update :focsable and :tabbable to handle parents with no height/width, but visible overflow. Fixes #8643 - :focusable pseudo-selector does not find elements if parent has 0x0 dimension. 2012-10-23 15:12:54 -04:00
Scott González
5ae668fdb6 Tests: Enable QUnit.config.requireExpects. 2012-06-27 11:32:48 -04:00
Jörn Zaefferer
d40993dcf6 Fix various issues in our html files, third batch 2012-04-23 18:55:11 +02:00
Scott González
1729e3a32e Core: Added tests for :focusable and :tabbable form elements. 2011-08-12 09:37:48 -04:00
Scott González
6fb68568be Tests: Cleanup. 2011-08-03 21:43:52 -04:00
Scott González
da84672db8 .attr() -> .prop() 2011-06-08 17:02:57 -04:00
Scott González
fe13fbadd4 Core: Better support for areas in :focusable and :tabbable selectors. Partial fix for #4488 - :focusable and :tabbable are broken with jQuery 1.3.2. 2010-07-22 10:33:42 -04:00
Scott González
3f070bdc62 Core: Fixed :focusable and :tabbable selectors for to work with :hidden and :visibile selectors in jQuery 1.3.2+. Still need to handle areas properly. Partial fix for #4488 - :focusable and :tabbable are broken with jQuery 1.3.2. 2010-07-21 22:10:16 -04:00
Jörn Zaefferer
09fd7fc1fa core tests: a few comments about failing tests, a few fixes for existing tests, mostly messages; primary remaining issue is that both $("area").is(":visible") and $("area").is(":hidden") return true, which is most likely a bug in jQuery core 2009-09-15 08:35:46 +00:00
Jörn Zaefferer
9d075e1077 rename modules for testswarm compability 2009-09-01 08:16:10 +00:00
Scott González
621392624b Core tests: Tests for :data selector. 2009-01-22 01:45:42 +00:00
Scott González
f80d9eb465 Core: Partial fix for #3559: Proper implementation for :focusable and :tabbable selectors. 2009-01-21 03:25:02 +00:00