Commit Graph

27 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
0fe05e5223
Theme: Revert three theme commits that are causing styling issues (#1983)
* Revert "Theme: Removes css for ui-state-checked its not used any more"

This reverts commit 1b0e947f46.

* Revert "Theme: Replace missing definition for default icons"

This reverts commit dde9b83df6.

* Revert "Theme: Switch icon background to use bgColorContent"

This reverts commit 265b8f5e53.

This reverts three commits:

* Theme: Removes css for ui-state-checked its not used any more 1b0e947f46 (https://github.com/jquery/jquery-ui/pull/1753)
* Theme: Replace missing definition for default icons dde9b83df6
* Theme: Switch icon background to use bgColorContent 265b8f5e53

which caused styling issues when compared to UI 1.12.1.

This unfixes a few issues:

* https://github.com/jquery/download.jqueryui.com/issues/335
* https://bugs.jqueryui.com/ticket/15059
* https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016

However, old & known issues are better than new & unknown ones, especially with our current very limited resources.

Closes gh-1983
2021-09-26 00:03:44 +02:00
Michał Gołębiowski-Owczarek
87656cdf57
Theme: Fix blank icons having a background
A fix from 43254468de introduced a rule setting
`background-image` of a blank icon to none. However, the selector used for that
rule had lower specificity than another one: `.ui-button .ui-icon` which caused
dashes being shown over the icons.

We needed to increase the specificity of the `.ui-icon-blank` rule past the
above selector and past `.ui-button:hover .ui-icon`. We're doing it by repeating
the class name three times.

Closes gh-1987
2021-09-25 21:20:06 +02:00
Michał Gołębiowski-Owczarek
b15e45a451
Core: Resolve csslint issues with the IE filter property
IE filter property violates standard CSS parsing rules. Because of that, IE 8
added `-ms-filter` which accepts the same values but quoted:
https://web.archive.org/web/20101112132308/http://blogs.msdn.com/b/ie/archive/2008/09/08/microsoft-css-vendor-extensions.aspx
Both `filter` & `-ms-filter` serialize to the same `filter` property in
`currentStyle`.

This commit switches to that new property to resolve csslint issues.

Closes gh-1939
2020-10-15 14:33:51 +02:00
Felix Nagel
43254468de Theme: Don't load the image sprite for 'ui-icon-blank' 2020-08-11 23:36:29 +02:00
Alexander Schmitz
1b0e947f46 Theme: Removes css for ui-state-checked its not used any more
Also updates checkbox icon border color to go with background color
Ref jquery/download.jqueryui.com#335
Fixes #15059
Closes gh-1753
2016-10-04 11:29:17 -04:00
Alexander Schmitz
dde9b83df6 Theme: Replace missing definition for default icons
Fixes jquery/download.jqueryui.com#335
2016-10-04 11:29:17 -04:00
Alexander Schmitz
265b8f5e53 Theme: Switch icon background to use bgColorContent
It's more semanticly correct then fcActive and looks the same or better
on most themes

Fixes jquery/download.jqueryui.com#335
2016-10-04 11:29:17 -04:00
Alexander Schmitz
391d45ea6c Theme: Fix icon default color when not within a button
Fixes jquery/jqueryui.com#159
Closes gh-1745
2016-09-14 07:56:53 -04:00
Alexander Schmitz
57537d09a4 Checkboxradio: Adjust rule order to avoid specificty issues with other icons
Fixes #15003
Closes gh-1725
2016-07-27 10:16:04 -04:00
Alexander Schmitz
abc2a755f9 Checkboxradio: Use new ui-state-checked class in checkboxradio
Using `ui-state-highlight` caused a conflict with dialog

Fixes #14955
Closes gh-1712
Closes gh-1704
2016-06-06 11:34:52 -04:00
Scott González
712e9ad744 Theme: Fix position of some icons
Closes gh-1636
2015-10-29 11:27:15 -04:00
Jörn Zaefferer
bb56dd59e8 Theme: Fix ThemeRoller variable for ui-icon-background, again 2015-10-25 17:34:34 -04:00
Jörn Zaefferer
f54d489df3 Theme: Fix ThemeRoller variable for ui-icon-background 2015-10-25 17:30:34 -04:00
Alexander Schmitz
19959ac674 Theme: address review comment for visual focus 2015-10-08 14:02:58 -04:00
Alexander Schmitz
6e2bbcaa5e Theme: Add visual focus outline for checkbox and radio buttons
This adds a focus outline matching that roughly from chrome osx
2015-10-07 10:57:59 -04:00
Alexander Schmitz
25d0c85718 Checkboxradio: Initial commit of new widget 2015-10-07 10:57:59 -04:00
Alexander Schmitz
02033262ee Button: Initial commit of button re-factor
Move to using element stats rather then js class states remove
ui-button-text spans.
Removed button set
2015-10-07 10:57:59 -04:00
Alexander Schmitz
559dc05462 Theme: If make outer border consistent among widgets
Make sure all widgets use the default border color

Ref #13997
Ref #1586
2015-08-14 10:40:02 -04:00
Jörn Zaefferer
d58051ba1a Theme: Restore placeholders for overlay background image
These are still needed.

Ref gh-1436
Ref jquery/download.jqueryui.com#248
2015-02-12 10:36:31 +01:00
Jasper de Groot
79c4fa1e7a Theme: Improve default theme styling
Changes tooltip to use the ui-widget-shadow class, which now applies the
box-shadow style. .ui-widget-shadow was created when box-shadow wasn't
available. By now, there's no point in faking a custom shadow anymore.
This removes the only non-structural CSS from a widget-specific file.

Updates demos to use the same font-family, removes unused images.

Will be available as the new default theme on ThemeRoller called "Base",
while "UI Smoothness" and "UI Lightness" will still be available in the
gallery.

Fixes #10617
Fixes #10880
Closes gh-1436
Ref jquery/download.jqueryui.com#248
2015-01-27 13:23:53 +01:00
Anne-Gaelle Colom
c89cb74893 Build: Remove dates from copyright notice
Closes gh-1403
2015-01-02 09:02:12 -05:00
Lisa Seacat DeLuca
2500bb39c2 Theme: Carat should be named caret
Fixes #10683
Closes gh-1382
2014-11-03 13:40:58 -05:00
TJ VanToll
3002d460de Theme: Change default widget font-size to 1em
Fixes #10131
Closes gh-1374
2014-10-24 07:23:31 -07:00
Scott González
1b4f61509a Theme: Add support comments for filter properties 2014-07-09 09:05:06 -04:00
TJ VanToll
83b3d67175 All: Updating copyright year to 2014 2014-01-28 22:25:02 -05:00
Scott González
fa23894dff All: Quote CSS url() values
Closes gh-1172
2014-01-24 16:53:57 -05:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00