Corey Frang
5d4d40f7be
Dialog: Update to 96e5c24
- keyup apparently doesn't work like I thought it would everywhere, switching back to keydown.
...
(cherry picked from commit dfe75e1b55
)
2011-08-20 18:06:16 -05:00
Corey Frang
8f16cc304a
Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog
...
(cherry picked from commit 96e5c241e1
)
2011-08-19 06:07:47 -05:00
Andreas Pelme
abf97f7301
Backport of f9996682b5
for 1-8-stable.
...
Original commit message from f9996682b5
:
Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.
2011-08-02 18:40:25 +02:00
Scott González
b796cc57bd
jQuery 1.6 support.
2011-07-29 14:57:06 -04:00
Jörn Zaefferer
fab17293e4
Dialog: Changed IE6 overlay width adjustment to apply to all IE versions. Fixed #3623 - Opening a Modal Dialog shows a horizontal scroll bar
...
(cherry picked from commit 29b36bb409
)
2011-05-18 17:12:01 +02:00
Scott González
e388153049
Dialog: Don't use .attr( props, true ) for creating buttons since that API doesn't exist in jQueery 1.3.2. Fixes #7226 - Dialog buttons badly handled with JQuery 1.3.2.
2011-04-07 14:06:36 -04:00
Scott González
83fca58d1c
Updated copyright year.
2011-01-17 09:36:00 -05:00
Scott González
22671ad4f8
Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError.
...
This should be reverted in jQuery UI 1.9.
2010-12-08 12:36:19 -05:00
Scott González
b9e34f726a
Dialog: Don't hide the dialog in _size if it started visible. Fixes #6717 - Dialog: Adding a button makes the dialog disappear in IE6.
2010-12-03 08:31:06 -05:00
jamiejag
8bb412dd4a
Dialog: Ensure dialogs have a z-index when calculating the max z-index. Fixex #5955 - Dialog: Closing UI dialog when z-index is not defined in any .ui-dialog class, causes NaN to be used as Z-index, throwing an error. Fixes #4652 - Dialog: Event loss in subsequent dialog calls (FF3).
2010-11-19 09:02:01 -05:00
Scott González
c2139fc2e6
Dialog: Added some missing semicolons.
2010-11-12 12:57:34 -05:00
Jay Merrifield
dfb3544297
Dialog: Make sure the overlay instance still exists before trying to remove it. Fixes #6645 - Dialog: Missing element not found check in overlay code.
2010-11-12 08:16:41 -05:00
Scott González
302728bd87
Dialog: Fixed logic for mimicking minHeight. Fixes #6150 - Dialog height:auto does not work in IE6.
2010-10-05 16:20:43 -04:00
John Firebaugh
e66cdfcf59
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:18:46 -04:00
Scott González
c090802cc1
Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."
...
This reverts commit 67b1db14c9
.
Reverting so I can commit again with the proper author.
2010-10-04 09:18:21 -04:00
Scott González
67b1db14c9
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:15:40 -04:00
Scott González
d7670b9407
Dialog: Don't pass props to jQuery when creating buttons.
...
Thanks jitter.
2010-10-01 11:19:24 -04:00
Scott González
cd7f10d480
Dialog: Set the type on buttons. Fixes #6128 - Dialog: Buttons are not type="button".
2010-09-30 10:17:52 -07:00
Scott González
e8e3168a39
Dialog: Batch size-related option settings.
2010-09-27 15:15:20 -04:00
Scott González
98a98a05d1
Dialog: Don't call draggable.destroy if we're not currently draggable. Fixes #6069 - DIALOG windows 1.8.5 draggapble problem.
2010-09-20 09:16:29 -04:00
Scott González
52e543a637
Dialog: If the browser doesn't support minHeight, use height to set the minHeight. Fixes #6027 - Dialog: minHeight isn't properly handled on init in IE6.
2010-09-07 09:33:09 -04:00
Scott González
de02aa34a8
Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event.
2010-09-02 08:35:40 -04:00
Scott González
95a34593f9
Dialog: Added additional syntax for creating buttons. Fixes #4344 - Dialog: Enhanced Button Option.
2010-08-31 10:17:53 -04:00
Scott González
79ee6f0d7b
Dialog: When using the title attribute, update the title option. Fixes #5877 - Dialog: when using the title attribute, the title option should be updated.
2010-08-27 18:02:11 -04:00
Scott González
af9864dcc4
Dialog: Don't return true when we don't want to cancel events. Fixes #3523 - Dialog: onclick return value ignored.
2010-08-27 16:49:07 -04:00
Ziling Zhao
c5770c0e84
Dialog: modified so that minWidth is respected. Fixes #5531 - dialog width should be at least minWidth on creation.
2010-07-30 15:14:48 -04:00
Scott González
58ae7ce2fd
Revert "Use pushStack in widget method. Fixes #5732 - make the widget method maintain the stack"
...
This reverts commit ea58cd5ac0
.
2010-07-30 12:38:18 -04:00
jzaefferer
ea58cd5ac0
Use pushStack in widget method. Fixes #5732 - make the widget method maintain the stack
2010-07-30 14:26:58 +02:00
Scott González
61e0aeac7e
Dialog: Wrap buttons in a div so we can float the div instead of the individual buttons. Fixes #4529 - dialog buttons are accessed in wrong order using tab.
2010-07-29 20:56:28 -04:00
Scott González
70c4857cc5
Revert "Dialog: Don't set specific dimensions on the overlay - let it expand based on 100% dimensions. Fixes #3623 - Opening a Modal Dialog shows a horizontal scroll bar."
...
This reverts commit b548d34e14
.
2010-07-21 08:01:06 -04:00
Scott González
b548d34e14
Dialog: Don't set specific dimensions on the overlay - let it expand based on 100% dimensions. Fixes #3623 - Opening a Modal Dialog shows a horizontal scroll bar.
2010-07-20 22:05:05 -04:00
Scott González
64d90b4a71
Dialog: Adjusted logic for finding the first tabbable element. Fixes #5767 - On open, the first tabbable element inside the dialog was never being focused in favor of the dialog container.
2010-07-16 16:57:46 -04:00
Scott González
4ad7154bee
Dialog: Fixed whitespace.
2010-07-16 08:55:03 -04:00
Ben Hollis
6de9a5368c
Dialog: allow setting position with ui.position arguments. Fixes #5459 - Dialog: expose .position() API
2010-07-14 16:29:28 -04:00
Scott González
8a5d4ca321
All: Added http://jqueryui.com/about to header comments.
2010-07-14 15:45:45 -04:00
Scott González
2c7a9e9ff3
Dialog: Verify that we get a string back from .attr( "title" ) before using the return value. Fixes #5742 - Form field with name="title"
moved to title area.
2010-07-14 15:28:01 -04:00
Scott González
21aad10e6a
All: Define a local undefined variable inside the main closure.
2010-07-13 09:57:58 -04:00
Jon Palmer
f560862666
Dialog: add resize call when changing button options for correct height adjustment. Fixes remaining issues in #4846 - Setting Dialog height shorter after init hides button pane
2010-07-11 06:42:46 +08:00
Scott González
536ae6189b
Updated copyright headers to make it clear that you can choose between MIT and GPLv2. Also added a link to http://jquery.org/license .
2010-07-09 09:01:04 -04:00
Scott González
b297b3fa6a
Fixed size calculations for dialogs.
...
Fixes #5392 - Dialog explicit height doesn't match given value from set option.
2010-03-25 21:58:08 -04:00
Scott González
596d1ef581
Dialog: Use .height(0) instead of .hide(0) when determining the size of the non-content area of a dialog.
...
Partial fix for #5392 - Dialog explicit height doesn't match given value from set option.
2010-03-22 07:53:34 -04:00
Richard Worth
aa6fb14854
Dialog: quiet JSLint
2010-03-12 01:10:57 +00:00
Richard Worth
7898303437
dialog: corrected typo in ui.position property for drag events. Updated unit tests tracking fix of #5291
2010-03-11 20:48:21 +00:00
Jörn Zaefferer
d3a8c96428
Filter properties to forward to dialog events on resize and drag etc. - fix for #5291
2010-03-05 17:56:34 +00:00
Jörn Zaefferer
eaeb580d82
Pass through resizable and draggable ui objects in dialog - partial fix for #5291
2010-03-05 17:47:06 +00:00
Scott González
eb93c743de
Dialog: Fixed modal overlay instance tracking.
...
Fixes #5228 - $.inArray's parameter.
Fixes #5263 - Dialog Close Then Destroy Destroys Overlay Twice, Causes Exceptions Later.
2010-03-03 02:11:37 +00:00
Scott González
83b16f528f
Dialog: Use .height() to calculate height of dialog before drag.
...
Fixes #5221 - Buttons disappear after dragging dialog.
2010-02-24 17:16:02 +00:00
Brant Burnett
350853179f
Dialog: ESC key event was not being canceled after it was handled ( Fixed #4922 window.location.reload() doesn't work in dialog's close callback when it's triggered by ESC in Firefox)
2010-02-22 18:39:12 +00:00
Brant Burnett
e2202847c6
Dialog: Changed height measurement to hide content because IE quirks mode ignores height: 0 ( Fixed #4350 No Scrollbars in IE in Quirksmode)
2010-02-22 17:37:08 +00:00
Brant Burnett
53ab4fb5de
Dialog: Overlays are now cached for reuse with subsequent dialogs ( Fixed #5185 : .ui-widget-overlay CSS selector causes consistent large memory leak in IE)
2010-02-17 16:22:19 +00:00