Commit Graph

21 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
0c860b0d92
All: Remove usage of jQuery positional selectors
jQuery positional selectors () have been deprecated in
[jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/)
and they'll be removed in jQuery 4.0.0. This PR removes their usage.

Most of the changes were possible without changing public API. However,
dropping `:even` usage required a change to the
[`header` option](https://api.jqueryui.com/accordion/#option-header)
of the accordion widget. I made it an optional function; this will need
to be documented.

The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was
no usage of the :odd selector in the code but the `.odd()` method is also
polyfilled for completeness.

Closes gh-1904
2020-01-22 16:44:34 +01:00
Michał Gołębiowski-Owczarek
98b539171b All: Migrate away from deprecated/removed Core APIs
Summary of the changes:

* Build: Add jQuery 3.2.0-3.4.1 to versions UI can be tested against
* Build: Load jQuery & Migrate via HTTPS
* Build: Add package-lock.json to .gitignore
* Build: Update jQuery Migrate from 3.0.0 to 3.1.0
* Build: Allow to run tests against jQuery 3.x-git
* Build: Fix formatting according to JSCS rules
* Build: Disable JSCS for the inlined jQuery Color
* All: Switch from $.isArray to Array.isArray (jQuery.isArray will be
  removed in jQuery 4.0)
* All: Switch from `$.isFunction( x )` to `typeof x === "function"`
  (jQuery.isFunction will be removed in jQuery 4.0)
* All: Inline jQuery.isWindow as it'll be removed in jQuery 4.0
* Effects: Fix a timing issue in a variable declaration. Previously,
  a jQuery object was created, chained & assigned to a variable that
  was then accessed in a callback used inside of this chained
  definition. Due to a timing difference in when the callback fired for
  the first time in latest jQuery master, it was being called before
  the variable was defined.
* Tests: Make dialog & draggable unit tests less strict (newest jQuery
  returns fractional results in some cases, making comparisons fail when
  there's a tiny difference)
* All: Migrate from $.trim to bare String.prototype.trim (jQuery.trim
  will be deprecated in jQuery 3.5)

Closes gh-1901
2019-12-08 22:23:08 +01:00
Scott González
74f8a0ac95 Tests: Load jquery-1-7 before other modules 2017-05-31 14:09:05 -04:00
Scott González
ae31f2b3b4 Tests: Load jquery-1-7 module for jQuery 2.x as well 2017-05-15 18:24:19 -04:00
Scott González
39bbe70b54 Tests: Load the jquery-1-7 module for all 1.x versions 2017-05-10 09:02:53 -04:00
Scott González
162377fba2 Build: Add missing semicolon 2017-02-06 10:20:50 -05:00
Eirik Sletteberg
4fa0267edc Qunit: Add bootstrap config for running tests with jQuery Migrate
Closes gh-1774
2017-02-06 08:23:18 -05:00
Michał Gołębiowski
468f1e3abe Build: Add jQuery 1.12/2.2 to the test configuration
Ref gh-1706
2016-05-25 16:42:06 -04:00
Michał Gołębiowski
15586ea752 Build: Use jquery-git in place of jquery-compat-git
jQuery Compat is not going to get released after all; jQuery UI should be tested
against jquery-git instead of jquery-compat-git.

Closes gh-1646
2015-11-14 06:12:55 -05:00
Scott González
9bb9a8bac0 Tests: Load ui/jquery-1-7.js when testing against jQuery 1.7.x 2015-08-31 15:33:02 -04:00
Alexander Schmitz
c13ddf22ed Tests: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:24 -04:00
Scott González
ae25cdb688 Build: Upgrade to jQuery 1.11.3 2015-05-14 08:25:16 -04:00
Scott González
e1751383f1 Tests: Use new jquery-compat-git and jquery-git files 2015-05-14 07:44:13 -04:00
Alexander Schmitz
6a03b0f2ba Build: Update to qunit-assert-classes to V 1.0.2
Closes gh-1547
2015-05-01 07:11:35 -04:00
Scott González
1d193c24dc Tests: Fix loading in TestSwarm 2015-04-17 13:45:13 -04:00
Scott González
6231b161b9 Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.
2015-04-17 12:13:38 -04:00
Scott González
4bf80d209a Tests: Use the qunit-assert-close module
Moved QUnit assertion dependencies from `lib/bootstrap` to `lib/qunit`.

Corrected bad draggable assertions.

Ref gh-1528
2015-04-09 09:28:25 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00
Scott González
0714f55ad4 Tests: Support $.uiBackCompat = false via data-no-back-compat
Ref #10119
Ref gh-1528
2015-04-09 09:26:27 -04:00
Scott González
8bda52c8d1 Spinner: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:26:27 -04:00
Scott González
7c896ddb85 Tests: Change test infrastructure to use AMD and reduce boilerplate
Ref #10119
Ref gh-1528

* Adds RequireJS and relies on AMD for loading dependencies.
* Updates to grunt-contrib-qunit 0.6.0.
* Convert `domEqual()` to a proper QUnit assertion.
* Introduces two bootstrap files (JS and CSS) which use `data-` attributes to
reduce the amount of boilerplate needed in each test
2015-04-09 09:21:06 -04:00