Commit Graph

54 Commits

Author SHA1 Message Date
Dave Stein
9f018eb30a Draggable + Sortable: Code review changes 2012-12-12 14:23:17 -05:00
Dave Stein
110b3c7d2d Sortable: Initial commit with 99% code from draggable and in dire need of review and optimization 2012-11-13 20:12:28 -05:00
Mike Sherov
68ad80c292 Dev: Standardize sortable test suite. Fixed #8755 - Dev: Get sortable test suite to pass 2012-11-01 20:54:52 -04:00
John Chen
bae06d2b1e Sortable: Calculating item distance and direction using a more robust algorithm to better support sorting among nested sortables. Fixes #8572 - Wrong placeholder positions. Fixes #8573 - Can't drag an item out of an inner sortable. Fixes #8574 - Hard to put an item between two inner sortables.
Use the item which has the least distance between the mouse
pointer and one of its borders to rearrange, with direction being
determined by the nearest border.
Also we use this algorithm to rearrange even when currentContainer
is not changed to override the defective rearrangment in
_mouseDrag
2012-10-10 14:56:03 -04:00
John Chen
77a4aaf47a Sortable: Fix a bug of removing an item while iterating an array. Fixes #8571 - Out of range problem in when dragging a nested sortable. 2012-10-10 14:39:38 -04:00
Scott González
a3f1a34d3b Remove use of $.browser; add $.ui.ie and $.ui.ie6 temporarily. 2012-10-10 11:45:48 -04:00
Scott González
149567e476 Updated docs URLS. 2012-09-26 18:06:20 -05:00
Martin Hoch
b9ef00f0c7 Sortable: Fixed container change detection. Fixes #5159 - Remove and receive events on nested sortables. 2012-08-22 22:04:40 -04:00
Martin Hoch
2b899cc843 Sortable: Fixed jerkiness with nested-sortables. Fixes #4857 - Nested lists don't work properly with sortable. 2012-08-22 22:02:39 -04:00
Scott González
485ca7192a Simplify licensing. 2012-08-09 15:09:50 -04:00
Baoju Yuan
dcea4f043a Sortable: Reset fromOutside property when canceling helper removal. Fixes #8430 - draggable with sortable makes sortable event receive triggered wrong. 2012-07-16 10:26:02 -04:00
Scott González
a4534bb993 Update copyright to jQuery Foundation. 2012-07-04 09:08:08 -04:00
Scott González
eda0526b73 Sortable: Remove workaround for Safari 3. 2012-06-14 18:46:38 -04:00
Courthead
c42bdcecf8 Sortable: calculating item positions on the fly and setting the direction variable when inserting an item into a different sortable. Fixed #8268 - Items may not be inserted into the correct position when dragged between connected sortables 2012-05-22 08:00:20 -04:00
Scott González
a15d40eb5f Sortable: Remove uses of self var; use that var. 2012-05-09 20:20:15 -04:00
martinf55
32f356bbfa Sortable: Moved change of helper position css. Fixed #5321 – Helper in a bottom-positioned Sortable is positioned wrong on drag start. 2012-05-07 09:04:11 -04:00
Jason Moon
b8b0c52830 Sortable: update placeholder when axis is x or y. Fixed #8274 - placeholder doesn't move when dragging outside of container element 2012-04-30 13:04:18 -04:00
Scott González
21df5c27e3 Revert "Sortable: Always set placeholder size when necessary. Fixes #8262 - jQuery UI 1.8.19 don't respect forcePlaceholderSize."
This reverts commit 4f19289c10.
2012-04-30 10:39:06 -04:00
Scott González
b38dd26da0 Revert "Sortable: modified the contents of placeholder to a single " ". Fixed #8135 - sortable: Horizontal sortable shifts causes elements to shift down."
This reverts commit b6e1f25ab8.
2012-04-30 10:38:51 -04:00
Bertjh
4f19289c10 Sortable: Always set placeholder size when necessary. Fixes #8262 - jQuery UI 1.8.19 don't respect forcePlaceholderSize. 2012-04-19 09:05:37 -04:00
Scott González
d0cac09027 Sortable: Whitespace. 2012-04-19 09:03:22 -04:00
Jo Liss
37dcc3e21d Protect all copyright notices against minification
For instance, this is useful for the jquery-ui-rails gem, which does not
use jQuery UI's own minification, but relies on Rails to minify the
files where necessary. Rails in turn uses UglifyJS for JS and YUI for
CSS, both of which respect the /*! ... */ convention.
2012-04-02 15:21:06 +02:00
Scott González
932fe888c0 Updated copyright year. 2012-03-08 10:53:08 -05:00
Bertjh
b6e1f25ab8 Sortable: modified the contents of placeholder to a single " ". Fixed #8135 - sortable: Horizontal sortable shifts causes elements to shift down. 2012-02-24 08:38:18 -05:00
Scott González
4259978d39 Sortable: Fixed destroy to remove instance from element. Fixes #8094 - .sortable() after destroy does not work. 2012-02-02 11:38:51 -05:00
SpoonNZ
ba6916f22a Sortable: Added a variable to track if initialization is complete. Fixes #4759 - a major optimization is possible in sortable(). 2012-01-20 11:01:32 -05:00
Richard D. Worth
228b1b191b Sortable: replaced hard-coded sortable with this.widgetName, and removed lines from destroy that are handled by super. Fixes #7741 - ui.sortable is not working when it is extended 2011-09-27 07:57:06 -04:00
Scott González
6a5b21fda2 All: Moved version numbers into prototypes. Fixed #7436 - Widget: Store version numbers on instances. 2011-05-28 15:39:55 -04:00
kborchers
8e8a7b015f Sortable: Changed to check the parent's length so that the dom position of the removed element is not updated. Fixed #4088 - Unable to remove() ui.draggable (sortable item) immediately after the drop callback. 2011-05-16 16:25:03 -05:00
whittet
2bf061ea6f Bug fix for another use case, see comment by whittet here: http://bugs.jqueryui.com/ticket/6702 2011-04-27 07:21:29 -07:00
Richard Worth
54016b8469 Sortable: Reverted 56b0da59d7 as #4551 is invalid. 2011-04-07 09:08:48 -04:00
michaelmwu
f1d939bc58 Sortable: Changed floating calculation to determine also whether items are being displayed horizontally. Helps fix odd sorting behavior for horizontal lists. Fixed #6702 - horizontal sortable not working (and solution) 2011-03-04 22:17:30 -08:00
marcos.sousa
f165c93127 Sortable: Make sure we have a placeholder before trying to remove it during a cancel. Fixes #6879 - Sortable: Calling cancel when there is no sort occurring throws an error. 2011-01-19 11:11:49 -05:00
Scott González
cf0c32f335 Sortable: pass a fake event object to _mouseUp on cancel. Fixes #5882 - UI.Sortable .sortable( cancel ) call the this._mouseUp method without param. 2011-01-19 10:45:44 -05:00
Scott González
6e0482a9cb Updated copyright year. 2011-01-17 09:13:18 -05:00
Xavi
956697bfca All: Use .toggleClass() instead of conditionally using .addClass() and .removeClass(). Fixes #6764 - Use toggleClass instead of [ bool ? 'addClass' : 'removeClass' ]. 2010-12-19 16:52:22 -05:00
Scott González
9681b1fd7e All: Replaced all uses of $.ui.contains() with $.contains(). Fixes #5000 - Deprecate $.ui.contains. 2010-12-10 15:13:10 -05:00
Holger Rüprich
9d01ab5645 Sortable: Return an empty URL param for empty sortable lists. Fixed #5794 - sortable("serialize", {key: "foo[]"}) returns an empty string for an empty list 2010-07-17 03:06:04 +08:00
Scott González
8a5d4ca321 All: Added http://jqueryui.com/about to header comments. 2010-07-14 15:45:45 -04:00
Scott González
21aad10e6a All: Define a local undefined variable inside the main closure. 2010-07-13 09:57:58 -04:00
Scott González
536ae6189b Updated copyright headers to make it clear that you can choose between MIT and GPLv2. Also added a link to http://jquery.org/license. 2010-07-09 09:01:04 -04:00
ornicar
a4488aff7c Fix 'this.options is undefined' in sortable by using this instead of self 2010-05-05 19:14:55 +08:00
Richard D. Worth
3291d3951a sortable: don't call the base widget _setOption for disabled to avoid the ui-state-disabled class being added. Fixes #5501 - sortable: disabled should not have the ui-state-disabled class 2010-04-09 14:43:44 -04:00
Scott González
3c31d720ce Sortable: Fixed a bug with over/out events and connected draggables.
Fixes #5346 - over and out events not triggered when draggable connected with single (non-nested) sortable.
2010-03-16 01:15:57 +00:00
Richard Worth
e0faff7e11 reverted r3888 un-fixing #5322 for now as trunk is in release candidate state - only criticals and blockers should be fixed until 1.8 is final 2010-03-11 16:57:10 +00:00
Paul Bakaus
1a487a18b7 sortable: fixed #5322 (helper position weird when axis was used, fixes sortable tabs demo) 2010-03-11 16:35:20 +00:00
Scott González
009378cadc Sortable: Only trigger over event when changing the current container.
Fixes #5111 - 1.8rc1 sortable#over method bugged -- called along with #sort instead of on mouseover.
2010-02-20 02:31:49 +00:00
Scott González
9e02f80176 Fixed event prefix in all plugins that don't use the default prefix.
Fixes #5134 - Events not being triggered for drag and drop.
2010-02-05 03:03:50 +00:00
Richard Worth
074153407d Happy New Year 2010-01-20 14:04:26 +00:00
Scott González
7d96a0d096 Widget factory: Changed _create to _init.
Partial fix for #5064 - Widget: make multiple instantiation more useful.
2010-01-15 18:58:20 +00:00