Jörn Zaefferer
a0310eb091
Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option.
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0
Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported.
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9
Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open
2012-11-26 10:28:24 +01:00
Jörn Zaefferer
999617343f
Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
d8b98ec3bb
Dialog: Tiny code improvements
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
e3dcaf28eb
Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143
.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0bc73b74b6
Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
972f5c192c
Dialog: Button is now a fixed dependency, so remove the check
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0ae6fc1e02
Dialog: Remove useless tmp vars.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
625a111fb9
Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one.
2012-11-26 10:28:23 +01:00
Jörn Zaefferer
4c9caa8169
Dialog: Extract button pane creation into _createButtonPane
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1d6ce644e0
Dialog: Refactor _create, extracting title bar creation in _createTitlebar
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
f0acaac230
Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings).
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7a0353500a
Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable.
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1001504249
Dialog: Remove outdated TODO
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
c8aef203cb
Dialog: Have _makeResizable look at options instead of passing handles.
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
16a79c1b9c
Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs).
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7e964be80c
Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch.
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
fed2972027
Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value.
2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf
Dialog: Use button widget for close button (was already listed as dependency)
2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e
Dialog: Focus tabbable only when dialog lost focus before.
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733
Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change.
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
f7d3a51589
Dialog: Only add the new dialogClass, not the base classes when changing the option.
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
324d54dd32
Dialog: Use $.isEmptyObject() to check if there a button-option properties
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4e03321fd7
Dialog: Trigger focus event when dialog is moved to top.
2012-11-26 10:26:12 +01:00
Jörn Zaefferer
b6cefc797e
Dialog: Remove deprecated disableSelection() usage.
2012-11-26 10:26:11 +01:00
Jörn Zaefferer
4632780435
Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test
2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2062a18db6
Dialog: Inline code review
2012-11-26 10:26:11 +01:00
Jörn Zaefferer
0a25b2c448
Dialog: move to top when opening again, and focus as if opened from scratch.
2012-11-26 10:26:11 +01:00
Jörn Zaefferer
8ee8046c02
Dialog: Keep focus inside modal dialog, by handling focus events on elements outside of it
2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2a887e4321
Dialog: Improve accessibilty - add an aria-describedby attribute on the dialog if there is nothing yet in the dialog content. Partial fix for:
2012-11-26 10:26:11 +01:00
Scott González
f5870712c1
Updated all widgets to use proper data keys when getting plugin instances.
2012-11-09 13:28:13 -05:00
Scott González
a8de99c791
Dialog: Don't use .attr( props, true ).
2012-11-05 09:37:19 -05:00
Corey Frang
a688e7c8d4
Mixed spaces and tabs removed
2012-10-29 13:37:06 -05:00
Scott González
5bd4b11d9b
Dialog: Removed minHeight workaround for IE6.
2012-10-26 14:36:35 -04:00
Scott González
68cab60fa7
Removed bgiframe.
2012-10-26 10:53:17 -04:00
Jörn Zaefferer
d07074dc3c
Dialog: Use _show and _hide consistently. Fixes #4892 - Dialog: zIndex error with animated modal dialog.
2012-10-24 17:03:00 -04:00
Jörn Zaefferer
513b6da641
Dialog: Keep focus inside dialog, even when dialog itself has focus.
2012-10-24 17:03:00 -04:00
David Souther
3a09a4a0de
Dialog: Prevent tabbing off any dialog. Fixes #3768 - Dialog: contain focus within dialog.
2012-10-24 17:03:00 -04:00
Jörn Zaefferer
14691ae6fe
Dialog: Save the active element that opened the dialog and restore focus to that. Fixes #8730 - Dialog: Restore focus to opener.
2012-10-24 17:02:32 -04:00
Jörn Zaefferer
2a2a2c017c
Dialog: Prevent dialog form losing focus (or move it back in IE <= 8).
2012-10-24 16:57:13 -04:00
Nate Eagle
3829a37ca1
Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:
...
Fixes #3534 - Dialog: Modal dialog disables all input elements on page.
Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.
Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.
Fixes #5388 - Dialog: Don't change z-index when already at the top.
Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.
Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.
Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.
Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.
Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).
Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.
Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.
Fixes #8583 - Dialog: Mouse event wrongly stopped.
Fixes #8722 - Dialog: Remove stack option.
Fixes #8729 - Dialog: Remove zIndex option.
2012-10-24 16:56:19 -04:00
Scott González
11effcbd35
Dialog: Don't use deprecated offset option for .position(). Fixes #8675 - Dialog: Position with pixels in array doesn't work with back compat disabled.
2012-10-23 14:50:02 -04:00
Mike Sherov
e1230997aa
Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
...
Squashed commit of the following:
commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 10:34:28 2012 -0400
put back in fake args for signatures that we want to keep
commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 08:10:20 2012 -0400
changes per @scott_gonzalez
commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:54:05 2012 -0400
clean up unused vars in ui directory
commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:37:42 2012 -0400
clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
David Petersen
35dc9307fc
Dialog: Use _hide() to make sure close event gets triggered. Fixes #8684 - jQuery dialog with hide options does not trigger close event.
2012-10-17 20:28:27 -04:00
Dale Kocian
1a69667887
Dialog: Added mousedown event handler on dialog title to focus. Fixed #8063 - Dialog: Escape closes incorrect dialog.
2012-10-16 09:17:21 -04:00
Scott González
a3f1a34d3b
Remove use of $.browser; add $.ui.ie and $.ui.ie6 temporarily.
2012-10-10 11:45:48 -04:00
Richard D. Worth
1e6e4ce4dc
Dialog: add required closing tag </button>. Fixes #8639 - jQuery 1.9.0 dialog on a XHTML page is broken if buttons are defined
2012-10-09 08:41:18 -04:00
Scott González
4ab4684cfc
Dialog: Don't try to place the dialog next to itself on destroy. Fixes #8613 - Destroying a dialog removes the original element from the DOM.
2012-10-01 15:34:44 -04:00
Scott González
149567e476
Updated docs URLS.
2012-09-26 18:06:20 -05:00