Commit Graph

65 Commits

Author SHA1 Message Date
Mike Sherov
c7bec85cfa Draggable: append divs to iframe parent for iframefix
This allows the blocking div to move with the iframe in
most situations, whereas appending to the body wouldn't.

Fixes #9671
2014-08-24 07:19:38 -04:00
Mike Sherov
95546c5d04 Draggable: No cloning in connectToSortable and ensure correct position
Draggables now forcefully recalculate their position when dragged out
of a sortable. Sortables now override draggable position when a
draggable is dragged into it. Lastly, no longer remove sortable helper
when dragging a draggable out, which allows us to not use a clone.

Fixes #7734
Fixes #8809
Closes gh-1322
2014-08-23 15:08:54 -04:00
Dave Stein
49c3fb7403 Draggable Tests: Ensure scrolling and dragging tests assert correctly 2014-08-22 17:19:09 -04:00
Mike Sherov
451dded230 Draggable: Ensure helper is positioned even if its the element itself
Fixes #9446
2014-08-19 15:15:21 -04:00
Mike Sherov
48ea2aadad Draggable: Ensure overflow:visible containments are correctly measured
Fixes #7016
2014-08-17 14:38:05 -04:00
Mike Sherov
01e26b0f53 Draggable Tests: Clarify position helper test generation 2014-08-14 21:03:18 -04:00
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Mike Sherov
9acb4797fa Draggable Tests: Fix IE8 test when native scroll happens 2014-08-13 22:26:04 -04:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
df2f7555b4 Draggable Tests: Fix inconsistent operator spacing. 2014-08-06 19:43:13 -04:00
Mike Sherov
dc1e63b432 Draggable Tests: fix IE scroll tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must calculate scrollTop on the drag event, before .focus is called.
2014-02-18 12:48:06 -05:00
Mike Sherov
7017805745 Draggable: fix current JSCS violations. 2014-02-18 12:48:06 -05:00
Ben Higgins
0bb807bb42 Draggable: fix changing containment
If containment was set such that relative_container is set by
_setContainment, and then containment changes to e.g. "document",
"window", or an array, relative_container would not be unset, causing
incorrect containment of the draggable.

Add a unittest to check that containment with an array works after
previously being set to "parent".

Fixes #9733
Closes gh-1176
2014-01-20 13:08:12 -05:00
Brian J. Dowling
f4423f508e Tests: Fix draggable_options expected test count to be dynamic
The test count was previously incremented to 8 when normally 6 tests
are run.  After figuring out the dynamic test code, I just made the
expect depend on the same array length

Also re-enabled the test in the Gruntfile since it now passes.
2014-01-16 21:25:28 +00:00
Dave Stein
38c6cf1382 Draggable: Test fix regarding static scrolling
No longer checking scroll positions of static scrolls since the fixture is
in an absolute container.

Closes gh-1145
2013-12-15 09:38:46 -05:00
Mike Sherov
44b2180782 Draggable: normalize lookups for rootNodes when to bust scroll cache. Fixes #9379 - Draggable: position bug in scrollable div
Core: update scrollParent() to support all current supported browsers.
2013-12-03 10:08:12 -05:00
Mike Sherov
1f724adb15 Draggable Tests: don't test auto scroll while testing helpers. 2013-10-31 21:41:45 -04:00
Mike Sherov
a3715a7c91 Draggable Tests: Ensure all combinations of helper / draggable positions / scrollParents / parent positions are tested accurately. 2013-10-29 13:25:57 -04:00
Mike Sherov
dbbf3a9611 Draggable Tests: Ensure Draggable tests are correctly testing offset under scroll conditions. 2013-10-23 12:22:06 -04:00
Mike Sherov
fdc7052fdb Draggable Tests: Test both position and offset of draggable element in all applicable tests. 2013-10-21 11:20:03 -04:00
Mike Sherov
94f8c4d5e9 Draggable: apply axis options to position instead of style. Fixes #7251 - Draggable: constrained axis option returns incorrect position. 2013-10-20 19:46:05 -04:00
Mike Sherov
b8795e15d6 Draggable Tests: Add position asserts to drag tests
They're currently disabled however due to bugs both
in the tests and in the actual widget.
2013-10-20 15:31:47 -04:00
Mike Sherov
c9b0e28d8d Draggable Tests: consolidate drag tests and provide error messages for all assertions. 2013-10-20 09:35:12 -04:00
Mike Sherov
0144b270c8 Draggable Tests: clarify scroll helpers. 2013-10-20 08:37:34 -04:00
Mike Sherov
82edd58743 Draggable Tests: make sure offset tests are actually testing offsets 2013-10-19 18:53:00 -04:00
Mike Sherov
7c939aadf8 Test Suite: Remove Flaky Datepicker test, and correct more old jQuery test cases for old Opera and old Safari. 2013-04-14 12:58:42 -04:00
Mike Sherov
d345a0d7db Draggable: allow draggable to defer destroying itself upon DOM removal until after stop is fired. Fixes #6889 - Draggable: Cursor doesn't revert to pre-dragging state after revert action when original element is removed. 2013-04-12 14:45:48 -04:00
Mike Sherov
3c1a3ca252 Draggable Tests: fix old Safari and old Opera tests with jQuery < 1.8 tests by accounting for a bug in $.contains on disconnected Elements. 2013-04-07 12:10:59 -04:00
Mike Sherov
204a0423be Draggable Tests: Fix IE8 test failures by accounting for the IE8 testswarm IFRAME positioning bug. 2013-03-31 12:19:43 -04:00
Mike Sherov
38f93c4ac1 Draggable Tests: Minor style fixes and removing unnecessary setup and teardown for core tests. 2013-03-26 09:22:35 -04:00
Mike Sherov
dc5254aa07 Draggable: Handle containment set to false after init, and style improvements. Fixes #8962 - Containment doesn't properly update 2013-03-23 16:48:19 -04:00
Mike Sherov
9d8af804ad Draggable: make sure snap elements are in the document before snapping. Fixes #8459 - Draggable: element can snap to an element that was removed during drag. 2013-03-16 14:36:06 -04:00
Zbigniew Motyka
bd126a9c1c Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly 2013-03-16 11:51:51 -04:00
Woody Gilk
82f588e82b Draggable: Fix double offset bug when scrolling. Fixes #6817 - Draggable: auto scroll goes double distance when dragging 2013-03-15 18:52:56 -04:00
Scott González
cdff72efed Draggable: Account for descendants in handle. 2013-03-08 10:08:58 -05:00
TJ VanToll
6358695df1 Draggable: Fix border containment. Fixed #5569 - Draggable: Containment incorrectly calculates padding and border 2013-03-07 21:42:28 -05:00
Mike Sherov
ca0b4b8a6c Draggable Tests: Fix containment tests 2013-03-04 11:39:14 -05:00
Mike Sherov
5a04d237dd Draggable Tests: Fix snap test failures in IE8 2013-03-04 09:58:23 -05:00
Mike Sherov
dd16205a3f Draggable Tests: Style Sweep 2013-03-04 01:32:23 -05:00
Mike Sherov
c278a4461b Draggable Tests: Add test coverage for supported options 2013-03-04 01:05:11 -05:00
TJ VanToll
c32bebd1bd Draggable: Account for z-index set in CSS for the stack option. Fixed #9077 - Draggable: stack option resets the z-index 2013-02-11 23:29:48 -05:00
Mike Sherov
18b8ffd796 Draggable Tests: Cover all cursorAt option formats. 2013-01-01 23:16:12 -05:00
Mike Sherov
1045d3a352 Draggable Tests: Fix IE7 offset failures 2012-12-27 10:39:14 -05:00
Mike Sherov
0d4022bceb Tests: Convert single quotes to double quotes. 2012-12-26 08:08:48 -05:00
Mike Sherov
ecb7b6ec12 Draggable Tests: add back in unreliable offset hack for cursorAt tests 2012-12-22 17:39:36 -05:00
Mike Sherov
46925b8808 Draggable Tests: use jquery.simulate.js to simulate drag events 2012-12-22 16:30:27 -05:00
Mike Sherov
9f76446775 Dev: remove unnecessary simulated drag delegation in test suite 2012-12-08 21:27:37 -05:00
Mike Sherov
3df9ea29e6 Dev: remove globals from tests and moved test helpers to correct location - Fixed #8770 Dev: Remove globals and Standardize Test Suite 2012-11-03 16:17:16 -04:00
Mike Sherov
d771048a56 Dev: Fix test failures in oldIE. Fixed #8748 - Dev: Get draggable test suite to pass 2012-10-31 10:02:01 -04:00