Commit Graph

128 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
9ea690a0d9
Tests: Make some number comparisons less strict
Some of the APIs return fractional values in newer jQueries, making comparisons
sometimes not being 100% accurate. Allow some delta.

This is similar to what was already done in
98b539171b but a few cases affecting IE and/or
Edge Legacy were missed.

Closes gh-1947
2021-03-09 00:11:40 +01:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Michał Gołębiowski-Owczarek
579bedd7d2
Tests: Solve a frequent race condition in tests in Chrome/Safari
Closes gh-1916
2020-05-16 08:28:26 +02:00
Michał Gołębiowski-Owczarek
0c860b0d92
All: Remove usage of jQuery positional selectors
jQuery positional selectors () have been deprecated in
[jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/)
and they'll be removed in jQuery 4.0.0. This PR removes their usage.

Most of the changes were possible without changing public API. However,
dropping `:even` usage required a change to the
[`header` option](https://api.jqueryui.com/accordion/#option-header)
of the accordion widget. I made it an optional function; this will need
to be documented.

The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was
no usage of the :odd selector in the code but the `.odd()` method is also
polyfilled for completeness.

Closes gh-1904
2020-01-22 16:44:34 +01:00
Kevin Cupp
87eab46a58 Sortable: Setting table row placeholder height to be same as sorted row
Fixes #13662
Closes gh-1578
2016-10-04 15:22:14 -04:00
Amanpreet Singh
749f95ee0a Sortable: Shift to use no globals 2016-04-14 00:14:57 +05:30
Leonardo Balter
60fa118955 Tests: Fix improper async sortable test
Caught when testing jQuery UI against the new QUnit version, where start throws
an error if called with a non-numeric error.

Closes gh-1630
2015-10-27 13:55:55 -04:00
Alexander Schmitz
62c8217185 Sortable: Style updates
Ref #14246
2015-09-11 08:29:08 -04:00
Alexander Schmitz
d86ac025ee Sortable: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:22 -04:00
Alexander Schmitz
657b6d0f58 Sortable: Move sortable into widgets folder
Ref #13885
2015-08-08 00:29:39 -04:00
Alexander Schmitz
3b2db14b3b Draggable: Move draggable into widgets folder
Ref #13885
2015-08-08 00:29:38 -04:00
Alexander Schmitz
d157b59a51 Sortable: Remove core event/alias and deprecated module dependencies 2015-05-20 14:27:56 -04:00
Scott González
6231b161b9 Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.
2015-04-17 12:13:38 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00
Scott González
dc4b015a8b Tests: Widget test helpers extend the main helper
Ref #10119
Ref gh-1528
2015-04-09 09:26:58 -04:00
Scott González
31e36e6ae4 Sortable: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:26:26 -04:00
Scott González
500f6b4992 Tests: Switch to the new qunit-composite module
This module was created from our existing implementation.

Closes gh-1532
2015-04-07 09:03:36 -04:00
Scott González
c42a07a2e3 All: Standard spacing inside selector strings
Closes gh-1521
2015-03-26 07:47:17 -04:00
Alexander Schmitz
8f26f0ad1a Sortable: Use new has/lacksClasses assertions for all class checks 2015-03-11 16:05:40 -04:00
Alexander Schmitz
c192d4086d Widget: Add classes option and _add/_remove/_toggleClass methods
Fixes #7053
Closes gh-1411
2015-03-11 16:00:04 -04:00
Nils Heuermann
962e05dc1d Sortable: Append a tr with td to the placeholder of tbody elements
When sorting tbody elements of a table the placeholder needs to have a tr with
td elements to be visible. The appended elements are created in the same way
as for the placeholder of a tr element; the first row of the sorted tbody is
used for that.

Fixes #10682
Closes gh-1380
2015-02-24 09:36:12 -05:00
Jörn Zaefferer
2aabd427eb Tests: Fix style issues with missing or multiple line breaks
As pointed out by jscs, after a esformatter run. The latter doesn't
address these, so fixing them manually.
2015-01-24 17:10:20 +01:00
TJ VanToll
f656aebe3f Sortable: Redetermine floating flag when recalculating positions
This addresses a bug where users initialize empty sortable lists are
add items dynamically. In this situation refresh() should recognize the
position and orientation of the new items.

Fixes #7498
Closes gh-1381
2014-11-04 08:15:26 -05:00
Mike Sherov
d8a79a5e0e Effects tests: Add clip visual test
Closes gh-1338
2014-09-03 14:46:52 -04:00
Mike Sherov
aa425ab95d Build: Pull in jquery.simulate.js from Bower
Fixes #10563
2014-08-22 17:01:50 -04:00
Andrei Picus
1cfebf803b Sortable: fire "over" and "out" even when a connectWith hasn't changed
Fixes #9335
2014-08-13 20:27:26 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Andrei Picus
998d04d55d Tests: sortable: fix assert message.
Changed 'stop' to 'over'.

Closes gh-1174
2014-01-20 09:42:14 -05:00
TJ VanToll
28310ff55f Slider & Interactions: Add Windows 8 touch support
Fixes #9709
Fixes #9710
Closes gh-1152
2014-01-15 15:38:10 -05:00
Andrei Picus
23c7d367b1 Sortable: Cleanup
Closes gh-1168
Closes gh-1169
2014-01-15 04:10:10 -05:00
Kris Borchers
601ad962e0 Sortable: Adjust itemWithLeastDistance algorithm in _contactContainers to properly handle dragging items to the beginning and ends of lists. Fixes #9314 - Sortable: Items cannot be dragged directly into bottom position. Fixes #9381 - Sortable: Connected list placeholders have an inaccurate initial position 2013-11-01 15:17:05 -05:00
Bruno M. Custódio
0d5eaab9bb Updating jQuery to 1.10.2.
Adding jQuery 1.10.0, 1.10.1, 1.10.2, 2.0.0, 2.0.1, 2.0.2 and 2.0.3 to the
tests directory.
2013-07-05 08:42:37 -04:00
Scott González
09b3533910 Sortable: Copy the cell structure when sorting a table row. Fixes #9185 - Sortable: Placeholder breaks table-layout: fixed. 2013-04-02 10:42:21 -04:00
Mike Sherov
bbb53df27d Sortable Tests: Fix IE7 Test fails by being more generous with dragging near borders. 2013-03-31 12:07:01 -04:00
Mike Sherov
384f181254 Sortable Tests: Fix IE7 test failures due to incorrectly expecting relative urls in img srcs. 2013-03-31 11:55:24 -04:00
Jason Moon
f306a826a4 Sortable: update placeholder when axis is x or y for connected lists. Fixed #8301 - Placeholder doesn't move when using connectWith option 2013-03-23 15:42:38 -04:00
Mike Sherov
4484c52a4d Sortable Tests: Add tests for axis option and recent axis option bugs. 2013-03-14 22:56:48 -04:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Mike Sherov
8b1b34c5c3 Sortable Tests: Add tests to support #9041 and #8792 2013-03-08 16:52:49 -05:00
Scott González
5b2da7c127 Sortable tests: Added alt attributes to images. 2013-03-07 13:15:16 -05:00
Scott González
b9be6bb7ad Sortable: Copy the src of the original item when creating a placeholder from an image. Fixes #5129 - Sortable: Unable to use an image as a placeholder in Firefox. 2013-03-07 12:55:00 -05:00
Scott González
bd47bd4ace Sortable: When sorting table rows, create a td to force dimensions. Fixes #4765 - Sortable: Placeholder not displayed when sorting table rows. 2013-02-20 20:16:29 -05:00
Bruno M. Custódio
b440979ba6 Updating 'jQuery' to 1.9.1. 2013-02-05 13:47:59 +00:00
Kris Borchers
34409e7ddd Updating to jQuery 1.9.0 2013-01-17 00:28:41 -06:00