Commit Graph

209 Commits

Author SHA1 Message Date
Jörn Zaefferer
e3dcaf28eb Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0bc73b74b6 Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
972f5c192c Dialog: Button is now a fixed dependency, so remove the check 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0ae6fc1e02 Dialog: Remove useless tmp vars. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
625a111fb9 Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
4c9caa8169 Dialog: Extract button pane creation into _createButtonPane 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1d6ce644e0 Dialog: Refactor _create, extracting title bar creation in _createTitlebar 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
f0acaac230 Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7a0353500a Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1001504249 Dialog: Remove outdated TODO 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
c8aef203cb Dialog: Have _makeResizable look at options instead of passing handles. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
16a79c1b9c Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7e964be80c Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
f7d3a51589 Dialog: Only add the new dialogClass, not the base classes when changing the option. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
324d54dd32 Dialog: Use $.isEmptyObject() to check if there a button-option properties 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4e03321fd7 Dialog: Trigger focus event when dialog is moved to top. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
b6cefc797e Dialog: Remove deprecated disableSelection() usage. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
4632780435 Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2062a18db6 Dialog: Inline code review 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
0a25b2c448 Dialog: move to top when opening again, and focus as if opened from scratch. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
8ee8046c02 Dialog: Keep focus inside modal dialog, by handling focus events on elements outside of it 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2a887e4321 Dialog: Improve accessibilty - add an aria-describedby attribute on the dialog if there is nothing yet in the dialog content. Partial fix for: 2012-11-26 10:26:11 +01:00
Scott González
f5870712c1 Updated all widgets to use proper data keys when getting plugin instances. 2012-11-09 13:28:13 -05:00
Scott González
a8de99c791 Dialog: Don't use .attr( props, true ). 2012-11-05 09:37:19 -05:00
Corey Frang
a688e7c8d4 Mixed spaces and tabs removed 2012-10-29 13:37:06 -05:00
Scott González
5bd4b11d9b Dialog: Removed minHeight workaround for IE6. 2012-10-26 14:36:35 -04:00
Scott González
68cab60fa7 Removed bgiframe. 2012-10-26 10:53:17 -04:00
Jörn Zaefferer
d07074dc3c Dialog: Use _show and _hide consistently. Fixes #4892 - Dialog: zIndex error with animated modal dialog. 2012-10-24 17:03:00 -04:00
Jörn Zaefferer
513b6da641 Dialog: Keep focus inside dialog, even when dialog itself has focus. 2012-10-24 17:03:00 -04:00
David Souther
3a09a4a0de Dialog: Prevent tabbing off any dialog. Fixes #3768 - Dialog: contain focus within dialog. 2012-10-24 17:03:00 -04:00
Jörn Zaefferer
14691ae6fe Dialog: Save the active element that opened the dialog and restore focus to that. Fixes #8730 - Dialog: Restore focus to opener. 2012-10-24 17:02:32 -04:00
Jörn Zaefferer
2a2a2c017c Dialog: Prevent dialog form losing focus (or move it back in IE <= 8). 2012-10-24 16:57:13 -04:00
Nate Eagle
3829a37ca1 Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:
Fixes #3534 - Dialog: Modal dialog disables all input elements on page.
Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.
Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.
Fixes #5388 - Dialog: Don't change z-index when already at the top.
Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.
Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.
Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.
Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.
Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).
Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.
Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.
Fixes #8583 - Dialog: Mouse event wrongly stopped.
Fixes #8722 - Dialog: Remove stack option.
Fixes #8729 - Dialog: Remove zIndex option.
2012-10-24 16:56:19 -04:00
Scott González
11effcbd35 Dialog: Don't use deprecated offset option for .position(). Fixes #8675 - Dialog: Position with pixels in array doesn't work with back compat disabled. 2012-10-23 14:50:02 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
David Petersen
35dc9307fc Dialog: Use _hide() to make sure close event gets triggered. Fixes #8684 - jQuery dialog with hide options does not trigger close event. 2012-10-17 20:28:27 -04:00
Dale Kocian
1a69667887 Dialog: Added mousedown event handler on dialog title to focus. Fixed #8063 - Dialog: Escape closes incorrect dialog. 2012-10-16 09:17:21 -04:00
Scott González
a3f1a34d3b Remove use of $.browser; add $.ui.ie and $.ui.ie6 temporarily. 2012-10-10 11:45:48 -04:00
Richard D. Worth
1e6e4ce4dc Dialog: add required closing tag </button>. Fixes #8639 - jQuery 1.9.0 dialog on a XHTML page is broken if buttons are defined 2012-10-09 08:41:18 -04:00
Scott González
4ab4684cfc Dialog: Don't try to place the dialog next to itself on destroy. Fixes #8613 - Destroying a dialog removes the original element from the DOM. 2012-10-01 15:34:44 -04:00
Scott González
149567e476 Updated docs URLS. 2012-09-26 18:06:20 -05:00
Scott González
6abb10766c Dialog: Only bind focus-trapping event once. Fixes #8551 - After repeated opening and closing of a modal dialog, focus navigation using tab becomes slow. 2012-09-04 17:00:26 -04:00
Scott González
485ca7192a Simplify licensing. 2012-08-09 15:09:50 -04:00
Lee Rowlands
5a952856a0 Dialog: Prevent tabbing out of modal dialog. Partial fix for #7862 - Dialog: modal accessibility. 2012-07-05 21:23:39 -04:00
Scott González
a4534bb993 Update copyright to jQuery Foundation. 2012-07-04 09:08:08 -04:00
Scott González
ff39bed57a Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off. 2012-06-14 12:33:16 -04:00
kborchers
240b22b143 Dialog: Use new uniqueId method for generating id's 2012-05-29 23:11:42 -05:00
Scott González
286941ef8d Dialog: Only create the button pane once and store a reference to it. Fixes #8343 - _createButtons removes all elements with .ui-dialog-buttonpane class. 2012-05-22 08:28:53 -04:00
Scott González
8fcf7ea828 Dialog: Remove uses of self var; use that var. 2012-05-09 20:20:15 -04:00
Scott González
650fe5c5db Dialog: Removed trailing whitespace. 2012-05-07 09:57:18 -04:00
Jay Merrifield
cab4c467d9 Dialog: Handle escape for all overlays. Fixes #8300 - Dialog: Incorrect behavior for ESCAPE with multiple modal dialogs. 2012-05-07 09:44:26 -04:00
Scott González
cb8474af1d Remove trailing whitespace. 2012-04-18 21:57:51 -04:00
Scott González
639afa5954 Lint fixes. 2012-04-02 19:12:21 -04:00
Jo Liss
37dcc3e21d Protect all copyright notices against minification
For instance, this is useful for the jquery-ui-rails gem, which does not
use jQuery UI's own minification, but relies on Rails to minify the
files where necessary. Rails in turn uses UglifyJS for JS and YUI for
CSS, both of which respect the /*! ... */ convention.
2012-04-02 15:21:06 +02:00
Scott González
932fe888c0 Updated copyright year. 2012-03-08 10:53:08 -05:00
Alberto Monteiro
a4b7feabd3 Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position 2011-12-15 17:52:49 -03:00
James Khoury
ce0afde900 Dialog: Modified the dialog._size() to use outerHeight in calculating the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set. 2011-11-28 16:52:10 -05:00
Jörn Zaefferer
66f9e12797 Widget: Remove method argument from _super and _superApply. Was a left-over from first implementation, not necessary anymore. 2011-11-18 17:08:40 +01:00
Scott González
a0856efef3 Widget: Added window and document properties. Fixes #7801 - Widget: Add document and window properties. 2011-10-20 16:57:47 -04:00
Florian Gutmann
42d33f2f86 Dialog: fix small memory leak when having lot's of instances. Fixes #7793 - Small memory leak in ui dialog. 2011-10-14 11:18:48 -04:00
Corey Frang
dfe75e1b55 Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thought it would everywhere, switching back to keydown. 2011-08-20 18:05:39 -05:00
Corey Frang
96e5c241e1 Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog 2011-08-19 06:03:59 -05:00
Scott González
19a9de7e66 Merge branch 'master' into core-1.6.1
Conflicts:
	demos/menubar/default.html
	tests/unit/autocomplete/autocomplete.html
	tests/visual/effects/effects.all.html
	ui/jquery.ui.menu.js
	ui/jquery.ui.popup.js
2011-07-25 11:53:14 -04:00
Scott González
0dc4a48762 Dialog: Append the dialog to the body early to make sure styles from the classes get applied. 2011-07-12 09:16:22 -04:00
Scott González
da84672db8 .attr() -> .prop() 2011-06-08 17:02:57 -04:00
Scott González
6a5b21fda2 All: Moved version numbers into prototypes. Fixed #7436 - Widget: Store version numbers on instances. 2011-05-28 15:39:55 -04:00
Jay Merrifield
e34dbfeef0 Dialog: Removed the height() tinkering which stops the dialog from shrinking. Fixes #5916 - Dialog: shrinks on drag in IE in standards mode, worse in quirksmode. 2011-05-26 23:30:56 -04:00
David Murdoch
c7eae7b264 Dialog: Make close() a noop if the dialog is already closed. Fixes #7327 - Dialog box size and close animation bugs. 2011-05-26 19:29:11 -04:00
Jörn Zaefferer
1c193085e1 Merge remote branch 'kborchers/bug_3623' 2011-05-18 17:07:02 +02:00
Scott González
a0f16a00b9 Dialog: Reduce old overlay dimensions to 0x0 to avoid sizing issues. Fixes #5637 - Dialog: Dimensions of reused overlay may cause scrollbars. 2011-05-18 09:34:50 -04:00
kborchers
331c4602a9 Dialog: Create modal overlay after dialog is shown and check scrollHeight and offsetHeight in all IE versions. Fixed #4995 - Modal Dialog's overlay dissapears in IE when content is tall 2011-05-12 15:14:58 -05:00
kborchers
29b36bb409 Dialog: Changed IE6 overlay width adjustment to apply to all IE versions. Fixed #3623 - Opening a Modal Dialog shows a horizontal scroll bar 2011-05-12 13:31:15 -05:00
Kato Kazuyoshi
27f943bf36 Dialog: 'NO-BREAK SPACE' (U+00A0) is not 'SPACE' (U+0020). 2011-05-07 16:02:06 +09:00
Adam Baratz
51df02ee4e Dialog: remove unneeded DOM manipulations. Fixed #7258 - optimize initialization. 2011-05-02 18:03:14 -04:00
Jay Merrifield
f9996682b5 Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs. 2011-03-08 09:42:10 -05:00
Douglas Neiner
15c97e0b76 Dialog: Added a class to dialog wrapper when it is currently displaying buttons, includes unit tests for changes. Fixed #7057 - An extra class is needed on the dialog wrapper to specify when a buttonset is showing 2011-03-03 09:37:16 -05:00
Scott González
3e370a4467 Dialog: Use ._focusable() and ._hoverable(). 2011-01-24 21:58:40 -05:00
Scott González
6e0482a9cb Updated copyright year. 2011-01-17 09:13:18 -05:00
Scott González
e0b52831fc Updated widgets to use new methods from $.Widget. 2011-01-15 06:34:07 -05:00
Scott González
56c4c6aca9 Change destroy to _destroy and remove calls to $.Widget.prototype.destroy in widgets with simple destroy methods. 2011-01-14 17:11:22 -05:00
Scott González
04667b1518 Dialog: Fixed creation of close button in IE.
Thanks dkiselev.
2011-01-11 14:34:17 -05:00
Max Schnur
727d00dec8 Dialog: Modified close button binding to use event.preventDefault() instead of return false. Fixes #6766 - Dialog: Clicks on close button don't bubble. 2010-12-20 09:00:28 -05:00
Scott González
c614889b30 Dialog: Coding standards. 2010-12-17 19:53:22 -05:00
Scott González
ca0ac5a64f All: Remove workaround for .offset() setter bug from older versions of jQuery. 2010-12-11 15:19:25 -05:00
Scott González
b42125af43 Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose. 2010-12-10 14:31:36 -05:00
Scott González
0e15f573d6 Revert "Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError."
This reverts commit 22671ad4f8.
2010-12-10 13:42:29 -05:00
Scott González
22671ad4f8 Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError.
This should be reverted in jQuery UI 1.9.
2010-12-08 12:36:19 -05:00
Scott González
b9e34f726a Dialog: Don't hide the dialog in _size if it started visible. Fixes #6717 - Dialog: Adding a button makes the dialog disappear in IE6. 2010-12-03 08:31:06 -05:00
jamiejag
8bb412dd4a Dialog: Ensure dialogs have a z-index when calculating the max z-index. Fixex #5955 - Dialog: Closing UI dialog when z-index is not defined in any .ui-dialog class, causes NaN to be used as Z-index, throwing an error. Fixes #4652 - Dialog: Event loss in subsequent dialog calls (FF3). 2010-11-19 09:02:01 -05:00
Scott González
c2139fc2e6 Dialog: Added some missing semicolons. 2010-11-12 12:57:34 -05:00
Jay Merrifield
dfb3544297 Dialog: Make sure the overlay instance still exists before trying to remove it. Fixes #6645 - Dialog: Missing element not found check in overlay code. 2010-11-12 08:16:41 -05:00
Scott González
302728bd87 Dialog: Fixed logic for mimicking minHeight. Fixes #6150 - Dialog height:auto does not work in IE6. 2010-10-05 16:20:43 -04:00
John Firebaugh
e66cdfcf59 Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7. 2010-10-04 09:18:46 -04:00
Scott González
c090802cc1 Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."
This reverts commit 67b1db14c9.

Reverting so I can commit again with the proper author.
2010-10-04 09:18:21 -04:00
Scott González
67b1db14c9 Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7. 2010-10-04 09:15:40 -04:00
Scott González
d7670b9407 Dialog: Don't pass props to jQuery when creating buttons.
Thanks jitter.
2010-10-01 11:19:24 -04:00