Commit Graph

21 Commits

Author SHA1 Message Date
Michael Wiencek
0dc84db853 Tooltip: Preserve the title after disabling twice
Fixes #9719
Closes gh-1154
2014-01-09 20:38:08 +01:00
Daniel DeGroff
af85dfcafb Tooltip: On close and destroy only set title if empty or undefined
Ticket #8925 states that changes to the title attribute while the
tooltip is open are lost on tooltip close.

In the close and destroy functions, the title attribute is always
written if a value was stored in the element on open. It is possible
the attribute has changed and restoring the initial value may overwrite
the current value.

If the value is empty or undefined as set in open, do not set the title
attribute.

This fix has the limitation that if the user removed the title
attribute or set the value to an empty string the original title value
would be restored on close and destroy.

Fixes #8925
2014-01-06 16:10:02 +01:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Scott González
0a31a82831 Tooltip: Better cleanup on destroy. Fixes #8627 - The Tooltip destroy method is not clearing up the data properties. 2012-10-05 12:52:02 -04:00
Scott González
96f2aa4c72 Tooltip: Check if event exists before checking properties in open(). Fixes #8626 - Programatically opening a tooltip with out giving an event results in a javascript error. 2012-10-05 11:26:49 -04:00
Scott González
b22e3c36f2 Tooltip tests: Added test for widget() method. 2012-08-26 20:21:24 -04:00
Scott González
abbf6a79a9 Tests: Update support comments. 2012-06-25 14:51:51 -04:00
Jörn Zaefferer
0fcf37fba6 Tooltip: Make title-tests pass in IE6/7 with jQuery 1.6, where undefined attribute is returned as empty string 2012-06-19 17:12:38 +02:00
Scott González
b6cc9dd870 Tooltip: Handle multiple aria-describedby values. 2012-05-22 11:06:44 -04:00
Scott González
a28983086e Tests: Lint. 2012-04-18 22:36:15 -04:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
Scott González
da84672db8 .attr() -> .prop() 2011-06-08 17:02:57 -04:00
Scott González
8c085cd27c Tooltip: Fixed handling of disabled tooltips. 2011-05-29 20:50:21 -04:00
Scott González
4dbfdcede3 Tooltip: Allow content updates via async response regardless of whether a sync response came back. Added more tests. 2011-05-28 17:36:57 -04:00
Scott González
666b53a90c Tooltip tests: Refactored and added some tests. 2011-05-28 16:20:46 -04:00
Scott González
73c6f349fc Tooltip tests: Coding standards. 2011-05-28 13:30:00 -04:00
Jörn Zaefferer
b2b7d9a8b0 Tooltip: Fix (most) of the unit tests. Not all issues resolved, but
enough for testswarm results to be useful.
2011-05-02 21:04:56 +02:00
jzaefferer
96977edecc Use pushStack in tooltip's widget method. See #5732 2010-07-30 14:30:43 +02:00
jzaefferer
84e0ce168f Tooltip: Unit tests for tooltip and a fix to pass through event objects to triggered events 2010-04-15 09:45:35 +02:00