Commit Graph

230 Commits

Author SHA1 Message Date
claudi
17404ced47 Datepicker: Fix prev/next button behavior with showCurrentAtPos
Fixes #15102
Closes gh-1784
2017-01-25 11:14:57 -05:00
Ryan Oriecuia
573e7e69c9 Autocomplete: Fix IE/Edge scrolling issues
IE11 and scrolling autocompletes didn't get along great; this should help fix
their relationship.

When you click on an autocomplete scrollbar in IE11, the menu temporarily
gains focus, which caused a couple problems.

1. Depending on how long you clicked, the dropdown could close.

2. Scrolling down by clicking the scrollbar's down arrow would misbehave. The
list would pop back up to the top with the first item selected.

We can fix both problems by modifying the focus/blur handling a bit.

1. There is a flag to instruct the control to ignore blurs, but it was getting
cleared too quickly; when the code refocused the input after it was blurred,
IE would send *another* blur event, which wasn't getting ignored and would
close the dropdown. We now wait for the focus/blur pair to process before
clearing the flag.

2. We remove the tabindex from the dropdown menu, which prevents menu's focus
handler from firing. When you focus a menu, it will select the first menu item
if none are selected. Selecting a menu item will scroll it into view if it's
not visible. This combination of behaviors was causing the strange behavior
when attempting to scroll down.

I couldn't figure out a way to write a unit test for this, since it's IE only
and seems to require user interaction. You can verify the previous behavior
(and the fix) on `demos/autocomplete/maxheight.html`

Fixes #9638
Closes gh-1785
2017-01-25 10:57:34 -05:00
Scott González
a2b25ef6ca Selectmenu: Don't render options with the hidden attribute
Fixes #15098
2016-11-16 12:52:15 -05:00
pallxk
9a4c057157 Tooltip: Clear interval for delayed tracking tooltips on remove
This is needed in the case that the tooltip is removed before it gets shown.

Fixes #15099
Closes gh-1768
2016-11-16 12:12:22 -05:00
Kyle Rosenberg
863a49f95b Spinner: Fix typo
Closes gh-1764
2016-11-02 12:48:00 -04:00
Jeremy Mickelson
9c5ce4c3e9 Sortable: Fix z-index switching from auto to 0
Save `z-index` before saving `opacity`. Setting `opacity` automatically
changes `z-index`.

Fixes #14683
Closes gh-1762
2016-10-19 14:46:47 -04:00
Scott González
0627eb3645 Form: Rename from .form() to ._form() since its not for public use
Fixes #15074
Closes gh-1760
2016-10-11 10:15:04 -04:00
Kevin Cupp
87eab46a58 Sortable: Setting table row placeholder height to be same as sorted row
Fixes #13662
Closes gh-1578
2016-10-04 15:22:14 -04:00
Alexander Schmitz
b9d687deb5 Checkboxradio: Don't add ui-state-hover to icons
Fixes #15055
Closes gh-1756
2016-10-04 11:33:17 -04:00
Robin
1d409528a1 Sortable: Fix parent offset detection
Fixes #15021
Closes gh-1749
2016-10-04 11:05:01 -04:00
Evelyn Masso
fd30534b73 Droppable: Use $.ui.intersect()
Fixes #14963
2016-10-03 09:16:41 -04:00
milk54
b9ffc34710 Tabs: Remove presentation role
Fixes #10122
Closes gh-1748
2016-09-29 10:15:19 -04:00
Sergei Ratnikov
c481400f22 Resizable: Fix aspectRatio cannot be changed after initialization.
Fixes #4186
Closes gh-1750
2016-09-28 11:55:13 -04:00
Scott González
19027bb085 Sortable: Use an event object for simulated mouseup in cancel()
Regression caused by a1d69208ba

Fixes #15042
Closes gh-1746
2016-09-14 12:06:33 -04:00
Ryan Oriecuia
8c66934434 Draggable: Fix spurious blur in dialogs on mousedown
I was running into a problem with a popup menu control in a dialog; clicks
weren't working (but keyboard was working fine). It turned out that the menu
was getting destroyed before the click event could fire.

Tracked down the issue to the way draggable blurs focused controls; it was
doing the blur before it ran through the logic to figure out if the drag was
actually on the handle. I've moved the blur below these checks, so it'll only
blur things if it actually needs to handle the drag. Otherwise, it asserts no
opinion on what should and shouldn't be focused, which seems like the way
things ought to be.

Also, added a unit test to check for the expected behavior.

Fixes #15046
Closes gh-1730
2016-09-13 08:53:00 -04:00
Scott González
51461d5238 Slider: Add demo for custom handle
Fixes #15023
Closes gh-1740
2016-09-13 08:41:33 -04:00
Scott González
3606e1c33a Controlgroup: Don't use String.prototype.trim()
We still support IE 8, which doesn't have this method.
2016-08-31 16:29:56 -04:00
Scott González
398bd8dd36 Tabs: Strip hash from remote content URLs
As of jQuery 3.0.0, hashes are no longer stripped for Ajax requests. This
causes issues in IE <11, so we need to strip this before making the request.

Ref jquery/jquery#1732
Closes gh-1736
2016-08-31 07:45:09 -04:00
Felix Nagel
ac9ca9e52c Menu: Support number pad keyboard input
Fixes #15031
Closes gh-1732
2016-08-24 11:56:26 -04:00
Scott González
6c754b4b5b Dialog: Support deprecated button options
Fixes #15016
Closes gh-1723
2016-07-25 08:38:51 -04:00
Scott González
f67f9293ae Controlgroup: Handle child elements that don't have options defined
Closes gh-1719
2016-07-13 12:10:41 -04:00
Scott González
55cd9488cc Checkboxradio: Fix label handling with jQuery 3.x
Fixes #15006
Closes gh-1720
2016-07-12 13:06:23 -04:00
Gabriel Schulhof
3a9a3c7c5b Controlgroup: Correctly handle non-empty child class key
Fixes #14984
Closes gh-1713
2016-07-06 09:42:31 -04:00
Alexander Schmitz
8a79fc8784 Controlgroup: Add "only" position to class generator functions
Fixes #14972
Closes gh-1711
2016-06-09 14:10:40 -04:00
Alexander Schmitz
abc2a755f9 Checkboxradio: Use new ui-state-checked class in checkboxradio
Using `ui-state-highlight` caused a conflict with dialog

Fixes #14955
Closes gh-1712
Closes gh-1704
2016-06-06 11:34:52 -04:00
Alexander Schmitz
7d5e6d2496 Controlgroup: Fix rendering of labels
Fixes #14967
Closes gh-1703
2016-05-26 09:15:48 -04:00
Alexander Schmitz
81a8e30c07 Controlgroup: Fix issues with compatibility with spinner
Fixes #14966
2016-05-26 09:15:48 -04:00
Alexander Schmitz
04b670e6cc Controlgroup: Don't remove existing classes classes
unless its a corner class

Fixes #14960
2016-05-26 09:15:48 -04:00
Scott González
fbc79e1bda Tabs: Fix test 2016-05-25 08:41:08 -04:00
Scott González
219744cadf Tabs: Fix default classes option
Fixes #14973
2016-05-25 07:45:23 -04:00
Scott González
f928f258b7 Droppable: Re-expose $.ui.intersect()
Fixes #14963
Ref #10534
2016-05-04 18:48:41 -04:00
Scott González
010f5f9d13 Tooltip: Fix re-enabling of delegated tooltips
Fixes #14950
Closes gh-1699
2016-04-21 10:59:27 -04:00
Alexey Balchunas
a240251b36 Selectable: Proper handling of inner scrolling
Fixes #13359
Closes gh-1570
2016-04-21 16:11:37 +02:00
Scott González
435ed7e8d2 Menu: Remove extraneous blank lines 2016-04-13 11:36:41 -04:00
Alexander Schmitz
8d1de7bff8 Accordion: Disable maxLineLength for description meta
Ref gh-1690
2016-04-13 11:32:17 -04:00
Alexander Schmitz
9aa5dea968 Datepicker: Disable maxLineLength for jscs
There are too many errors and re-write is essentially done

Ref gh-1690
2016-04-13 11:32:13 -04:00
Alexander Schmitz
986aa54911 Progressbar: Disable maxLineLength for description meta
Ref gh-1690
2016-04-13 11:32:12 -04:00
Alexander Schmitz
307f94621a Selectmenu: Disable maxLineLength for description meta
Ref gh-1690
2016-04-13 11:32:10 -04:00
Alexander Schmitz
ca3d4511c4 Accordion: Fix line length issues
Ref gh-1690
2016-04-13 11:31:56 -04:00
Alexander Schmitz
adbd694a3e Checkboxradio: Fix line length issues
Ref gh-1690
2016-04-13 11:31:55 -04:00
Alexander Schmitz
fcf97a033f Controlgroup: Fix line length issues
Ref gh-1690
2016-04-13 11:31:53 -04:00
Alexander Schmitz
c57f4e5ced Dialog: Fix line length issues
Ref gh-1690
2016-04-13 11:31:52 -04:00
Alexander Schmitz
545bcfec8e Draggable: Fix line length issues
Ref gh-1690
2016-04-13 11:31:50 -04:00
Alexander Schmitz
8a6d4c1a15 Droppable: Fix line length issues
Ref gh-1690
2016-04-13 11:31:48 -04:00
Alexander Schmitz
88f74e1656 Menu: Fix line length issues
Ref gh-1690
2016-04-13 11:31:47 -04:00
Alexander Schmitz
55b53b5462 Mouse: Fix line length issues
Ref gh-1690
2016-04-13 11:31:45 -04:00
Alexander Schmitz
a69b1a9eb8 Progressbar: Fix line length issues
Ref gh-1690
2016-04-13 11:31:44 -04:00
Alexander Schmitz
c5eca7443c Resizable: Fix line length issues
Ref gh-1690
2016-04-13 11:31:42 -04:00
Alexander Schmitz
b74a8b68bd Selectable: Fix line length issues
Ref gh-1690
2016-04-13 11:31:40 -04:00
Alexander Schmitz
b6b4dd1279 Slider: Fix line length issues
Ref gh-1690
2016-04-13 11:31:38 -04:00
Alexander Schmitz
e1f23184a6 Sortable: Fix line length issues
Ref gh-1690
2016-04-13 11:31:36 -04:00
Alexander Schmitz
a4c9809340 Spinner: Fix line length violations
Ref gh-1690
2016-04-13 11:31:34 -04:00
Alexander Schmitz
f42a759b32 Tabs: Fix line length violations
Ref gh-1690
2016-04-13 11:31:21 -04:00
Scott González
57f801f1de Menu: Don't reset active element until after triggering blur event
This ensures that `ui.item` actually exists in the `blur` event.

Fixes #14945
Closes gh-1696
2016-04-13 11:08:21 -04:00
Maksim Ryzhikov
c19fc10e84 Sortable: Fix incorrect top containment for document
Fixes #14927
Closes gh-1695
2016-04-12 15:39:06 -04:00
dstrohl
9aca706732 Sortable: Update _contactContainers to use page clientX/Y values
The sortable was using the window position compared with page position to
determine where to drop objects.  this was only a problem for sortables far
enough down to require scrolling.

Fixes #10727
Fixes #5039
Closes gh-1475
Closes gh-1585
2016-03-30 18:48:29 -04:00
Rand Scullard
d21aeee809 Menu: Check that there is an active item in _activate()
Closes gh-1606
2016-03-30 14:43:03 -04:00
Konstantin Dinev
623b64eefc Resizable: Implement setOption for handles
Fixes #3423
Closes gh-1666
2016-03-30 14:08:41 -04:00
Mukul Hase
a1905e2c5e Slider: Fixed max value miscalculation
Fixes #12852
Closes gh-1664
2016-03-30 13:28:04 -04:00
Alexander Schmitz
bff8277fbc Selectmenu: Prepend icon and move overflow to text span
Fixes #14938
Closes gh-1685
2016-03-30 11:53:28 -04:00
Piotr Baran
bf5d6f314b Datepicker: Fixed keyboard navigation
Fixes #7956
Closes gh-1677
2016-03-30 09:42:38 -04:00
Alexander Schmitz
882eb4cbf2 Checkboxradio: Check that there is an icon before toggeling class
Fixes #14939
Closes gh-1686
2016-03-30 09:25:11 -04:00
Francesc Baeta
89fe04af3d Resizable: Fix top jump with rotated element
Fix top jump when resizing a rotated element (90°) using north handle
and exceeding the minmal height (default 10px).

Bug was found using a resizable-rotation-patch:
https://github.com/unlocomqx/jQuery-ui-resizable-rotation-patch

Closes gh-1687
2016-03-30 09:24:03 -04:00
Jörn Zaefferer
4866e14922 Menu: Remove active class from top-level item when menu is blurred
This issue was introduced by 0bbd156918,
which reduced the use of ui-state-focus and ui-state-active to using
only ui-state-focus. This introduced the issue addressed here.

The fix is more of a workaround. With test test in place, we can
investigate a better solution in the future.

Fixes #14919
2016-03-11 18:27:58 +01:00
Alexander Schmitz
20466d5027 Selectmenu: Fixed selectmenu icon float right
Also removes the icon space as its not needed with a floated icon

Fixes #14914
Closes gh-1671
2016-02-24 11:29:44 -05:00
Fahad Ahmad
8564641fb8 Datepicker: Use getFullYear() instead of deprecated getYear()
Fixes #14920
Closes gh-1678
2016-02-21 12:38:23 -05:00
Scott González
cbceca7091 Autocomplete: Work around isContentEditable bug in Chrome
Fixes #14917
Closes gh-1673
2016-02-16 12:22:10 -05:00
Alyosha Pushak
c87653bc24 Accordion: Correct height calculated when closed
Fixes #11938
Closes gh-1536
Closes gh-1616
2016-02-09 14:40:29 -05:00
Scott González
63c103dd54 Draggable: Improve detection for when to blur the active element
Fixes #12472
Fixes #14905
Closes gh-1548
2016-02-09 13:37:26 -05:00
Benjamin Albert
cd7f8f02cf Datepicker: Refactor _updateAlternate() method
Closes gh-1647
2015-11-13 10:50:36 -05:00
Scott González
7cc88bfe32 Resizable: Fix data reference for ui-resizable-alsoresize
Fixes #14788
2015-11-09 09:16:13 -05:00
Scott González
6a681c2c13 Resizable: Don't use CSS shorthand properties with .css()
Fixes #7766
Closes gh-1644
2015-11-05 11:44:09 -05:00
Scott González
e77fbe5388 Checkboxradio: Properly find radio groups from the associated form
Fixes #9973
Closes gh-1631
2015-10-29 11:19:13 -04:00
Jörn Zaefferer
9644e7bae9 Dialog: Escape closeText option before passing it to button
Ref gh-1632
Fixes jquery/api.jqueryui.com#281
2015-10-28 19:48:35 +01:00
Scott González
17b5386e8c Mouse: Ignore mousemove events triggered by key presses in Safari
If the user presses control, meta, shift, or alt during a drag operation,
Safari will trigger an event where `event.which` is `0`. We use that scenario
to detect that a `mouseup` occurred in a different document, so we need to
ignore these events when one of the keys are pressed.

Fixes #14461
Closes gh-1620
2015-10-27 14:12:00 -04:00
Jörn Zaefferer
39853fda45 Selectmenu: Handle form resets
Fixes #12236
Ref gh-1550
2015-10-27 10:28:04 -04:00
Scott González
5d7e8b1824 Button: Fix call to ._toggleClass() 2015-10-26 16:58:49 -04:00
Jörn Zaefferer
09fde89a24 Controlgroup: Fix create and destroy for controlgroupLabel
Creating the label broke while doing a refactoring, the lack of tests
allowed that to go unnoticed. Shouldn't happen again with the extra
tests, covering both controlgroupLabel and spinner.
2015-10-26 10:09:20 -04:00
Jörn Zaefferer
cb69f0025f All: Fix manifest issues for categories and CSS dependencies
Collapses "UI Core" and "Core" into just "Core".

Fixes bad paths for CSS dependencies. Regressed when moving widgets
into the widgets subfolder.
2015-10-23 09:09:51 -04:00
Hannah Methvin
a1d69208ba Mouse: Don't stop propagation of mouseup
Fixes #10818
2015-10-18 12:36:43 -04:00
Mani Mishra
d573232707 Tooltip: Use show.delay update only when track option is active
Fixes #14682
Closes gh-1613
2015-10-17 16:14:41 -04:00
Scott González
548fbf570c Autocomplete: Close the menu on any outside interactions
This ensures that the menu will close if the user interacts with a
draggable, resizable, etc. element since those interactions don't
change focus.

Ref #6642
Closes gh-1614
2015-10-16 14:09:05 -04:00
Scott González
7df2f1905a Resizable: Remove mysterious helper dimension adjustments
Fixes #11113
Closes gh-1615
2015-10-16 10:30:03 -04:00
Jörn Zaefferer
52d9ec6c4d Checkboxradio: Add ui-state-highlight class to icon on create
This was already toggled in _toggleClasses, but that isn't called
on create.
2015-10-08 14:03:00 -04:00
Jörn Zaefferer
2bf307313b Checkboxradio: Fix invalid chars, remove unused var, add comment 2015-10-08 14:02:59 -04:00
Jörn Zaefferer
6ed30a6a5e Controlgroup: Convert to onevar, fix guard-clause/else, rm tmp var 2015-10-08 14:02:59 -04:00
Alexander Schmitz
dbadc01fbd Controlgroup: Typos and minor style fixes 2015-10-08 14:02:59 -04:00
Alexander Schmitz
874011ef0a Checkboxradio: Typos and minor style fixes 2015-10-08 14:02:58 -04:00
Alexander Schmitz
add78440f8 Button: Typos 2015-10-08 14:02:58 -04:00
Jörn Zaefferer
754e041cbd Controlgroup: Optimize and simplify data access and storage 2015-10-08 14:02:58 -04:00
Jörn Zaefferer
256a449213 Controlgroup: Improve comments and remove a misleading blank line 2015-10-08 14:02:58 -04:00
Jörn Zaefferer
6fc2cb3c7c Controlgroup: Rename excludeInvisible to onlyVisible
Gets rid of the double negative.
2015-10-08 14:02:58 -04:00
Alexander Schmitz
26f4dbce8e Spinner: Address review comments 2015-10-08 14:02:58 -04:00
Alexander Schmitz
4acdfa14b2 Controlgroup: Address review comments 2015-10-08 14:02:57 -04:00
Alexander Schmitz
344ce3c87c Checkboxradio: Address review comments 2015-10-08 14:02:57 -04:00
Alexander Schmitz
197061be56 Button: address review comments 2015-10-08 14:02:57 -04:00
Alexander Schmitz
c5d6ea4baa Spinner: Style updates 2015-10-08 14:02:57 -04:00
Alexander Schmitz
f16ecced92 Controlgroup: Style updates 2015-10-08 14:02:57 -04:00
Alexander Schmitz
739e71911e Spinner: Update markup for buttons 2015-10-08 14:02:47 -04:00
Alexander Schmitz
50a7a3d6a9 Controlgroup: Fixes for spinner 2015-10-08 14:02:47 -04:00