Commit Graph

106 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Michał Gołębiowski-Owczarek
0c860b0d92
All: Remove usage of jQuery positional selectors
jQuery positional selectors () have been deprecated in
[jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/)
and they'll be removed in jQuery 4.0.0. This PR removes their usage.

Most of the changes were possible without changing public API. However,
dropping `:even` usage required a change to the
[`header` option](https://api.jqueryui.com/accordion/#option-header)
of the accordion widget. I made it an optional function; this will need
to be documented.

The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was
no usage of the :odd selector in the code but the `.odd()` method is also
polyfilled for completeness.

Closes gh-1904
2020-01-22 16:44:34 +01:00
Scott González
a3b9129be1 Spinner: Ignore mousewheel events when not focused
Fixes #15139
Closes gh-1794
2017-02-21 12:45:19 -05:00
Amanpreet Singh
b5028f02bf Spinner: Shift to use no globals 2016-04-14 00:14:57 +05:30
Alexander Schmitz
23d0884e66 Spinner: Style updates
Ref #14246
2015-09-11 08:29:07 -04:00
Alexander Schmitz
2626be4533 Spinner: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:22 -04:00
Alexander Schmitz
33e135061f Spinner: Move spinner into widgets folder
Ref #13885
2015-08-08 00:29:39 -04:00
Alexander Schmitz
d4719bf616 Spinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points
Fixes #11097
Closes gh-1560
2015-06-03 08:37:45 -04:00
Alexander Schmitz
89bf0d057b Spinner: Remove core event/alias and deprecated module dependencies 2015-05-20 14:27:56 -04:00
Scott González
6231b161b9 Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.
2015-04-17 12:13:38 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00
Scott González
dc4b015a8b Tests: Widget test helpers extend the main helper
Ref #10119
Ref gh-1528
2015-04-09 09:26:58 -04:00
Scott González
8bda52c8d1 Spinner: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:26:27 -04:00
Scott González
500f6b4992 Tests: Switch to the new qunit-composite module
This module was created from our existing implementation.

Closes gh-1532
2015-04-07 09:03:36 -04:00
Alexander Schmitz
f7645783bf Spinner: Use new has/lacksClasses assertions for all class checks 2015-03-11 16:05:40 -04:00
Alexander Schmitz
28dccda377 Spinner: Add classes option
Ref #7053
Ref gh-1411
2015-03-11 16:05:23 -04:00
Alexander Schmitz
c192d4086d Widget: Add classes option and _add/_remove/_toggleClass methods
Fixes #7053
Closes gh-1411
2015-03-11 16:00:04 -04:00
Jörn Zaefferer
2aabd427eb Tests: Fix style issues with missing or multiple line breaks
As pointed out by jscs, after a esformatter run. The latter doesn't
address these, so fixing them manually.
2015-01-24 17:10:20 +01:00
Lisa Seacat DeLuca
2500bb39c2 Theme: Carat should be named caret
Fixes #10683
Closes gh-1382
2014-11-03 13:40:58 -05:00
Mike Sherov
aa425ab95d Build: Pull in jquery.simulate.js from Bower
Fixes #10563
2014-08-22 17:01:50 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
David Petersen
796a8b37e2 Spinner: Don't change value when changing min/max options
Fixes #9703
Closes gh-1252
2014-05-26 11:31:31 -05:00
Jörn Zaefferer
192f51c9a2 Spinner tests: Remove mousewheel plugin
The plugin isn't needed nor used in the unit tests, which just trigger the
appropriate events. This works around the failure in Firefox 27/28 that we'll
try to track down separately.

Ref #9988
2014-04-23 20:02:52 +02:00
TJ VanToll
966f80dac5 Spinner: Minor typo in stepUp()'s tests 2014-03-30 11:51:31 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Jörn Zaefferer
1552fc8a05 Spinner: Add isValid method. Fixes #9542 - Spinner: Add isValid() method 2013-09-13 00:16:31 +02:00
Bruno M. Custódio
0d5eaab9bb Updating jQuery to 1.10.2.
Adding jQuery 1.10.0, 1.10.1, 1.10.2, 2.0.0, 2.0.1, 2.0.2 and 2.0.3 to the
tests directory.
2013-07-05 08:42:37 -04:00
Mike Sherov
5217b975f3 Spinner Tests: Fix IE test failures by removing timing dependencies from focus/blur tests. 2013-04-01 08:59:52 -04:00
Mike Sherov
efe8da8e6e Spinner Tests: Fix IE test failures by accounting for the async nature of focus/blur. 2013-03-31 12:55:57 -04:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Scott González
2348fb8eb9 Spinner: Call _stop() on blur. Fixes #9112 - Spinner keeps changing after losing focus. 2013-02-22 09:15:43 -05:00
Bruno M. Custódio
b440979ba6 Updating 'jQuery' to 1.9.1. 2013-02-05 13:47:59 +00:00
Kris Borchers
34409e7ddd Updating to jQuery 1.9.0 2013-01-17 00:28:41 -06:00
Jörn Zaefferer
0d53fbfd0b Spinner: Trigger start/spin/stop events when calling step/page methods. Fixes #8901 - Spinner does not fire start/spin/stop events when calling stepUp()/Down(), pageUp()/Down() methods 2012-12-27 17:06:01 +01:00
Jörn Zaefferer
04d668b717 Spinner: Update button icons when option changes. Fixes #8926 - Spinner: Can't change icons option after init 2012-12-27 12:50:04 +01:00
Scott González
020abcf8a9 Spinner tests: Delay all the things to make IE happy. Maybe... 2012-12-10 15:54:06 -05:00
Scott González
d5f06c319a Spinner tests: Better handling of async focus in IE. 2012-12-10 10:35:28 -05:00
Scott González
fb6119e182 Upgrade jQuery to 1.8.3. 2012-11-14 15:22:01 -05:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Scott González
a638acb583 Upgrade jQuery to 1.8.2. 2012-09-20 21:41:47 -04:00
Scott González
383d0dbfae Spinner tests: Added test for widget() method. 2012-08-26 20:19:35 -04:00
Scott González
1e6b2b2298 Upgrade jQuery to 1.8.0. 2012-08-13 09:19:09 -04:00
Jörn Zaefferer
e054e28836 Spinner: Introduce icons option to make button icons customizable, mostly for consistency 2012-07-12 18:07:40 +02:00
Jörn Zaefferer
1510f7e28a Update externals to latest mousewheel plugin, drop the version from the fielname while at it 2012-07-12 17:34:55 +02:00
Jörn Zaefferer
386bb7214b Spinner: Fix ghost log call in events unit test, never shows up in browser for some reason 2012-06-13 23:06:34 +02:00