Commit Graph

79 Commits

Author SHA1 Message Date
Jyoti Deka
ecde7cd41a Widget: option-method should work as getter only when argument length is 1. Fixes #9601 - Widget: calling _setOption with undefined as 3rd argument makes it a getter 2013-10-16 22:22:28 +02:00
Jörn Zaefferer
6e799c39d3 Widget Bridge: Make the _init method optional. Add tests for both states. Fixes #9543 - Widget bridge: Make _init() optional. 2013-09-11 22:26:34 +02:00
Alexander Schmitz
787d607f8e Widget Factory: Fix multiple var statements in test 2013-07-31 17:08:30 -04:00
Alexander Schmitz
c0ab71056b Widget Factory: Make $.widget return the constructor. Fixes #9467 - Widget factory: Return the constructor from $.widget(). 2013-07-31 16:52:21 -04:00
Scott González
2eb89f0734 Widget: Properly set widgetEventPrefix when redefining a widget. Fixes #9316 - Widget: widgetEventPrefix is empty when widget is (occasionally) loaded twice. 2013-05-20 11:30:49 -04:00
Jörn Zaefferer
1c1f7c6184 Widget: Remove copy-pasta leftovers 2013-03-19 17:53:09 +01:00
Jörn Zaefferer
90135b27f8 Widget tests: Use instance method. Also replace a few instances of $.data in widget implementations. 2013-03-19 16:53:35 +01:00
Corey Frang
4fce29e935 Widgets: Updating to use instance method on bridge 2013-03-19 16:08:00 +01:00
Corey Frang
36cb6f264d Widget: Implement instance method on the bridge to return widget instance - Fixes #9030 - instance method in widget prototype 2013-03-19 16:07:59 +01:00
Scott González
8b15aaf496 Widget: Don't modify the prototype passed to $.widget(). Fixes #8876 - Calling _super calls wrong inherited widget. 2012-12-03 14:18:24 -05:00
Scott González
7312933c88 Widget tests: Fixed order of actual and expected. 2012-12-03 13:57:28 -05:00
Scott González
9e858ba14a Widget: Only use the event prefix from the base if we're redefining a widget. Fixes #8805 - Widget: widgetEventPrefix is incorrect when inheriting with jQuery UI 1.9.1. 2012-11-09 16:49:03 -05:00
Scott González
1cdeeccab0 Widget: Suppress disabled check when binding destroy to the remove event. Fixes #8769 - Widget: ui-state-disabled blocks destroy to be triggered on remove. 2012-11-09 12:54:33 -05:00
Scott González
d44557f50a Widget: Removed dual storage of widget instances. Fixes #8801 - Widget: Remove data fallbacks for widget names. 2012-11-09 12:51:26 -05:00
Scott González
84cd214486 Widget: Added suppressDisabledCheck flag to _on(). Fixes #8800 - Widget: Ability to use _on() even when disabled. 2012-11-09 12:39:41 -05:00
Avinash R
75bd22eb73 Widget: Bridge falls back to name if there is no widgetFullName, and always stores instances in data. Fixed #8775 - Widget: Bridge fails if widgetFullName is not supplied. 2012-11-07 10:05:00 -05:00
Jörn Zaefferer
721a4b4ae0 Widget: Fix _on to use element argument for delegated events. Fixes #8658 - Widget: this._on delegates using instance.widget() instead of passed element 2012-10-24 10:42:21 -04:00
Scott González
848ab48583 Widget: Use existing widgetEventPrefix when extending. Fixes #8724 - widgetEventPrefix is lost when extending existing widget. 2012-10-24 10:13:51 -04:00
Marc-Andre Lafortune
8bb05d23e2 Widget: Destroy only when element is the actual target. Fixes #8652 - Widget: Destroy only when element is the actual target. 2012-10-23 14:06:30 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Scott González
a79d09a905 Widget: Create lowercase pseudo selectors. Fixes #8433 - Widget: Create lowercase pseudo selectors. 2012-07-09 16:02:43 -04:00
Scott González
5ae668fdb6 Tests: Enable QUnit.config.requireExpects. 2012-06-27 11:32:48 -04:00
Scott González
8e541f1bf6 Tests: Remove the need to include the 'ui.' prefix in testJshint() now that effects use 'ui.'. 2012-06-15 13:42:00 -04:00
Scott González
ff39bed57a Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off. 2012-06-14 12:33:16 -04:00
Scott González
00d4beb0ca Widget: Create eventNamespace property instead of constantly rebuilding it. 2012-06-14 11:17:20 -04:00
Jörn Zaefferer
28b14ec47c Generate a uuid for each widget for unique namespaces. Fixes #8385 - Widget: _bind() on elements such as document are dangerous 2012-06-14 10:39:41 -04:00
Scott González
9608e98149 Widget: Rename _bind() to _on(). Partial fix for #7795 - Widget: _on and _off. 2012-06-13 08:00:45 -04:00
Scott González
27072de094 Tests: Run JSHint. 2012-04-29 20:22:52 -04:00
Scott González
a28983086e Tests: Lint. 2012-04-18 22:36:15 -04:00
Jörn Zaefferer
5e51b8db28 Update Widget data naming/usage. Remove unnecessary fallbacks, update .removeData to use full name. 2012-03-01 15:03:30 +01:00
Jörn Zaefferer
5fda4f6828 Update data naming for Widget, including backwards compability. Updated tests and added one for the custom expression. Partial fix for #7810 2012-03-01 14:30:02 +01:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
Scott González
8cd4a8330c Widget: Allow redefining a widget after other widgets have inherited from it. 2012-02-01 16:59:26 -05:00
Scott González
da89fcbc07 Widget: Added _getCreateEventData(). Fixes #8045 - Widget: Ability to provide event data for create event. 2012-01-21 08:45:41 -05:00
Scott González
93214d6ddc Widget tests: Fixed _super() call in redefine test. 2011-11-21 08:43:08 -05:00
Jörn Zaefferer
66f9e12797 Widget: Remove method argument from _super and _superApply. Was a left-over from first implementation, not necessary anymore. 2011-11-18 17:08:40 +01:00
Jörn Zaefferer
3a0340f4ee Widget: return timer value from _delay 2011-09-12 23:47:09 +02:00
Jörn Zaefferer
2a6ca3fb39 Widget: Add a _delay method. Will be used in various places to replace setTimeout with custom binding (mostly getting rid of var self/that) 2011-09-12 23:37:14 +02:00
Jörn Zaefferer
d12180d1a5 Widget: Tests code cleanup 2011-09-12 23:23:54 +02:00
Scott González
4587f2de68 Widget: Use this.widget() for event delegation. 2011-08-12 22:10:31 -04:00
Jörn Zaefferer
982b752c35 Merge branch 'widget-delegation' 2011-07-29 14:00:00 +02:00
Jörn Zaefferer
02aad7b0ae Widget delegation: Update menu to use _bind with delegation. Clean up test. 2011-07-28 15:47:59 +02:00
Scott González
719db7f9b1 Widget tests: Fixed fragile tests. 2011-07-28 08:26:59 -04:00
Jörn Zaefferer
8b14b35dc7 Widget delegation: Fix impl and add basisc test 2011-06-19 14:59:18 +02:00
Jörn Zaefferer
aa7f8195f8 Merge branch 'master' into widget-delegation 2011-06-19 14:45:20 +02:00
Jörn Zaefferer
391282a9ae Whitespace 2011-06-19 14:42:15 +02:00
Scott González
3dea8f1786 Widget: Added ability to get deep options. Fixes #7459 - Widget: Extend .option() to get partial nested options. 2011-06-09 09:47:18 -04:00
Scott González
325ee6e871 Widget: define a null default for the create callback. 2011-04-25 14:04:30 -04:00
Scott González
78b17f9d76 Widget: Moved tests out of _tickets into _core. 2011-03-28 12:37:08 -04:00
Scott González
6fc98deef0 Widget: Allow setting individual properties of deep options. Fixes #7035 - Widget: Extend .option() to set partial nested options. 2011-03-24 09:21:53 -04:00