Commit Graph

9 Commits

Author SHA1 Message Date
Josep Sanz
85fba3f107
Tooltip: Don't crash on empty content
Commit 1f2011ece removed a `try-catch` around triggering the `remove` handlers
in the `jQuery.cleanData` override. The `try-catch` was meant for old IE but it was
also catching an error coming from the tooltip `remove` handler depending on
being able to find a relevant tooltip. The `_find` method returns `null`, though,
when the tooltip cotent is empty.

Instead of restoring the `try-catch`, handle the `null` case in the `remove` handler.

Fixes gh-1990
Closes gh-1994

Co-authored-by: Claas Augner <github@caugner.de>
Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
2021-11-08 11:53:45 +01:00
Michał Gołębiowski-Owczarek
70dae67b73
Build: Migrate from JSHint & JSCS to ESLint
Fixes #15393
Closes gh-1958
2021-06-07 00:58:12 +02:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Amanpreet Singh
92f122d5b1 Tooltip: Shift to use no globals 2016-04-14 00:14:57 +05:30
Alexander Schmitz
a0892eca70 Tooltip: Style updates
Ref #14246
2015-09-11 08:29:07 -04:00
Alexander Schmitz
eeb962027e Tooltip: Move tooltip into widgets directory
Ref #13885
2015-08-08 00:29:39 -04:00
Alexander Schmitz
24f1ce9ea0 Tooltip: Remove core event/alias and deprecated module dependencies 2015-05-20 14:27:57 -04:00
Jiabao Wu
2cef124bf2 Tooltip: Remove name attribute from elements in the live region
Fixes #11272
Closes gh-1544
2015-04-22 10:20:11 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00