Commit Graph

144 Commits

Author SHA1 Message Date
Scott González
ee8d20ea06 Dialog: Moved resizable handle test from resizable. 2012-11-26 16:27:18 -05:00
Kris Borchers
a68d5ca31d Dialog: Add unit test to cover #8789 and #8838. 2012-11-26 12:14:29 +01:00
Jörn Zaefferer
a09f5c07f5 Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
f3525afe0e Dialog: Update focus-tabbable test with a timer workaround to get IE8 to pass. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
5aac8f563f Dialog: Add missing unit test for aria-describedby attribute 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0 Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9 Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
299681e8f0 Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b694409e76 Dialog: Extend visual test to verify DOM position restore on destroy; overhaul unit test for destroy method. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4632780435 Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test 2012-11-26 10:26:11 +01:00
Scott González
8c36603305 Dialog tests: Work around inconsistent handling of non-breaking spaces in IE7/8 with jQuery <1.8. 2012-11-15 10:47:36 -05:00
Scott González
fb6119e182 Upgrade jQuery to 1.8.3. 2012-11-14 15:22:01 -05:00
Mike Sherov
543abc9b1f Dev: clean up dialog test suite with new helper methods. Fixes #8803 - Dev: re-enable the dialog test suite 2012-11-09 15:02:26 -05:00
Scott González
f5870712c1 Updated all widgets to use proper data keys when getting plugin instances. 2012-11-09 13:28:13 -05:00
Mike Sherov
3df9ea29e6 Dev: remove globals from tests and moved test helpers to correct location - Fixed #8770 Dev: Remove globals and Standardize Test Suite 2012-11-03 16:17:16 -04:00
Scott González
2a68a7d2bc Dialog tests: Removed stack option. 2012-10-26 14:38:27 -04:00
Scott González
d68ef5e4e1 Tests: Removed old code that kept bad test suites out of TestSwarm. 2012-10-26 13:47:34 -04:00
Scott González
68cab60fa7 Removed bgiframe. 2012-10-26 10:53:17 -04:00
Nate Eagle
3829a37ca1 Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:
Fixes #3534 - Dialog: Modal dialog disables all input elements on page.
Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.
Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.
Fixes #5388 - Dialog: Don't change z-index when already at the top.
Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.
Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.
Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.
Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.
Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).
Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.
Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.
Fixes #8583 - Dialog: Mouse event wrongly stopped.
Fixes #8722 - Dialog: Remove stack option.
Fixes #8729 - Dialog: Remove zIndex option.
2012-10-24 16:56:19 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Trey Hunner
49f9b849b9 Remove trailing whitespace and add final newlines 2012-10-21 22:45:41 -04:00
David Petersen
35dc9307fc Dialog: Use _hide() to make sure close event gets triggered. Fixes #8684 - jQuery dialog with hide options does not trigger close event. 2012-10-17 20:28:27 -04:00
Scott González
a638acb583 Upgrade jQuery to 1.8.2. 2012-09-20 21:41:47 -04:00
Scott González
1e6b2b2298 Upgrade jQuery to 1.8.0. 2012-08-13 09:19:09 -04:00
Scott González
b073cda1a5 Dialog tests: Fixed calls to $.contains() that were passing jQuery objects instead of elements. 2012-07-13 15:52:32 -04:00
Scott González
5ae668fdb6 Tests: Enable QUnit.config.requireExpects. 2012-06-27 11:32:48 -04:00
kborchers
240b22b143 Dialog: Use new uniqueId method for generating id's 2012-05-29 23:11:42 -05:00
Jay Merrifield
cab4c467d9 Dialog: Handle escape for all overlays. Fixes #8300 - Dialog: Incorrect behavior for ESCAPE with multiple modal dialogs. 2012-05-07 09:44:26 -04:00
Scott González
b042f8ebd6 Tests: Moved loadResources to TestHelpers. 2012-04-23 10:43:01 -04:00
Scott González
7a5a77da50 Tests: Rename {widget}_defaults.js -> {widget}_common.js 2012-04-23 10:15:17 -04:00
Jörn Zaefferer
ce3c7fab93 Update to official qunit composite addon 2012-04-21 17:49:11 +02:00
Scott González
e9d5079b04 Tests: Move commonWidgetTests() to TestHelpers. 2012-04-19 13:03:21 -04:00
Scott González
0a5a9090f8 Tests: Lint. 2012-04-19 10:28:26 -04:00
Scott González
89ff5c5232 Upgrade jQuery to 1.7.2. 2012-03-22 09:45:22 -04:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
Alberto Monteiro
a4b7feabd3 Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position 2011-12-15 17:52:49 -03:00
James Khoury
ce0afde900 Dialog: Modified the dialog._size() to use outerHeight in calculating the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set. 2011-11-28 16:52:10 -05:00
Scott González
54fb1441fe Upgrade jQuery to 1.7.1. 2011-11-22 08:43:09 -05:00
Scott González
50dab05784 Upgrade jQuery to 1.7. 2011-11-09 10:18:33 -05:00
Scott González
dcac8c1f29 Tests: Added ability to run tests against minified files via ?min=1 2011-10-28 15:58:33 -04:00
Scott González
efe964d86e Upgraded jQuery to 1.6.4. 2011-10-18 09:38:27 -04:00
Corey Frang
dfe75e1b55 Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thought it would everywhere, switching back to keydown. 2011-08-20 18:05:39 -05:00
Corey Frang
96e5c241e1 Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog 2011-08-19 06:03:59 -05:00
Scott González
6fb68568be Tests: Cleanup. 2011-08-03 21:43:52 -04:00