187 Commits

Author	SHA1	Message	Date
David Petersen	649f105229	Dialog: Don't handle overlays on destory if there are not any. Fixed: #9004 - failed in _destroyOverlay when I destroy a modal dialog thau was never opened. Fixed: #9000 Dialog leaves broken event handler after close/destroy in certain cases	2013-01-24 13:43:02 -06:00
Scott González	83cbf97978	Update copyright year to 2013.	2013-01-10 08:52:20 -05:00
Mike Sherov	74d7eac2da	All: Convert single quotes to double quotes.	2012-12-25 12:01:09 -05:00
Scott González	0f111a2ac4	Dialog: Spacing.	2012-12-12 08:47:21 -05:00
Scott González	b9f206dbcf	Dialog: Cleanup.	2012-12-11 16:23:18 -05:00
Scott González	d4551bc3b8	Dialog: Respect maxHeight when determining size on open. Fixes #4820 - Dialog: Auto height does not respect the maxHeight option.	2012-12-07 16:57:03 -05:00
Scott González	70b16ef445	Dialog: Added appendTo option. Fixes #7948 - Dialog: Allow dialog to be attached to a element other than body.	2012-12-07 14:54:21 -05:00
Scott González	b239298946	Allow higher cyclomatic complexity in functions that sanely use switch statements.	2012-12-06 14:31:21 -05:00
Scott González	f59f5a8b12	Dialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed.	2012-12-05 11:53:34 -05:00
Scott González	3c2acc3227	Dialog: Remove width, min-height, height styles on destroy. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed.	2012-12-04 10:03:05 -05:00
Scott González	050e71bdd8	Revert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers." ... This reverts commit d687a1b10d.	2012-12-04 09:21:33 -05:00
Jörn Zaefferer	9bd44301d3	Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties.	2012-12-04 01:17:00 +01:00
Jörn Zaefferer	1e8baf5683	Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist.	2012-12-04 01:08:34 +01:00
Jörn Zaefferer	d687a1b10d	Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers.	2012-12-04 00:35:47 +01:00
Jörn Zaefferer	13505e5945	Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM.	2012-11-30 13:08:56 +01:00
Jörn Zaefferer	24d9141597	Dialog: Use consistent code for appending to body	2012-11-29 17:40:31 +01:00
Jörn Zaefferer	7e9060c109	Dialog: Extract setting the title into a _title method, use .text() to prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability.	2012-11-26 10:28:25 +01:00
Jörn Zaefferer	60486ac632	Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE.	2012-11-26 10:28:25 +01:00
Kris Borchers	d179cbaf32	Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome.	2012-11-26 10:28:25 +01:00
Jörn Zaefferer	ec1f1bde76	Dialog: Follow-up to c77ca67 - exclude button options from properties to create the button.	2012-11-26 10:28:25 +01:00
Jörn Zaefferer	a09f5c07f5	Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option.	2012-11-26 10:28:25 +01:00
Jörn Zaefferer	32a893128d	Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body.	2012-11-26 10:28:24 +01:00
Jörn Zaefferer	41c2afd66b	Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs.	2012-11-26 10:28:24 +01:00
Jörn Zaefferer	a0310eb091	Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option.	2012-11-26 10:28:24 +01:00
Jörn Zaefferer	0be97bf8c0	Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported.	2012-11-26 10:28:24 +01:00
Jörn Zaefferer	b27db7e3b9	Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open	2012-11-26 10:28:24 +01:00
Jörn Zaefferer	999617343f	Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons.	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	d8b98ec3bb	Dialog: Tiny code improvements	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	e3dcaf28eb	Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143.	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	0bc73b74b6	Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs.	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	972f5c192c	Dialog: Button is now a fixed dependency, so remove the check	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	0ae6fc1e02	Dialog: Remove useless tmp vars.	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	625a111fb9	Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one.	2012-11-26 10:28:23 +01:00
Jörn Zaefferer	4c9caa8169	Dialog: Extract button pane creation into _createButtonPane	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	1d6ce644e0	Dialog: Refactor _create, extracting title bar creation in _createTitlebar	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	f0acaac230	Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings).	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	7a0353500a	Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable.	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	1001504249	Dialog: Remove outdated TODO	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	c8aef203cb	Dialog: Have _makeResizable look at options instead of passing handles.	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	16a79c1b9c	Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs).	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	7e964be80c	Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch.	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	fed2972027	Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value.	2012-11-26 10:28:22 +01:00
Jörn Zaefferer	83a9f219bf	Dialog: Use button widget for close button (was already listed as dependency)	2012-11-26 10:28:21 +01:00
Jörn Zaefferer	0848040d3e	Dialog: Focus tabbable only when dialog lost focus before.	2012-11-26 10:26:12 +01:00
Jörn Zaefferer	6edce86733	Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change.	2012-11-26 10:26:12 +01:00
Jörn Zaefferer	f7d3a51589	Dialog: Only add the new dialogClass, not the base classes when changing the option.	2012-11-26 10:26:12 +01:00
Jörn Zaefferer	324d54dd32	Dialog: Use $.isEmptyObject() to check if there a button-option properties	2012-11-26 10:26:12 +01:00
Jörn Zaefferer	4e03321fd7	Dialog: Trigger focus event when dialog is moved to top.	2012-11-26 10:26:12 +01:00
Jörn Zaefferer	b6cefc797e	Dialog: Remove deprecated disableSelection() usage.	2012-11-26 10:26:11 +01:00
Jörn Zaefferer	4632780435	Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test	2012-11-26 10:26:11 +01:00