Commit Graph

14 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
70dae67b73
Build: Migrate from JSHint & JSCS to ESLint
Fixes #15393
Closes gh-1958
2021-06-07 00:58:12 +02:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Ryan Oriecuia
8c66934434 Draggable: Fix spurious blur in dialogs on mousedown
I was running into a problem with a popup menu control in a dialog; clicks
weren't working (but keyboard was working fine). It turned out that the menu
was getting destroyed before the click event could fire.

Tracked down the issue to the way draggable blurs focused controls; it was
doing the blur before it ran through the logic to figure out if the drag was
actually on the handle. I've moved the blur below these checks, so it'll only
blur things if it actually needs to handle the drag. Otherwise, it asserts no
opinion on what should and shouldn't be focused, which seems like the way
things ought to be.

Also, added a unit test to check for the expected behavior.

Fixes #15046
Closes gh-1730
2016-09-13 08:53:00 -04:00
Amanpreet Singh
46f607af97 Draggable: Shift to use no globals 2016-04-14 00:06:12 +05:30
Scott González
63c103dd54 Draggable: Improve detection for when to blur the active element
Fixes #12472
Fixes #14905
Closes gh-1548
2016-02-09 13:37:26 -05:00
Scott González
33398fa4f1 Draggable: Skip window bubbling test in IE 8
IE 8 implements DOM Level 2 Events which only has events propagate
up to the document, not the window.

Ref #10818
Ref gh-1621
Closes gh-1627
2015-10-27 11:12:14 -04:00
Hannah Methvin
a1d69208ba Mouse: Don't stop propagation of mouseup
Fixes #10818
2015-10-18 12:36:43 -04:00
Alexander Schmitz
8336ba7b69 Draggable: Style updates
Ref #14246
2015-09-11 08:29:09 -04:00
Alexander Schmitz
f75c8761cb Draggable: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:23 -04:00
Alexander Schmitz
e59b596141 Resizable: Move resizable into widgets folder
Ref #13885
2015-08-08 00:29:38 -04:00
Alexander Schmitz
8b3005fd58 Droppable: Move droppable into widgets folder
Ref #13885
2015-08-08 00:29:38 -04:00
Alexander Schmitz
3b2db14b3b Draggable: Move draggable into widgets folder
Ref #13885
2015-08-08 00:29:38 -04:00
Alexander Schmitz
ce949812b6 Draggable: Remove core event/alias and deprecated module dependencies 2015-05-20 14:27:56 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00