Commit Graph

2918 Commits

Author SHA1 Message Date
Scott González
050e71bdd8 Revert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers."
This reverts commit d687a1b10d.
2012-12-04 09:21:33 -05:00
Scott González
8072099a3a Revert "Menu: Remove display property on hidden submenus instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b)."
This reverts commit 53b940fa27.
2012-12-04 09:21:16 -05:00
Scott González
86f1087931 Revert "Tabs: Remove display property on hidden panels instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b)."
This reverts commit b9068c1523.
2012-12-04 09:20:56 -05:00
Jörn Zaefferer
9bd44301d3 Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties. 2012-12-04 01:17:00 +01:00
Jörn Zaefferer
1e8baf5683 Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist. 2012-12-04 01:08:34 +01:00
Jörn Zaefferer
b9068c1523 Tabs: Remove display property on hidden panels instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b). 2012-12-04 00:56:14 +01:00
Jörn Zaefferer
53b940fa27 Menu: Remove display property on hidden submenus instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b). 2012-12-04 00:49:37 +01:00
Jörn Zaefferer
d687a1b10d Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers. 2012-12-04 00:35:47 +01:00
Scott González
8b15aaf496 Widget: Don't modify the prototype passed to $.widget(). Fixes #8876 - Calling _super calls wrong inherited widget. 2012-12-03 14:18:24 -05:00
Scott González
5ba267e7c7 Resizable: Respect containment for alsoResize option. Fixes #4603 - Resizable: alsoResize option doesn't work with containment. Fixes #5559 - Dialog: Content grows bigger than widget on resize at document edge. 2012-12-03 10:36:55 -05:00
Jörn Zaefferer
13505e5945 Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM. 2012-11-30 13:08:56 +01:00
Kris Borchers
f2ee4c51aa Progressbar: Create and destroy indeterminate overlay as needed and code cleanup. 2012-11-29 22:13:39 -06:00
Jörn Zaefferer
24d9141597 Dialog: Use consistent code for appending to body 2012-11-29 17:40:31 +01:00
Scott González
dec844570f Autocomplete: When appendTo is a jQuery object or a DOM element, don't search against the document. Fixes #8858 - Autocomplete: Fails when appendTo is detached from the DOM. 2012-11-28 10:33:59 -05:00
Scott González
f2854408cc Tooltip: Escape the title attribute so that it's treated as text and not HTML. Fixes #8861 - Tooltip: XSS vulnerability in default content. 2012-11-27 11:21:33 -05:00
Viktor Kojouharov
c5e0961268 Effects: Use $ instead of jQuery in $.effects.animateClass. Fixes #8860 - Effects: Class animation has broken noConflict support. 2012-11-27 08:27:48 -05:00
Scott González
e6e706bbd6 Datepicker: Remove JSHint overrides. 2012-11-27 08:22:21 -05:00
Scott González
7c53af0abc Datepicker: Remove support for setting options via custom attributes. 2012-11-26 22:50:36 -05:00
Fabrício Matté
caacf8f504 Button: Let change handler handle display and aria update. Fixed #5518 - Button: Incorrect state after double click in Firefox 2012-11-26 20:15:53 -05:00
David Petersen
6121683d80 Tabs: Calculate border and padding on tabs container. Fixed #8836: Height overflows parent with heightStyle: 'fill'. 2012-11-26 16:35:07 -05:00
TJ VanToll
0cd470b0d5 Resizable: Modified the default z-index value of resizable handles. Fixed #7960 - Dialog: Modal dialogs do not disable resizables on the page. 2012-11-26 12:42:44 +01:00
Jörn Zaefferer
7e9060c109 Dialog: Extract setting the title into a _title method, use .text() to prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
60486ac632 Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE. 2012-11-26 10:28:25 +01:00
Kris Borchers
d179cbaf32 Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
ec1f1bde76 Dialog: Follow-up to c77ca67 - exclude button options from properties to create the button. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
a09f5c07f5 Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
32a893128d Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
41c2afd66b Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0 Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9 Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
d8b98ec3bb Dialog: Tiny code improvements 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
e3dcaf28eb Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0bc73b74b6 Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
972f5c192c Dialog: Button is now a fixed dependency, so remove the check 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0ae6fc1e02 Dialog: Remove useless tmp vars. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
625a111fb9 Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
4c9caa8169 Dialog: Extract button pane creation into _createButtonPane 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1d6ce644e0 Dialog: Refactor _create, extracting title bar creation in _createTitlebar 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
f0acaac230 Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7a0353500a Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1001504249 Dialog: Remove outdated TODO 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
c8aef203cb Dialog: Have _makeResizable look at options instead of passing handles. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
16a79c1b9c Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7e964be80c Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
f7d3a51589 Dialog: Only add the new dialogClass, not the base classes when changing the option. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
324d54dd32 Dialog: Use $.isEmptyObject() to check if there a button-option properties 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4e03321fd7 Dialog: Trigger focus event when dialog is moved to top. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
b6cefc797e Dialog: Remove deprecated disableSelection() usage. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
4632780435 Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2062a18db6 Dialog: Inline code review 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
0a25b2c448 Dialog: move to top when opening again, and focus as if opened from scratch. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
8ee8046c02 Dialog: Keep focus inside modal dialog, by handling focus events on elements outside of it 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2a887e4321 Dialog: Improve accessibilty - add an aria-describedby attribute on the dialog if there is nothing yet in the dialog content. Partial fix for: 2012-11-26 10:26:11 +01:00
Corey Frang
d7adc2bae9 Effects Core: Upgrading jQuery Color to 2.1.1 2012-11-23 11:18:07 -06:00
Corey Frang
a217bd3b16 Effects: Making sure outerHeight and outerWidth make it through to the .size() implementation in all cases - Fixes IE8 effects failure 2012-11-22 04:12:30 -06:00
kborchers
d3bc471688 Progressbar: Add ability to set value: false for an indeterminate progressbar. Fixes #7624 - Progressbar: Support value: false for indeterminate progressbar 2012-11-21 21:48:17 -06:00
Mike Sherov
509259a66e Button: add explanatory comment for when we bind to blur 2012-11-21 19:58:59 -05:00
TJ VanToll
93abe02b60 Button: Fixing handling of the disabled options on refresh method calls. Fixed #8828 - Button: Refresh does not re-enable disabled button. 2012-11-21 19:24:24 -05:00
Samuel Bovée
cb748b4a6f Slider: factorize code with Widget method call. Fixed #8772 - Wrong slider UI state when disabled at init 2012-11-21 19:18:00 -05:00
Mike Sherov
f13b5dfa7f Button: add blur event to buttons. Fixes #8559 - Button: Button doesn't remove active state when using keyboard. 2012-11-21 19:14:04 -05:00
Scott González
d5afdba4cb Autocomplete: Whitespace. 2012-11-19 17:08:41 -05:00
Roman Salnikov
7ffcaa2e3b Datepicker: reinitialize datepicker if mainDiv isn't on the page. Fixed #5679 - Datepicker should reinitialize if dpDiv is removed 2012-11-19 09:15:10 -05:00
mathias.stenbom
cf9fbce139 Draggable: made handles work with complex markup. Fixes #8757 - Draggable: Resizable handle with inner element does not work, when its also draggable 2012-11-19 09:06:50 -05:00
Mike Sherov
cc7df712cc Button: properly escape button names. Fixes #7505 - Button: Buttonset not applied to radio group with quotation/apostrophe in name. 2012-11-19 08:37:41 -05:00
Mike Sherov
4334b5d4f1 Dev: make Datepicker pass JSHint with only eval setting overridden 2012-11-18 15:01:30 -05:00
Mike Sherov
53c462b666 Dev: make draggable pass JSHint with no local overrides 2012-11-18 11:44:12 -05:00
Mike Sherov
0e800636c4 Dev: Make droppable pass JSHint with no local settings overrides 2012-11-17 14:51:56 -05:00
Mike Sherov
5bae9a4763 Dev: Make sortable pass JSHint with only the loopfunc setting override 2012-11-17 14:24:44 -05:00
Mike Sherov
a1b32b59d5 Resizable: use css() instead of position() for absolute placement. Fixes #3815 - Resizable: absolutely positioned element inside scrollable element is repositioned when resized 2012-11-17 01:29:39 -05:00
Mike Sherov
9eaa572de1 Dev: Make resizable pass JSHint without any settings overrides 2012-11-17 00:08:01 -05:00
Scott González
3541c54082 Tabs: Removed some legacy code that isn't doing anything. 2012-11-16 16:57:36 -05:00
Scott González
23f7e30c77 Tabs: Remove ui-tabs-aria-controls data on destroy. 2012-11-16 16:10:22 -05:00
Juan Pablo Kaniefsky
a18863205e Slider: when handles overlap, clicking and dragging will now pick the last one that was moved. Fixed #3467 - Sliders Handles can overlap, only small sliver of slider is selectable 2012-11-16 09:32:56 -05:00
Scott González
3d96f20506 Datepicker: Fixed firstDay in Faroese locale. Fixes #8815 - Datepicker: Faroese locale has incorrect firstDay. 2012-11-14 15:06:37 -05:00
Scott González
ca0df6b900 Tooltip: Removed logic for handling tracking tooltips which gain focus while open (we no longer mix events). Fixes #8799 - Tooltip: tracking fails on nested elements. 2012-11-14 14:42:36 -05:00
Scott González
1b503a237e Tooltip: Handle synthetic focusin events. Fixes #8740 - Tooltip: Does not hide consistently with dynamically loaded content. 2012-11-14 14:14:45 -05:00
Jay Merrifield
eca5abd873 Datepicker: Updated the range tests so you can't navigate past the yearRange. Fixes #7362 - Datepicker allows changing year to something outside yearRange 2012-11-13 21:08:55 -05:00
Scott González
2553d61384 Accordion: Use .css() to clear the height, instead of .height(). 2012-11-13 19:02:02 -05:00
Ethan Romba
3974b55ba5 Resizable: Update CSS dimensions selectively. Fixes #7605 - Setting width and height when only one is changing
Resizable: Trigger resize event only when element is resized. Fixes #5545 - Callbacks ignore the grid.

Resizable: Added event tests. Fixes #5817 - resize event reports unconstrained ui.size
2012-11-12 21:41:22 -05:00
David Petersen
d657538ed5 Accordion: Enhance refresh to allow adding/removing panels. Fixes #4672 - Accordion: ability to add/remove panels 2012-11-11 21:38:21 -05:00
Cory Gackenheimer
8e1ceba717 Button: use _hoverable for hover state management. Fixes #5295 - button doesn't remove hover state if they are disabled 2012-11-11 21:17:05 -05:00
Kris Borchers
11687e44dc Progressbar: Do not duplicate base _setOptions method 2012-11-11 16:52:23 +09:00
Mike Sherov
d6c6b7dc33 Dev: make sure all files can pass JSHint! 2012-11-09 17:30:43 -05:00
Scott González
9e858ba14a Widget: Only use the event prefix from the base if we're redefining a widget. Fixes #8805 - Widget: widgetEventPrefix is incorrect when inheriting with jQuery UI 1.9.1. 2012-11-09 16:49:03 -05:00
Mike Sherov
254f2b3698 Dev: fix the datepicker test suite and jshint everything. Fixes #8804 - Dev: re-enable the datepicker test suite 2012-11-09 16:27:45 -05:00
Scott González
fd48568c40 Tabs: Show panels on destroy. Fixes #8795 - Tabs: 'display: none;' attribute is not removed from tabs when destroy is called. 2012-11-09 14:52:57 -05:00
Scott González
dbaecf0ede Effects: Cleaned up getElementStyles(). 2012-11-09 14:47:20 -05:00
Scott González
f5870712c1 Updated all widgets to use proper data keys when getting plugin instances. 2012-11-09 13:28:13 -05:00
Scott González
498aadf644 Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled. 2012-11-09 13:07:53 -05:00
Scott González
1cdeeccab0 Widget: Suppress disabled check when binding destroy to the remove event. Fixes #8769 - Widget: ui-state-disabled blocks destroy to be triggered on remove. 2012-11-09 12:54:33 -05:00
Scott González
d44557f50a Widget: Removed dual storage of widget instances. Fixes #8801 - Widget: Remove data fallbacks for widget names. 2012-11-09 12:51:26 -05:00
Scott González
84cd214486 Widget: Added suppressDisabledCheck flag to _on(). Fixes #8800 - Widget: Ability to use _on() even when disabled. 2012-11-09 12:39:41 -05:00
Ethan Romba
6e0a0553ce Resizable: Grid now respects min/max dimensions. Fixed #8435 - grid does not respect min/max dimensions 2012-11-09 09:48:50 -05:00
Kris Borchers
8976bc7e3d Progressbar: Refactor to better handle option changes and sanitize values. Fixes #8785 - Progressbar: Remove _value() and always sanitize value option 2012-11-08 12:02:25 -06:00