2023-09-18 16:39:00 +00:00
|
|
|
import jqueryConfig from "eslint-config-jquery";
|
|
|
|
import importPlugin from "eslint-plugin-import";
|
|
|
|
import globals from "globals";
|
|
|
|
|
|
|
|
export default [
|
|
|
|
{
|
|
|
|
|
|
|
|
// Only global ignores will bypass the parser
|
|
|
|
// and avoid JS parsing errors
|
|
|
|
// See https://github.com/eslint/eslint/discussions/17412
|
|
|
|
ignores: [
|
|
|
|
"external",
|
|
|
|
"test/data/json_obj.js"
|
|
|
|
]
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"eslint.config.js",
|
|
|
|
"Gruntfile.cjs",
|
|
|
|
"test/node_smoke_tests/commonjs/**",
|
|
|
|
"test/node_smoke_tests/module/**",
|
|
|
|
"test/promises_aplus_adapters/**",
|
2024-03-05 19:44:01 +00:00
|
|
|
"test/middleware-mockserver.cjs"
|
2023-09-18 16:39:00 +00:00
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
...globals.node
|
|
|
|
}
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
...jqueryConfig.rules,
|
|
|
|
strict: [ "error", "global" ]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
// Source
|
|
|
|
{
|
|
|
|
files: [ "src/**" ],
|
|
|
|
plugins: {
|
|
|
|
import: importPlugin
|
|
|
|
},
|
|
|
|
languageOptions: {
|
|
|
|
|
|
|
|
// The browser env is not enabled on purpose so that code takes
|
|
|
|
// all browser-only globals from window instead of assuming
|
|
|
|
// they're available as globals. This makes it possible to use
|
|
|
|
// jQuery with tools like jsdom which provide a custom window
|
|
|
|
// implementation.
|
|
|
|
globals: {
|
|
|
|
window: false
|
|
|
|
}
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
...jqueryConfig.rules,
|
|
|
|
"import/extensions": [ "error", "always" ],
|
|
|
|
"import/no-cycle": "error",
|
|
|
|
|
|
|
|
// TODO: Enable this rule when eslint-plugin-import supports
|
|
|
|
// it when using flat config.
|
|
|
|
// See https://github.com/import-js/eslint-plugin-import/issues/2556
|
|
|
|
|
|
|
|
// "import/no-unused-modules": [
|
|
|
|
// "error",
|
|
|
|
// {
|
|
|
|
// unusedExports: true,
|
|
|
|
|
|
|
|
// // When run via WebStorm, the root path against which these paths
|
|
|
|
// // are resolved is the path where this ESLint config file lies,
|
|
|
|
// // i.e. `src`. When run via the command line, it's usually the root
|
|
|
|
// // folder of the jQuery repository. This pattern intends to catch both.
|
|
|
|
// // Note that we cannot specify two patterns here:
|
|
|
|
// // [ "src/*.js", "*.js" ]
|
|
|
|
// // as they're analyzed individually and the rule crashes if a pattern
|
|
|
|
// // cannot be matched.
|
|
|
|
// ignoreExports: [ "{src/,}*.js" ]
|
|
|
|
// }
|
|
|
|
// ],
|
|
|
|
indent: [
|
|
|
|
"error",
|
|
|
|
"tab",
|
|
|
|
{
|
|
|
|
outerIIFEBody: 0
|
|
|
|
}
|
|
|
|
],
|
|
|
|
"one-var": [ "error", { var: "always" } ],
|
|
|
|
strict: [ "error", "function" ]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
2023-09-19 16:58:24 +00:00
|
|
|
files: [
|
|
|
|
"src/wrapper.js",
|
|
|
|
"src/wrapper-esm.js",
|
|
|
|
"src/wrapper-factory.js",
|
|
|
|
"src/wrapper-factory-esm.js"
|
|
|
|
],
|
2023-09-18 16:39:00 +00:00
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
2023-09-19 16:58:24 +00:00
|
|
|
jQuery: false
|
2023-09-18 16:39:00 +00:00
|
|
|
}
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
"no-unused-vars": "off",
|
|
|
|
indent: [
|
|
|
|
"error",
|
|
|
|
"tab",
|
|
|
|
{
|
|
|
|
|
|
|
|
// This makes it so code within the wrapper is not indented.
|
|
|
|
ignoredNodes: [
|
2023-09-19 16:58:24 +00:00
|
|
|
"Program > FunctionDeclaration > *"
|
2023-09-18 16:39:00 +00:00
|
|
|
]
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
2023-09-19 16:58:24 +00:00
|
|
|
files: [
|
|
|
|
"src/wrapper.js",
|
|
|
|
"src/wrapper-factory.js"
|
|
|
|
],
|
2023-09-18 16:39:00 +00:00
|
|
|
languageOptions: {
|
2023-09-19 16:58:24 +00:00
|
|
|
sourceType: "script",
|
2023-09-18 16:39:00 +00:00
|
|
|
globals: {
|
2023-09-19 16:58:24 +00:00
|
|
|
module: false
|
2023-09-18 16:39:00 +00:00
|
|
|
}
|
2023-09-19 16:58:24 +00:00
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [ "src/wrapper.js" ],
|
2023-09-18 16:39:00 +00:00
|
|
|
rules: {
|
|
|
|
indent: [
|
|
|
|
"error",
|
|
|
|
"tab",
|
|
|
|
{
|
|
|
|
|
|
|
|
// This makes it so code within the wrapper is not indented.
|
|
|
|
ignoredNodes: [
|
2023-09-19 16:58:24 +00:00
|
|
|
"Program > ExpressionStatement > CallExpression > :last-child > *"
|
2023-09-18 16:39:00 +00:00
|
|
|
]
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [ "src/exports/amd.js" ],
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
define: false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
// Tests
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"test/**"
|
|
|
|
],
|
|
|
|
ignores: [
|
Tests: migrate testing infrastructure to minimal dependencies
This is a complete rework of our testing infrastructure. The main goal is to modernize and drop deprecated or undermaintained dependencies (specifically, grunt, karma, and testswarm). We've achieved that by limiting our dependency list to ones that are unlikely to drop support any time soon. The new dependency list includes:
- `qunit` (our trusty unit testing library)
- `selenium-webdriver` (for spinning up local browsers)
- `express` (for starting a test server and adding middleware)
- express middleware includes uses of `body-parser` and `raw-body`
- `yargs` (for constructing a CLI with pretty help text)
- BrowserStack (for running each of our QUnit modules separately in all of our supported browsers)
- `browserstack-local` (for opening a local tunnel. This is the same package still currently used in the new Browserstack SDK)
- We are not using any other BrowserStack library. The newest BrowserStack SDK does not fit our needs (and isn't open source). Existing libraries, such as `node-browserstack` or `browserstack-runner`, either do not quite fit our needs, are under-maintained and out-of-date, or are not robust enough to meet all of our requirements. We instead call the [BrowserStack REST API](https://github.com/browserstack/api) directly.
## BrowserStack Runner
- automatically retries individual modules in case of test failure(s)
- automatically attempts to re-establish broken tunnels
- automatically refreshes the page in case a test run has stalled
- runs all browsers concurrently and uses as many sessions as are available under the BrowserStack plan. It will wait for available sessions if there are none.
- supports filtering the available list of browsers by browser name, browser version, device, OS, and OS version (see `npm run test:unit -- --list-browsers` for more info). It will retrieve the latest matching browser available if any of those parameters are not specified.
- cleans up after itself (closes the local tunnel, stops the test server, etc.)
- Requires `BROWSERSTACK_USERNAME` and `BROWSERSTACK_ACCESS_KEY` environment variables.
## Selenium Runner
- supports running any local browser as long as the driver is installed, including support for headless mode in Chrome, FF, and Edge
- supports running `basic` tests on the latest [jsdom](https://github.com/jsdom/jsdom#readme), which can be seen in action in this PR (see `test:browserless`)
- Node tests will run as before in PRs and all non-dependabot branches, but now includes tests on real Safari in a GH actions macos image instead of playwright-webkit.
- can run multiple browsers and multiple modules concurrently
Other notes:
- Stale dependencies have been removed and all remaining dependencies have been upgraded with a few exceptions:
- `sinon`: stopped supporting IE in version 10. But, `sinon` has been updated to 9.x.
- `husky`: latest does not support Node 10 and runs on `npm install`. Needed for now until git builds are migrated to GitHub Actions.
- `rollup`: latest does not support Node 10. Needed for now until git builds are migrated to GitHub Actions.
- BrowserStack tests are set to run on each `main` branch commit
- `debug` mode leaves Selenium browsers open whether they pass or fail and leaves browsers with test failures open on BrowserStack. The latter is to avoid leaving open too many sessions.
- This PR includes a workflow to dispatch BrowserStack runs on-demand
- The Node version used for most workflow tests has been upgraded to 20.x
- updated supportjQuery to 3.7.1
Run `npm run test:unit -- --help` for CLI documentation
Close gh-5418
2024-02-26 14:42:10 +00:00
|
|
|
"test/data/jquery-3.7.1.js",
|
2023-09-18 16:39:00 +00:00
|
|
|
"test/data/badcall.js",
|
|
|
|
"test/data/badjson.js",
|
|
|
|
"test/data/support/csp.js",
|
|
|
|
"test/data/support/getComputedSupport.js",
|
|
|
|
"test/data/core/jquery-iterability-transpiled.js"
|
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
...globals.browser,
|
|
|
|
require: false,
|
|
|
|
Promise: false,
|
|
|
|
Symbol: false,
|
|
|
|
trustedTypes: false,
|
|
|
|
QUnit: false,
|
|
|
|
ajaxTest: false,
|
|
|
|
testIframe: false,
|
|
|
|
createDashboardXML: false,
|
|
|
|
createWithFriesXML: false,
|
|
|
|
createXMLFragment: false,
|
|
|
|
includesModule: false,
|
|
|
|
moduleTeardown: false,
|
|
|
|
url: false,
|
|
|
|
q: false,
|
|
|
|
jQuery: true,
|
|
|
|
sinon: true,
|
|
|
|
amdDefined: true,
|
|
|
|
fireNative: true,
|
|
|
|
Globals: true,
|
|
|
|
hasPHP: true,
|
|
|
|
isLocal: true,
|
|
|
|
supportjQuery: true,
|
|
|
|
originaljQuery: true,
|
|
|
|
$: true,
|
|
|
|
original$: true,
|
|
|
|
baseURL: true,
|
|
|
|
externalHost: true
|
|
|
|
}
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
...jqueryConfig.rules,
|
|
|
|
strict: [ "error", "function" ],
|
|
|
|
|
|
|
|
// See https://github.com/eslint/eslint/issues/2342
|
|
|
|
"no-unused-vars": "off",
|
|
|
|
|
|
|
|
// Too many errors
|
|
|
|
"max-len": "off",
|
|
|
|
camelcase: "off",
|
|
|
|
"one-var": "off"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
2024-03-05 19:44:01 +00:00
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"test/runner/**/*.js"
|
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
...globals.node
|
|
|
|
},
|
|
|
|
sourceType: "module"
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
...jqueryConfig.rules
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [ "test/runner/listeners.js" ],
|
|
|
|
languageOptions: {
|
|
|
|
ecmaVersion: 5,
|
|
|
|
sourceType: "script"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
2023-09-18 16:39:00 +00:00
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"test/data/testrunner.js",
|
|
|
|
"test/data/core/jquery-iterability-transpiled-es6.js"
|
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
sourceType: "script"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"test/unit/deferred.js"
|
|
|
|
],
|
|
|
|
rules: {
|
|
|
|
|
|
|
|
// Deferred tests set strict mode for certain tests
|
|
|
|
strict: "off"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"test/node_smoke_tests/commonjs/**",
|
|
|
|
"test/node_smoke_tests/module/**",
|
|
|
|
"test/promises_aplus_adapters/**",
|
|
|
|
"test/middleware-mockserver.cjs"
|
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
...globals.node,
|
|
|
|
...globals.es2021
|
|
|
|
}
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
strict: [ "error", "global" ]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"build/**",
|
Tests: migrate testing infrastructure to minimal dependencies
This is a complete rework of our testing infrastructure. The main goal is to modernize and drop deprecated or undermaintained dependencies (specifically, grunt, karma, and testswarm). We've achieved that by limiting our dependency list to ones that are unlikely to drop support any time soon. The new dependency list includes:
- `qunit` (our trusty unit testing library)
- `selenium-webdriver` (for spinning up local browsers)
- `express` (for starting a test server and adding middleware)
- express middleware includes uses of `body-parser` and `raw-body`
- `yargs` (for constructing a CLI with pretty help text)
- BrowserStack (for running each of our QUnit modules separately in all of our supported browsers)
- `browserstack-local` (for opening a local tunnel. This is the same package still currently used in the new Browserstack SDK)
- We are not using any other BrowserStack library. The newest BrowserStack SDK does not fit our needs (and isn't open source). Existing libraries, such as `node-browserstack` or `browserstack-runner`, either do not quite fit our needs, are under-maintained and out-of-date, or are not robust enough to meet all of our requirements. We instead call the [BrowserStack REST API](https://github.com/browserstack/api) directly.
## BrowserStack Runner
- automatically retries individual modules in case of test failure(s)
- automatically attempts to re-establish broken tunnels
- automatically refreshes the page in case a test run has stalled
- runs all browsers concurrently and uses as many sessions as are available under the BrowserStack plan. It will wait for available sessions if there are none.
- supports filtering the available list of browsers by browser name, browser version, device, OS, and OS version (see `npm run test:unit -- --list-browsers` for more info). It will retrieve the latest matching browser available if any of those parameters are not specified.
- cleans up after itself (closes the local tunnel, stops the test server, etc.)
- Requires `BROWSERSTACK_USERNAME` and `BROWSERSTACK_ACCESS_KEY` environment variables.
## Selenium Runner
- supports running any local browser as long as the driver is installed, including support for headless mode in Chrome, FF, and Edge
- supports running `basic` tests on the latest [jsdom](https://github.com/jsdom/jsdom#readme), which can be seen in action in this PR (see `test:browserless`)
- Node tests will run as before in PRs and all non-dependabot branches, but now includes tests on real Safari in a GH actions macos image instead of playwright-webkit.
- can run multiple browsers and multiple modules concurrently
Other notes:
- Stale dependencies have been removed and all remaining dependencies have been upgraded with a few exceptions:
- `sinon`: stopped supporting IE in version 10. But, `sinon` has been updated to 9.x.
- `husky`: latest does not support Node 10 and runs on `npm install`. Needed for now until git builds are migrated to GitHub Actions.
- `rollup`: latest does not support Node 10. Needed for now until git builds are migrated to GitHub Actions.
- BrowserStack tests are set to run on each `main` branch commit
- `debug` mode leaves Selenium browsers open whether they pass or fail and leaves browsers with test failures open on BrowserStack. The latter is to avoid leaving open too many sessions.
- This PR includes a workflow to dispatch BrowserStack runs on-demand
- The Node version used for most workflow tests has been upgraded to 20.x
- updated supportjQuery to 3.7.1
Run `npm run test:unit -- --help` for CLI documentation
Close gh-5418
2024-02-26 14:42:10 +00:00
|
|
|
"test/data/testinit.js"
|
2023-09-18 16:39:00 +00:00
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
...globals.node,
|
|
|
|
...globals.es2021
|
|
|
|
}
|
|
|
|
},
|
|
|
|
rules: {
|
|
|
|
...jqueryConfig.rules,
|
|
|
|
strict: [ "error", "global" ]
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"build/**/*.js",
|
Tests: migrate testing infrastructure to minimal dependencies
This is a complete rework of our testing infrastructure. The main goal is to modernize and drop deprecated or undermaintained dependencies (specifically, grunt, karma, and testswarm). We've achieved that by limiting our dependency list to ones that are unlikely to drop support any time soon. The new dependency list includes:
- `qunit` (our trusty unit testing library)
- `selenium-webdriver` (for spinning up local browsers)
- `express` (for starting a test server and adding middleware)
- express middleware includes uses of `body-parser` and `raw-body`
- `yargs` (for constructing a CLI with pretty help text)
- BrowserStack (for running each of our QUnit modules separately in all of our supported browsers)
- `browserstack-local` (for opening a local tunnel. This is the same package still currently used in the new Browserstack SDK)
- We are not using any other BrowserStack library. The newest BrowserStack SDK does not fit our needs (and isn't open source). Existing libraries, such as `node-browserstack` or `browserstack-runner`, either do not quite fit our needs, are under-maintained and out-of-date, or are not robust enough to meet all of our requirements. We instead call the [BrowserStack REST API](https://github.com/browserstack/api) directly.
## BrowserStack Runner
- automatically retries individual modules in case of test failure(s)
- automatically attempts to re-establish broken tunnels
- automatically refreshes the page in case a test run has stalled
- runs all browsers concurrently and uses as many sessions as are available under the BrowserStack plan. It will wait for available sessions if there are none.
- supports filtering the available list of browsers by browser name, browser version, device, OS, and OS version (see `npm run test:unit -- --list-browsers` for more info). It will retrieve the latest matching browser available if any of those parameters are not specified.
- cleans up after itself (closes the local tunnel, stops the test server, etc.)
- Requires `BROWSERSTACK_USERNAME` and `BROWSERSTACK_ACCESS_KEY` environment variables.
## Selenium Runner
- supports running any local browser as long as the driver is installed, including support for headless mode in Chrome, FF, and Edge
- supports running `basic` tests on the latest [jsdom](https://github.com/jsdom/jsdom#readme), which can be seen in action in this PR (see `test:browserless`)
- Node tests will run as before in PRs and all non-dependabot branches, but now includes tests on real Safari in a GH actions macos image instead of playwright-webkit.
- can run multiple browsers and multiple modules concurrently
Other notes:
- Stale dependencies have been removed and all remaining dependencies have been upgraded with a few exceptions:
- `sinon`: stopped supporting IE in version 10. But, `sinon` has been updated to 9.x.
- `husky`: latest does not support Node 10 and runs on `npm install`. Needed for now until git builds are migrated to GitHub Actions.
- `rollup`: latest does not support Node 10. Needed for now until git builds are migrated to GitHub Actions.
- BrowserStack tests are set to run on each `main` branch commit
- `debug` mode leaves Selenium browsers open whether they pass or fail and leaves browsers with test failures open on BrowserStack. The latter is to avoid leaving open too many sessions.
- This PR includes a workflow to dispatch BrowserStack runs on-demand
- The Node version used for most workflow tests has been upgraded to 20.x
- updated supportjQuery to 3.7.1
Run `npm run test:unit -- --help` for CLI documentation
Close gh-5418
2024-02-26 14:42:10 +00:00
|
|
|
"test/data/testinit.js"
|
2023-09-18 16:39:00 +00:00
|
|
|
],
|
|
|
|
languageOptions: {
|
|
|
|
sourceType: "commonjs"
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
files: [
|
|
|
|
"dist/jquery.js",
|
|
|
|
"dist/jquery.slim.js",
|
2023-09-20 02:20:10 +00:00
|
|
|
"dist/jquery.factory.js",
|
|
|
|
"dist/jquery.factory.slim.js",
|
2023-09-18 16:39:00 +00:00
|
|
|
"dist-module/jquery.module.js",
|
2023-09-20 02:20:10 +00:00
|
|
|
"dist-module/jquery.slim.module.js",
|
|
|
|
"dist-module/jquery.factory.module.js",
|
|
|
|
"dist-module/jquery.factory.slim.module.js"
|
2023-09-18 16:39:00 +00:00
|
|
|
],
|
|
|
|
|
|
|
|
languageOptions: {
|
|
|
|
globals: {
|
|
|
|
...globals.browser,
|
|
|
|
...globals.es2021,
|
|
|
|
define: false,
|
|
|
|
module: false,
|
|
|
|
Symbol: false
|
|
|
|
}
|
|
|
|
},
|
|
|
|
|
|
|
|
rules: {
|
|
|
|
...jqueryConfig.rules,
|
|
|
|
|
|
|
|
// That is okay for the built version
|
|
|
|
"no-multiple-empty-lines": "off",
|
|
|
|
|
|
|
|
// When custom compilation is used, the version string
|
|
|
|
// can get large. Accept that in the built version.
|
|
|
|
"max-len": "off",
|
|
|
|
"one-var": "off"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
];
|