From 05c108ecbd72d6df36f7ae2ee934f3c3fb2b5db3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski?= Date: Tue, 21 Jan 2014 12:02:09 +0100 Subject: [PATCH] Tests: Blacklist one effects test in Chrome 31 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Chrome 31 reports incorrect offsetWidth on a table cell with fixed width. This is fixed in Chrome 32 so let’s just skip the failing test in Chrome 31. See https://code.google.com/p/chromium/issues/detail?id=290399 (cherry-picked from c11becbb692f7707443eb2582543dfe96e8319e6) --- test/unit/effects.js | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/test/unit/effects.js b/test/unit/effects.js index 3c89a3831..18a64908f 100644 --- a/test/unit/effects.js +++ b/test/unit/effects.js @@ -395,9 +395,20 @@ test("animate table-row width/height", function() { }); test("animate table-cell width/height", function() { - expect(3); - var displayMode, - td = jQuery("#table") + // Support: Chrome 31. + // Chrome 31 reports incorrect offsetWidth on a table cell with fixed width. + // This is fixed in Chrome 32 so let's just skip the failing test in Chrome 31. + // See https://code.google.com/p/chromium/issues/detail?id=290399 + var displayMode, td, + chrome31 = navigator.userAgent.indexOf( " Chrome/31." ) !== -1; + + if (chrome31) { + expect(2); + } else { + expect(3); + } + + td = jQuery("#table") .attr({ "cellspacing": 0, "cellpadding": 0, "border": 0 }) .html("
") .find("td"); @@ -407,7 +418,9 @@ test("animate table-cell width/height", function() { td.animate({ width: 10, height: 10 }, 100, function() { equal( jQuery(this).css("display"), displayMode, "display mode is correct" ); - equal( this.offsetWidth, 20, "width animated to shrink wrap point" ); + if (!chrome31) { + equal( this.offsetWidth, 20, "width animated to shrink wrap point" ); + } equal( this.offsetHeight, 20, "height animated to shrink wrap point" ); }); this.clock.tick( 100 );