library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-12-09 08:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure that the correct context is being passed in for replaceWith(fn). Fixes #5798.

Browse Source
This commit is contained in:
jeresig 2010-01-25 19:22:28 -05:00
parent 9f17e70ae9
commit 0b3165fd23
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/manipulation.js
View File

@ -233,6 +233,12 @@ jQuery.fn.extend({
// this can help fix replacing a parent with child elements // this can help fix replacing a parent with child elements
if ( !jQuery.isFunction( value ) ) { if ( !jQuery.isFunction( value ) ) {
value = jQuery( value ).detach(); value = jQuery( value ).detach();
} else {
return this.each(function(i) {
var self = jQuery(this), old = self.html();
self.replaceWith( value.call( this, i, old ) );
});
} }
return this.each(function() { return this.each(function() {

10
test/unit/manipulation.js
View File

@ -720,6 +720,16 @@ test("replaceWith(String|Element|Array<Element>|jQuery)", function() {
test("replaceWith(Function)", function() { test("replaceWith(Function)", function() {
testReplaceWith(functionReturningObj); testReplaceWith(functionReturningObj);
expect(16);
var y = jQuery("#yahoo")[0];
jQuery(y).replaceWith(function(){
equals( this, y, "Make sure the context is coming in correctly." );
});
reset();
}) })
test("replaceAll(String|Element|Array<Element>|jQuery)", function() { test("replaceAll(String|Element|Array<Element>|jQuery)", function() {