library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Deferred: Respect source maps in jQuery.Deferred.exceptionHook

Browse Source 
So far, `jQuery.Deferred.exceptionHook` used to log error message and stack
separately. However, that breaks browser applying source maps against the stack
trace - most browsers require logging an error instance. This change makes us
do exactly that.

One drawback of the change is that in IE 11 previously stack was printed
directly and now just the error summary; to get to the actual stack
trace, three clicks are required. This seems to be a low price to pay
for having source maps work in all the other browsers, though.

Safari with the new change requires one click to get to the stack trace
which sounds manageable.

Fixes gh-3179
Closes gh-5192
Ref https://crbug.com/622227
This commit is contained in:
Michał Gołębiowski-Owczarek 2023-02-01 13:46:44 +01:00 committed by GitHub
parent 6d1364431b
commit 0b9c5037f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/deferred/exceptionHook.js
View File

@ -10,8 +10,8 @@ jQuery.Deferred.exceptionHook = function( error, stack ) {
if ( error && rerrorNames.test( error.name ) ) {
window.console.warn(
"jQuery.Deferred exception: " + error.message,
error.stack,
"jQuery.Deferred exception",
error,
stack
);
}

6
test/unit/deferred.js
View File

@ -575,9 +575,9 @@ QUnit.test( "jQuery.Deferred.exceptionHook", function( assert ) {
defer = jQuery.Deferred(),
oldWarn = window.console.warn;
window.console.warn = function() {
var msg = Array.prototype.join.call( arguments, " " );
assert.ok( /barf/.test( msg ), "Message: " + msg );
window.console.warn = function( _intro, error ) {
assert.ok( /barf/.test( error.message + "\n" + error.stack ),
"Error mentions the method: " + error.message + "\n" + error.stack );
};
jQuery.when(