library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Build: Enable ESLint one-var rule for var declarations in browser code

Browse Source 
Node.js code is written more & more commonly in ES6+ so it doesn't make sense
to enable it there. There are many violations in test code so it's disabled
there as well.

Closes gh-4615

(cherry picked from commit 4a7fc8544e)
This commit is contained in:
Michał Gołębiowski-Owczarek 2020-03-02 22:25:35 +01:00
parent 5ea844f65a
commit 0fdfdd8290
5 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc-browser.json
View File

@ -24,6 +24,7 @@
}, },
"rules": { "rules": {
"one-var": ["error", {"var": "always"}],
"strict": ["error", "function"] "strict": ["error", "function"]
} }
} }

1
dist/.eslintrc.json vendored
View File

@ -14,6 +14,7 @@
"rules": { "rules": {
// That is okay for the built version // That is okay for the built version
"no-multiple-empty-lines": "off", "no-multiple-empty-lines": "off",
"one-var": "off",
// Sizzle is not compatible with jQuery code style // Sizzle is not compatible with jQuery code style
"no-nested-ternary": "off", "no-nested-ternary": "off",

4
src/css/support.js
View File

@ -103,7 +103,7 @@ define( [
// Behavior in IE 9 is more subtle than in newer versions & it passes // Behavior in IE 9 is more subtle than in newer versions & it passes
// some versions of this test; make sure not to make it pass there! // some versions of this test; make sure not to make it pass there!
reliableTrDimensions: function() { reliableTrDimensions: function() {
var table, tr, trChild; var table, tr, trChild, trStyle;
if ( reliableTrDimensionsVal == null ) { if ( reliableTrDimensionsVal == null ) {
table = document.createElement( "table" ); table = document.createElement( "table" );
tr = document.createElement( "tr" ); tr = document.createElement( "tr" );
@ -118,7 +118,7 @@ define( [
.appendChild( tr ) .appendChild( tr )
.appendChild( trChild ); .appendChild( trChild );
var trStyle = window.getComputedStyle( tr ); trStyle = window.getComputedStyle( tr );
reliableTrDimensionsVal = parseInt( trStyle.height ) > 3; reliableTrDimensionsVal = parseInt( trStyle.height ) > 3;
documentElement.removeChild( table ); documentElement.removeChild( table );

7
src/event.js
View File

@ -308,11 +308,12 @@ jQuery.event = {
dispatch: function( nativeEvent ) { dispatch: function( nativeEvent ) {
// Make a writable jQuery.Event from the native event object
var event = jQuery.event.fix( nativeEvent );
var i, j, ret, matched, handleObj, handlerQueue, var i, j, ret, matched, handleObj, handlerQueue,
args = new Array( arguments.length ), args = new Array( arguments.length ),
// Make a writable jQuery.Event from the native event object
event = jQuery.event.fix( nativeEvent ),
handlers = ( dataPriv.get( this, "events" ) || {} )[ event.type ] || [], handlers = ( dataPriv.get( this, "events" ) || {} )[ event.type ] || [],
special = jQuery.event.special[ event.type ] || {}; special = jQuery.event.special[ event.type ] || {};

1
test/.eslintrc.json
View File

@ -46,6 +46,7 @@
"brace-style": "off", "brace-style": "off",
"key-spacing": "off", "key-spacing": "off",
"camelcase": "off", "camelcase": "off",
"one-var": "off",
"strict": "off", "strict": "off",
// Not really too many - waiting for autofix features for these rules // Not really too many - waiting for autofix features for these rules