library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #9646. Cloned nodes shouldn't affect original in IE7. Close gh-947.

Browse Source
This commit is contained in:
Oleg 2012-10-02 03:36:54 +04:00 committed by Dave Methvin
parent 0018f7700b
commit 13651f296d
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/attributes.js
View File

@ -522,7 +522,15 @@ if ( !getSetAttribute ) {
ret = elem.ownerDocument.createAttribute( name );
elem.setAttributeNode( ret );
}
return ( ret.value = value + "" );
ret.value = value += "";
// Break association with cloned elements (#9646)
if ( name !== "value" && value !== elem.getAttribute( name ) ) {
elem.setAttribute( name, value );
}
return value;
}
};

24
test/unit/attributes.js
View File

@ -156,6 +156,30 @@ test( "attr(String)", function() {
$form = jQuery("#form").attr( "enctype", "multipart/form-data" );
equal( $form.prop("enctype"), "multipart/form-data", "Set the enctype of a form (encoding in IE6/7 #6743)" );
});
test( "attr(String) on cloned elements, #9646", function() {
expect( 4 );
var div,
input = jQuery("<input name='tester' />");
input.attr("name");
strictEqual( input.clone( true ).attr( "name", "test" )[ 0 ].name, "test", "Name attribute should be changed on cloned element" );
div = jQuery("<div id='tester' />");
div.attr("id");
strictEqual( div.clone( true ).attr( "id", "test" )[ 0 ].id, "test", "Id attribute should be changed on cloned element" );
input = jQuery("<input value='tester' />");
input.attr("value");
strictEqual( input.clone( true ).attr( "value", "test" )[ 0 ].value, "test", "Value attribute should be changed on cloned element" );
strictEqual( input.clone( true ).attr( "value", 42 )[ 0 ].value, "42", "Value attribute should be changed on cloned element" );
});
test( "attr(String) in XML Files", function() {