library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Selector: Use shallow document comparisons in uniqueSort

Browse Source 
IE/Edge sometimes crash when comparing documents between frames using the strict
equality operator (`===` & `!==`). Funnily enough, shallow comparisons
(`==` & `!=`) work without crashing.

The change to shallow comparisons in `src/selector.js` was done in gh-4471 but
relevant changes in `src/selector/uniqueSort.js` were missed. Those changes
have landed in Sizzle in jquery/sizzle#459.

Fixes gh-4441
Closes gh-4512
Ref gh-4471
Ref jquery/sizzle#459
This commit is contained in:
Michał Gołębiowski-Owczarek 2019-10-21 19:04:48 +02:00 committed by GitHub
parent f09d92100f
commit 15750b0af2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/selector/uniqueSort.js
View File

@ -24,7 +24,11 @@ function sortOrder( a, b ) {
} }
// Calculate position if both inputs belong to the same document // Calculate position if both inputs belong to the same document
compare = ( a.ownerDocument || a ) === ( b.ownerDocument || b ) ? // Support: IE 11+, Edge 17 - 18+
// IE/Edge sometimes throw a "Permission denied" error when strict-comparing
// two documents; shallow comparisons work.
// eslint-disable-next-line eqeqeq
compare = ( a.ownerDocument || a ) == ( b.ownerDocument || b ) ?
a.compareDocumentPosition( b ) : a.compareDocumentPosition( b ) :
// Otherwise we know they are disconnected // Otherwise we know they are disconnected
@ -34,11 +38,20 @@ function sortOrder( a, b ) {
if ( compare & 1 ) { if ( compare & 1 ) {
// Choose the first element that is related to the document // Choose the first element that is related to the document
if ( a === document || a.ownerDocument === document && // Support: IE 11+, Edge 17 - 18+
// IE/Edge sometimes throw a "Permission denied" error when strict-comparing
// two documents; shallow comparisons work.
// eslint-disable-next-line eqeqeq
if ( a == document || a.ownerDocument == document &&
jQuery.contains( document, a ) ) { jQuery.contains( document, a ) ) {
return -1; return -1;
} }
if ( b === document || b.ownerDocument === document &&
// Support: IE 11+, Edge 17 - 18+
// IE/Edge sometimes throw a "Permission denied" error when strict-comparing
// two documents; shallow comparisons work.
// eslint-disable-next-line eqeqeq
if ( b == document || b.ownerDocument == document &&
jQuery.contains( document, b ) ) { jQuery.contains( document, b ) ) {
return 1; return 1;
} }