library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Attributes: fix failing test for new return value

Browse Source
This commit is contained in:
Timmy Willison 2015-03-16 11:52:05 -04:00
parent afca031826
commit 17bd6e9cf9
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/attributes/attr.js
View File

@ -31,7 +31,7 @@ jQuery.extend({
// don't get/set attributes on text, comment and attribute nodes // don't get/set attributes on text, comment and attribute nodes
if ( !elem || nType === 3 || nType === 8 || nType === 2 ) { if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
return; return null;
} }
// Fallback to prop when attributes are not supported // Fallback to prop when attributes are not supported

13
test/unit/attributes.js
View File

@ -377,8 +377,17 @@ test( "attr(String, Object)", function() {
jQuery.each( [ window, document, obj, "#firstp" ], function( i, elem ) { jQuery.each( [ window, document, obj, "#firstp" ], function( i, elem ) {
var oldVal = elem.nonexisting, var oldVal = elem.nonexisting,
$elem = jQuery( elem ); $elem = jQuery( elem );
strictEqual( $elem.attr("nonexisting"), null, "attr works correctly for non existing attributes (bug #7500)." ); // Falls back to prop, which returns undefined
equal( $elem.attr( "nonexisting", "foo" ).attr("nonexisting"), "foo", "attr falls back to prop on unsupported arguments" ); strictEqual(
$elem.attr( "nonexisting" ),
typeof $elem[0].getAttribute === "undefined" ? undefined : null,
"attr works correctly for non existing attributes (bug #7500)."
);
equal(
$elem.attr( "nonexisting", "foo" ).attr( "nonexisting" ),
"foo",
"attr falls back to prop on unsupported arguments"
);
elem.nonexisting = oldVal; elem.nonexisting = oldVal;
}); });