library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #12411, .removeClass(undefined) is a chaining no-op. Close gh-913.

Browse Source 
.removeClass() //removes all classes, as documented
.removeClass(window.nonExistentVariable) // removes nothing
This commit is contained in:
Matthias Jäggli 2012-08-28 16:26:06 +03:00 committed by Dave Methvin
parent 23d125a51a
commit 227c49a459
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/attributes.js
View File

@ -78,7 +78,7 @@ jQuery.fn.extend({
jQuery( this ).removeClass( value.call(this, j, this.className) );
});
}
if ( (value && typeof value === "string") || value === undefined ) {
if ( (value && typeof value === "string") || !arguments.length ) {
removes = ( value || "" ).split( core_rspace );
for ( i = 0, l = this.length; i < l; i++ ) {

9
test/unit/attributes.js
View File

@ -1202,6 +1202,15 @@ test( "removeClass() removes duplicates", function() {
ok( !$div.hasClass("x"), "Element with multiple same classes does not escape the wrath of removeClass()" );
});
test("removeClass(undefined) is a no-op", function() {
expect( 1 );
var $div = jQuery("<div class='base second'></div>");
$div.removeClass( undefined );
ok( $div.hasClass("base") && $div.hasClass("second"), "Element still has classes after removeClass(undefined)" );
});
var testToggleClass = function(valueObj) {
expect( 17 );