library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #12048. Set attributes for XML fragments. Close gh-965.

Browse Source
This commit is contained in:
Sai Wong 2012-10-15 14:20:36 -04:00 committed by Dave Methvin
parent 144b8bfead
commit 2b0e720406
4 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/attributes.js
View File

@ -523,7 +523,7 @@ if ( !getSetAttribute ) {
// Set the existing or create a new attribute node
var ret = elem.getAttributeNode( name );
if ( !ret ) {
ret = document.createAttribute( name );
ret = elem.ownerDocument.createAttribute( name );
elem.setAttributeNode( ret );
}
return ( ret.value = value + "" );

1
test/.jshintrc
View File

@ -41,6 +41,7 @@
"testIframe": true,
"testIframeWithCallback": true,
"createDashboardXML": true,
"createXMLFragment": true,
"moduleTeardown": true,
"testFoo": true,
"foobar": true,

15
test/data/testinit.js
View File

@ -102,6 +102,21 @@ var createWithFriesXML = function() {
return jQuery.parseXML(string);
};
var createXMLFragment = function() {
var xml, frag;
if ( window.ActiveXObject ) {
xml = new ActiveXObject("msxml2.domdocument");
} else {
xml = document.implementation.createDocument( "", "", null );
}
if ( xml ) {
frag = xml.createElement("data");
}
return frag;
};
var fireNative;
if ( document.createEvent ) {
fireNative = function( node, type ) {

11
test/unit/attributes.js
View File

@ -522,6 +522,17 @@ test( "attr(String, Object) - Loaded via XML document", function() {
equal( titles[ 1 ], "Users", "attr() in XML context: Check second title" );
});
test( "attr(String, Object) - Loaded via XML fragment", function() {
expect( 2 );
var frag = createXMLFragment(),
$frag = jQuery( frag );
$frag.attr( "test", "some value" );
equal( $frag.attr("test"), "some value", "set attribute" );
$frag.attr( "test", null );
equal( $frag.attr("test"), undefined, "remove attribute" );
});
test( "attr('tabindex')", function() {
expect( 8 );