library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix #13471. $().on(".xyz"...) should avoid later crash.

Browse Source 
If the event type is an empty string we end up hanging in .off() which makes for
mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not
allowed.
This commit is contained in:
Dave Methvin 2013-02-26 12:19:04 -05:00
parent 31478b9012
commit 2bbc3d5860
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/event.js
View File

@ -66,6 +66,11 @@ jQuery.event = {
tmp = rtypenamespace.exec( types[t] ) || [];
type = origType = tmp[1];
namespaces = ( tmp[2] || "" ).split( "." ).sort();
// There *must* be a type, no attaching namespace-only handlers
if ( !type ) {
continue;
}
// If event changes its type, use the special event handlers for the changed type
special = jQuery.event.special[ type ] || {};

16
test/unit/event.js
View File

@ -555,6 +555,22 @@ test("bind(), multi-namespaced events", function() {
jQuery("#firstp").trigger("custom");
});
test("namespace-only event binding is a no-op", function(){
expect(2);
jQuery("#firstp")
.on( ".whoops", function() {
ok( false, "called a namespace-only event" );
})
.on( "whoops", function() {
ok( true, "called whoops" );
})
.trigger("whoops") // 1
.off(".whoops")
.trigger("whoops") // 2
.off("whoops");
});
test("bind(), with same function", function() {
expect(2);