From 35785a32298d1033933ea4b041adb4cc73eaae47 Mon Sep 17 00:00:00 2001 From: Timmy Willison <4timmywil@gmail.com> Date: Mon, 20 Mar 2017 12:53:15 -0400 Subject: [PATCH] Revert "Event: Add radio click triggering tests" This reverts commit 5f35b5b406ae7d504de86a3f0a5647b2fdf4f2af. --- test/unit/event.js | 37 +++++++++++-------------------------- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/test/unit/event.js b/test/unit/event.js index 328157903..02aad5e36 100644 --- a/test/unit/event.js +++ b/test/unit/event.js @@ -2364,48 +2364,33 @@ QUnit.test( "clone() delegated events (#11076)", function( assert ) { clone.remove(); } ); -QUnit.test( "checkbox state (#3827, gh-3423)", function( assert ) { - assert.expect( 17 ); +QUnit.test( "checkbox state (#3827)", function( assert ) { + assert.expect( 9 ); - var cbParent = jQuery( "
" ).appendTo( "#qunit-fixture" ), - cb = cbParent.find( "input" )[ 0 ], - radioParent = jQuery( - "
" - ).appendTo( "#qunit-fixture" ), - radio = radioParent.find( "input" )[ 0 ], - radio2 = radioParent.find( "input" )[ 1 ]; + var markup = jQuery( "
" ).appendTo( "#qunit-fixture" ), + cb = markup.find( "input" )[ 0 ]; jQuery( cb ).on( "click", function() { assert.equal( this.checked, false, "just-clicked checkbox is not checked" ); } ); - cbParent.on( "click", function() { + markup.on( "click", function() { assert.equal( cb.checked, false, "checkbox is not checked in bubbled event" ); } ); - radioParent.on( "click", function() { - assert.equal( radio.checked, false, "radio is not checked in bubbled event" ); - } ); // Native click - cb.checked = radio.checked = true; + cb.checked = true; assert.equal( cb.checked, true, "native - checkbox is initially checked" ); - assert.equal( radio.checked, true, "native - radio is initially checked" ); cb.click(); - radio2.click(); assert.equal( cb.checked, false, "native - checkbox is no longer checked" ); - assert.equal( radio.checked, false, "native - radio is no longer checked" ); // jQuery click - cb.checked = radio.checked = true; - assert.equal( cb.checked, true, ".trigger - checkbox is initially checked" ); - assert.equal( radio.checked, true, ".trigger - radio is initially checked" ); - jQuery( [ cb, radio2 ] ).trigger( "click" ); - assert.equal( cb.checked, false, ".trigger - checkbox is no longer checked" ); - assert.equal( radio.checked, false, ".trigger - radio is no longer checked" ); + cb.checked = true; + assert.equal( cb.checked, true, "jQuery - checkbox is initially checked" ); + jQuery( cb ).trigger( "click" ); + assert.equal( cb.checked, false, "jQuery - checkbox is no longer checked" ); // Handlers only; checkbox state remains false - jQuery( [ cb, radio2 ] ).triggerHandler( "click" ); - assert.equal( cb.checked, false, ".triggerHandler - checkbox is still unchecked" ); - assert.equal( radio.checked, false, ".triggerHandler - radio is still unchecked" ); + jQuery( cb ).triggerHandler( "click" ); } ); QUnit.test( "hover event no longer special since 1.9", function( assert ) {