library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Manipulation: Make jQuery.cleanData not skip elements during cleanup

Browse Source 
When passing a result of `getElementByTagsName` to `jQuery.cleanData`, convert
it to an array first. Otherwise, a live NodeList is passed and if any of the
event cleanups remove the element itself, a collection is modified during the
iteration, making `jQuery.cleanData` skip cleanup for some elements.

Fixes gh-5214
Closes gh-5523

Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
This commit is contained in:
ac-mmi 2024-09-11 03:48:53 +05:30 committed by GitHub
parent 6d78c0768d
commit 3cad5c435a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/manipulation/getAll.js
View File

@ -1,5 +1,6 @@
import { jQuery } from "../core.js"; import { jQuery } from "../core.js";
import { nodeName } from "../core/nodeName.js"; import { nodeName } from "../core/nodeName.js";
import { arr } from "../var/arr.js";
export function getAll( context, tag ) { export function getAll( context, tag ) {
@ -8,7 +9,9 @@ export function getAll( context, tag ) {
var ret; var ret;
if ( typeof context.getElementsByTagName !== "undefined" ) { if ( typeof context.getElementsByTagName !== "undefined" ) {
ret = context.getElementsByTagName( tag || "*" );
// Use slice to snapshot the live collection from gEBTN
ret = arr.slice.call( context.getElementsByTagName( tag || "*" ) );
} else if ( typeof context.querySelectorAll !== "undefined" ) { } else if ( typeof context.querySelectorAll !== "undefined" ) {
ret = context.querySelectorAll( tag || "*" ); ret = context.querySelectorAll( tag || "*" );

40
test/unit/manipulation.js
View File

@ -3099,3 +3099,43 @@ testIframe(
} ); } );
} }
); );
QUnit.test( "should handle node removal in event's remove hook (gh-5214)", function( assert ) {
assert.expect( 4 );
jQuery(
"<div id='container'>" +
" <div class='guarded removeself' data-elt='one'>" +
" Guarded 1" +
" </div>" +
" <div class='guarded' data-elt='two'>" +
" Guarded 2" +
" </div>" +
" <div class='guarded' data-elt='three'>" +
" Guarded 3" +
" </div>" +
"</div>"
).appendTo( "#qunit-fixture" );
// Define the custom event handler
jQuery.event.special.removeondestroy = {
remove: function( ) {
var $t = jQuery( this );
assert.step( $t.data( "elt" ) );
if ( $t.is( ".removeself" ) ) {
$t.remove();
}
}
};
// Attach an empty handler to trigger the `remove`
// logic for the custom event when the element is removed.
jQuery( ".guarded" ).on( "removeondestroy", function( ) { } );
// Trigger the event's removal logic by emptying the container
jQuery( "#container" ).empty();
assert.verifySteps( [ "one", "two", "three" ], "All elements were processed in order" );
} );