From 50b94f47d2b4b40f7b9181e42e83e848efb4c4c9 Mon Sep 17 00:00:00 2001 From: Timmy Willison <4timmywil@gmail.com> Date: Mon, 8 Jan 2018 11:55:14 -0500 Subject: [PATCH] Tests: fix function reference for unbinding Ref gh-2958 --- test/unit/event.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/unit/event.js b/test/unit/event.js index e23c6fd29..5dc17722d 100644 --- a/test/unit/event.js +++ b/test/unit/event.js @@ -687,15 +687,15 @@ QUnit.test( "on(), with different this object", function( assert ) { data = { myData: true }, handler1 = function() { assert.equal( this, thisObject, "on() with different this object" ); - }, + }.bind( thisObject ), handler2 = function( event ) { assert.equal( this, thisObject, "on() with different this object and data" ); assert.equal( event.data, data, "on() with different this object and data" ); - }; + }.bind( thisObject ); jQuery( "#firstp" ) - .on( "click", handler1.bind( thisObject ) ).trigger( "click" ).off( "click", handler1 ) - .on( "click", data, handler2.bind( thisObject ) ).trigger( "click" ).off( "click", handler2 ); + .on( "click", handler1 ).trigger( "click" ).off( "click", handler1 ) + .on( "click", data, handler2 ).trigger( "click" ).off( "click", handler2 ); assert.ok( !jQuery._data( jQuery( "#firstp" )[ 0 ], "events" ), "Event handler unbound when using different this object and data." ); } );