Using "hasOwnProperty" to check for direct properties "type" and

"namespace" on events before triggering.
This commit is contained in:
Andrew Plummer 2013-02-01 02:40:42 +09:00
parent bb1d148345
commit 5935a362c7
2 changed files with 16 additions and 2 deletions

View File

@ -208,8 +208,8 @@ jQuery.event = {
var i, cur, tmp, bubbleType, ontype, handle, special, var i, cur, tmp, bubbleType, ontype, handle, special,
eventPath = [ elem || document ], eventPath = [ elem || document ],
type = event.type || event, type = core_hasOwn.call(event, 'type') ? event.type : event,
namespaces = event.namespace ? event.namespace.split(".") : []; namespaces = core_hasOwn.call(event, 'namespace') ? event.namespace.split(".") : [];
cur = tmp = elem = elem || document; cur = tmp = elem = elem || document;

View File

@ -2666,3 +2666,17 @@ test( "Check order of focusin/focusout events", 2, function() {
input.off(); input.off();
}); });
test("make sure defining 'namespace' on String.prototype does not cause trigger() to error", function() {
expect(1);
var errored = false;
String.prototype.namespace = function() {
return "test";
};
try {
jQuery("<p>").trigger('foo.bar');
} catch( e ) {
errored = true;
}
equal(errored, false, 'trigger() should not have errored');
delete String.prototype.namespace;
});