library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

jQuery.clone() check that destination child nodes are not null. Fixes #9587

Browse Source
This commit is contained in:
rwldrn 2011-06-15 11:14:52 -04:00
parent d59b0f3e27
commit 5c3b9e0c24
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/manipulation.js
View File

@ -564,7 +564,10 @@ jQuery.extend({
// with an element if you are cloning the body and one of the
// elements on the page has a name or id of "length"
for ( i = 0; srcElements[i]; ++i ) {
cloneFixAttributes( srcElements[i], destElements[i] );
// Ensure that the destination node is not null; Fixes #9587
if ( destElements[i] ) {
cloneFixAttributes( srcElements[i], destElements[i] );
}
}
}
@ -762,4 +765,4 @@ function evalScript( i, elem ) {
}
}
})( jQuery );
})( jQuery );

2
test/index.html
View File

@ -281,6 +281,8 @@ Z</textarea>
</div>
<div id="fx-tests"></div>
<div id="no-clone-exception"><object><embed></embed></object></div>
</div>
</body>
</html>

11
test/unit/manipulation.js
View File

@ -1465,3 +1465,14 @@ test("jQuery.buildFragment - plain objects are not a document #8950", function()
} catch (e) {}
});
test("jQuery.clone - no exceptions for object elements #9587", function() {
expect(1);
try {
jQuery("#no-clone-exception").clone();
ok( true, "cloned with no exceptions" );
} catch( e ) {
ok( false, e.message );
}
});