library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Disable the ":lang respects escaped backslashes" test

Browse Source 
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
It is an intentional change as `:lang()` parameters are supposed to be valid
BCP 47 strings. Therefore, we won't attempt to patch it.
We'll keep this test here until other browsers match the behavior.

Fixes gh-5271
Closes gh-5277
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
Ref https://github.com/w3c/csswg-drafts/issues/8720#issuecomment-1509242961
This commit is contained in:
Michał Gołębiowski-Owczarek 2023-06-27 18:05:46 +02:00 committed by GitHub
parent 67cb1af774
commit 62b9a25834
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/unit/selector.js
View File

@ -1474,7 +1474,7 @@ QUnit.test( "pseudo - :target and :root", function( assert ) {
} ); } );
QUnit.test( "pseudo - :lang", function( assert ) { QUnit.test( "pseudo - :lang", function( assert ) {
assert.expect( QUnit.jQuerySelectors ? 105 : 55 ); assert.expect( QUnit.jQuerySelectors ? 104 : 54 );
var docElem = document.documentElement, var docElem = document.documentElement,
docXmlLang = docElem.getAttribute( "xml:lang" ), docXmlLang = docElem.getAttribute( "xml:lang" ),
@ -1547,8 +1547,18 @@ QUnit.test( "pseudo - :lang", function( assert ) {
anchor.parentNode.lang = "ara"; anchor.parentNode.lang = "ara";
anchor.lang = "ara\\b"; anchor.lang = "ara\\b";
assert.deepEqual( jQuery( ":lang(ara\\b)", foo ).get(), [], ":lang respects backslashes" ); assert.deepEqual( jQuery( ":lang(ara\\b)", foo ).get(), [], ":lang respects backslashes" );
assert.deepEqual( jQuery( ":lang(ara\\\\b)", foo ).get(), [ anchor ],
":lang respects escaped backslashes" ); // Support: Firefox 114+
// Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
// It is an intentional change as `:lang()` parameters are supposed to be valid
// BCP 47 strings. Therefore, we won't attempt to patch it.
// We'll keep this test here until other browsers match the behavior.
// See https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
// See https://github.com/w3c/csswg-drafts/issues/8720#issuecomment-1509242961
//
// assert.deepEqual( jQuery( ":lang(ara\\\\b)", foo ).get(), [ anchor ],
// ":lang respects escaped backslashes" );
assert.throws( function() { assert.throws( function() {
jQuery( "#qunit-fixture:lang(c++)" ); jQuery( "#qunit-fixture:lang(c++)" );
}, ":lang value must be a valid identifier" ); }, ":lang value must be a valid identifier" );