library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

CSS: Make the reliableTrDimensions support test work with Bootstrap CSS

Browse Source 
Bootstrap 5 includes the following CSS on the page:

```css
*,
*::before,
*::after {
  box-sizing: border-box;
}
```

That threw our `reliableTrDimensions` support test off. This change fixes the
support test and adds a unit test ensuring support test values on a page
including Bootstrap 5 CSS are the same as on a page without it.

Fixes gh-5270
Closes gh-5278
Ref gh-5279
This commit is contained in:
Michał Gołębiowski-Owczarek 2023-07-10 18:33:05 +02:00 committed by GitHub
parent e24218758b
commit 65b85031fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 39 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Gruntfile.js
View File

@ -89,6 +89,10 @@ module.exports = function( grunt ) {
destPrefix: "external" destPrefix: "external"
}, },
files: { files: {
"bootstrap/bootstrap.css": "bootstrap/dist/css/bootstrap.css",
"bootstrap/bootstrap.min.css": "bootstrap/dist/css/bootstrap.min.css",
"bootstrap/bootstrap.min.css.map": "bootstrap/dist/css/bootstrap.min.css.map",
"core-js-bundle/core-js-bundle.js": "core-js-bundle/minified.js", "core-js-bundle/core-js-bundle.js": "core-js-bundle/minified.js",
"core-js-bundle/LICENSE": "core-js-bundle/LICENSE", "core-js-bundle/LICENSE": "core-js-bundle/LICENSE",

1
package.json
View File

@ -27,6 +27,7 @@
"@babel/core": "7.10.5", "@babel/core": "7.10.5",
"@babel/plugin-transform-for-of": "7.10.4", "@babel/plugin-transform-for-of": "7.10.4",
"@swc/core": "1.3.66", "@swc/core": "1.3.66",
"bootstrap": "5.3.0",
"colors": "1.4.0", "colors": "1.4.0",
"commitplease": "3.2.0", "commitplease": "3.2.0",
"core-js-bundle": "3.6.5", "core-js-bundle": "3.6.5",

4
src/css/support.js
View File

@ -25,7 +25,7 @@ support.reliableTrDimensions = function() {
tr = document.createElement( "tr" ); tr = document.createElement( "tr" );
table.style.cssText = "position:absolute;left:-11111px;border-collapse:separate"; table.style.cssText = "position:absolute;left:-11111px;border-collapse:separate";
tr.style.cssText = "border:1px solid"; tr.style.cssText = "box-sizing:content-box;border:1px solid";
// Support: Chrome 86+ // Support: Chrome 86+
// Height set through cssText does not get applied. // Height set through cssText does not get applied.
@ -38,7 +38,7 @@ support.reliableTrDimensions = function() {
// display for all div elements is set to "inline", // display for all div elements is set to "inline",
// which causes a problem only in Android Chrome, but // which causes a problem only in Android Chrome, but
// not consistently across all devices. // not consistently across all devices.
// Ensuring the div is display: block // Ensuring the div is `display: block`
// gets around this issue. // gets around this issue.
div.style.display = "block"; div.style.display = "block";

20
test/data/support/bootstrap.html Normal file
View File

@ -0,0 +1,20 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<link rel="stylesheet" href="../../../external/bootstrap/bootstrap.min.css" class="stylesheet">
</head>
<body>
<div>
<script src="../../jquery.js"></script>
<script src="../iframeTest.js"></script>
<script src="getComputedSupport.js"></script>
</div>
<script>
startIframeTest(
getComputedStyle( document.body ),
getComputedSupport( jQuery.support )
);
</script>
</body>
</html>

12
test/unit/support.js
View File

@ -54,6 +54,18 @@ testIframe(
} }
); );
testIframe(
"Verify correctness of support tests with bootstrap CSS on the page",
"support/bootstrap.html",
function( assert, jQuery, window, document, bodyStyle, support ) {
assert.expect( 2 );
assert.strictEqual( bodyStyle.boxSizing, "border-box",
"border-box applied on body by Bootstrap" );
assert.deepEqual( jQuery.extend( {}, support ), computedSupport,
"Same support properties" );
}
);
( function() { ( function() {
var expected, browserKey, var expected, browserKey,
userAgent = window.navigator.userAgent, userAgent = window.navigator.userAgent,