From 6f7bdf8977e2eb9e6f528218ea5c99653a224c35 Mon Sep 17 00:00:00 2001 From: timmywil Date: Mon, 28 May 2012 18:32:00 -0400 Subject: [PATCH] Update Sizzle: Add test for [selected] attribute selections. Addresses a small issue in IE8's boolean attribute selections with QSA. --- src/sizzle | 2 +- test/unit/selector.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sizzle b/src/sizzle index 80fc773d2..b04f5b042 160000 --- a/src/sizzle +++ b/src/sizzle @@ -1 +1 @@ -Subproject commit 80fc773d20eb169334114ea1fac3083eeb3a98a7 +Subproject commit b04f5b042164356453cfe6e37e0b61b5ddda5f05 diff --git a/test/unit/selector.js b/test/unit/selector.js index 7902742b1..d605ab8df 100644 --- a/test/unit/selector.js +++ b/test/unit/selector.js @@ -62,7 +62,7 @@ test("disconnected nodes", function() { }); testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQuery, window, document ) { - expect(34); + expect(35); /** * Returns an array of elements with the given IDs, eg. @@ -119,7 +119,7 @@ testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQue t( "Attribute Exists", "[indeterminate]", []); t( "Attribute Exists", "[ismap]", ["img1"]); t( "Attribute Exists", "[itemscope]", ["div1"]); - // t( "Attribute Exists", "[loop]", ["video1"]); // IE 6/7 cannot differentiate here. loop is also used on img, input, and marquee tags as well as video/audio. getAttributeNode unfortunately only retrieves the property value. + // t( "Attribute Exists", "[loop]", ["video1"]); // IE 6/7 cannot differentiate here. loop is also used on img, input, and marquee tags as well as video/audio. getAttributeNode unfortunately also retrieves the property value. t( "Attribute Exists", "[multiple]", ["select1"]); t( "Attribute Exists", "[muted]", ["audio1"]); // t( "Attribute Exists", "[nohref]", ["area1"]); // IE 6/7 keep this set to false regardless of presence. The attribute node is not retrievable. @@ -134,7 +134,7 @@ testIframe("selector/html5_selector", "attributes - jQuery.attr", function( jQue t( "Attribute Exists", "[reversed]", ["ol1"]); t( "Attribute Exists", "[scoped]", ["style1"]); t( "Attribute Exists", "[seamless]", ["iframe1"]); - // t( "Attribute Exists", "[selected]", ["option1"]); // IE8's querySelectorAll fails here. Redirecting to oldSizzle would work, but it would require an additional support test as well as a check for the selected attribute within the qsa logic + t( "Attribute Exists", "[selected]", ["option1"]); t( "Attribute Exists", "[truespeed]", ["marquee1"]); // Enumerated attributes (these are not boolean content attributes)