library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-10-05 11:34:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix #14492: More correct jQuery.parseJSON. Close gh-1419.

Browse Source 
(cherry picked from commit 60a6178131)

Conflicts:

	src/ajax/parseJSON.js
This commit is contained in:
Richard Gibson 2013-11-04 23:36:15 -05:00
parent e8e53a6bb5
commit 71b2ac524e
3 changed files with 76 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ajax/parseJSON.js
View File

@ -2,7 +2,11 @@ define([
"../core"
], function( jQuery ) {
jQuery.parseJSON = JSON.parse;
// Support: Android 2.3
// Workaround failure to string-cast null input
jQuery.parseJSON = function( data ) {
return JSON.parse( data + "" );
};
return jQuery.parseJSON;

3
test/jquery.js vendored
View File

@ -11,12 +11,13 @@
QUnit.config.urlConfig.push({
id: "basic",
label: "Bypass optimizations",
tooltip: "Force use of the most basic code by disabling native querySelectorAll; contains; compareDocumentPosition"
tooltip: "Force use of the most basic code by disabling native querySelectorAll; contains; compareDocumentPosition; JSON.parse"
});
if ( QUnit.urlParams.basic ) {
document.querySelectorAll = null;
document.documentElement.contains = null;
document.documentElement.compareDocumentPosition = null;
window.JSON = null;
}
// iFrames won't load AMD (the iframe tests synchronously expect jQuery to be there)

75
test/unit/core.js
View File

@ -1360,13 +1360,35 @@ test("jQuery.parseHTML", function() {
ok( jQuery.parseHTML("<#if><tr><p>This is a test.</p></tr><#/if>") || true, "Garbage input should not cause error" );
});
test("jQuery.parseJSON", function(){
expect( 9 );
test("jQuery.parseJSON", function() {
expect( 20 );
strictEqual( jQuery.parseJSON( null ), null, "primitive null" );
strictEqual( jQuery.parseJSON("0.88"), 0.88, "Number" );
strictEqual(
jQuery.parseJSON("\" \\\" \\\\ \\/ \\b \\f \\n \\r \\t \\u007E \\u263a \""),
" \" \\ / \b \f \n \r \t ~ \u263A ",
"String escapes"
);
deepEqual( jQuery.parseJSON("{}"), {}, "Empty object" );
deepEqual( jQuery.parseJSON("{\"test\":1}"), { "test": 1 }, "Plain object" );
deepEqual( jQuery.parseJSON("[0]"), [ 0 ], "Simple array" );
deepEqual(
jQuery.parseJSON("[ \"string\", -4.2, 2.7180e0, 3.14E-1, {}, [], true, false, null ]"),
[ "string", -4.2, 2.718, 0.314, {}, [], true, false, null ],
"Array of all data types"
);
deepEqual(
jQuery.parseJSON( "{ \"string\": \"\", \"number\": 4.2e+1, \"object\": {}," +
"\"array\": [[]], \"boolean\": [ true, false ], \"null\": null }"),
{ string: "", number: 42, object: {}, array: [[]], boolean: [ true, false ], "null": null },
"Dictionary of all data types"
);
deepEqual( jQuery.parseJSON("\n{\"test\":1}\t"), { "test": 1 },
"Leading and trailing whitespace are ignored" );
equal( jQuery.parseJSON( null ), null, "Actual null returns null" );
equal( jQuery.isEmptyObject( jQuery.parseJSON("{}") ), true, "Empty object returns empty object" );
deepEqual( jQuery.parseJSON("{\"test\":1}"), { "test": 1 }, "Plain object parses" );
deepEqual( jQuery.parseJSON("\n{\"test\":1}"), { "test": 1 }, "Leading whitespaces are ignored." );
raises(function() {
jQuery.parseJSON();
}, null, "Undefined raises an error" );
@ -1376,12 +1398,53 @@ test("jQuery.parseJSON", function(){
raises(function() {
jQuery.parseJSON("''");
}, null, "Single-quoted string raises an error" );
/*
// Broken on IE8
raises(function() {
jQuery.parseJSON("\" \\a \"");
}, null, "Invalid string escape raises an error" );
// Broken on IE8, Safari 5.1 Windows
raises(function() {
jQuery.parseJSON("\"\t\"");
}, null, "Unescaped control character raises an error" );
// Broken on IE8
raises(function() {
jQuery.parseJSON(".123");
}, null, "Number with no integer component raises an error" );
*/
raises(function() {
var result = jQuery.parseJSON("0101");
// Support: IE9+
// Ensure base-10 interpretation on browsers that erroneously accept leading-zero numbers
if ( result === 101 ) {
throw new Error("close enough");
}
}, null, "Leading-zero number raises an error or is parsed as decimal" );
raises(function() {
jQuery.parseJSON("{a:1}");
}, null, "Unquoted property raises an error" );
raises(function() {
jQuery.parseJSON("{'a':1}");
}, null, "Single-quoted property raises an error" );
raises(function() {
jQuery.parseJSON("[,]");
}, null, "Array element elision raises an error" );
raises(function() {
jQuery.parseJSON("{},[]");
}, null, "Comma expression raises an error" );
raises(function() {
jQuery.parseJSON("[]\n,{}");
}, null, "Newline-containing comma expression raises an error" );
raises(function() {
jQuery.parseJSON("\"\"\n\"\"");
}, null, "Automatic semicolon insertion raises an error" );
strictEqual( jQuery.parseJSON([ 0 ]), 0, "Input cast to string" );
});
test("jQuery.parseXML", 8, function(){