library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #10690. Make sure .isNumeric() can't get a Date.

Browse Source 
Also add tests for custom objects with a `.toString()` method.
This commit is contained in:
Dave Methvin 2011-11-07 11:25:51 -05:00
parent 13aa84580a
commit 795583d293
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core.js
View File

@ -485,7 +485,7 @@ jQuery.extend({
},
isNumeric: function( obj ) {
return obj != null && rdigit.test( obj ) && !isNaN( obj );
return !isNaN( parseFloat(obj) ) && isFinite( obj );
},
type: function( obj ) {

16
test/unit/core.js
View File

@ -455,9 +455,17 @@ test("isFunction", function() {
});
test( "isNumeric", function() {
expect( 33 );
expect( 37 );
var t = jQuery.isNumeric;
var t = jQuery.isNumeric,
Traditionalists = function(n) {
this.value = n;
this.toString = function(){
return String(this.value);
};
},
answer = new Traditionalists( "42" ),
rong = new Traditionalists( "Devo" );
ok( t("-10"), "Negative integer string");
ok( t("0"), "Zero string");
@ -475,6 +483,7 @@ test( "isNumeric", function() {
ok( t(3.1415), "Positive floating point number");
ok( t(8e5), "Exponential notation");
ok( t("123e-2"), "Exponential notation string");
ok( t(answer), "Custom .toString returning number");
equal( t(""), false, "Empty string");
equal( t(" "), false, "Whitespace characters string");
equal( t("\t\t"), false, "Tab characters string");
@ -490,8 +499,11 @@ test( "isNumeric", function() {
equal( t(Infinity), false, "Infinity primitive");
equal( t(Number.POSITIVE_INFINITY), false, "Positive Infinity");
equal( t(Number.NEGATIVE_INFINITY), false, "Negative Infinity");
equal( t(rong), false, "Custom .toString returning non-number");
equal( t({}), false, "Empty object");
equal( t(function(){} ), false, "Instance of a function");
equal( t( new Date ), false, "Instance of a Date");
equal( t(function(){} ), false, "Instance of a function");
});
test("isXMLDoc - HTML", function() {