library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Core:CSS:Event: simplification of native method signatures

Browse Source 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047
This commit is contained in:
Oleg Gaidarenko 2015-04-27 09:49:12 +03:00
parent a117dd05f6
commit 85577a348a
4 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/ready.js
View File

@ -63,8 +63,8 @@ jQuery.extend({
* The ready event handler and self cleanup method
*/
function completed() {
document.removeEventListener( "DOMContentLoaded", completed, false );
window.removeEventListener( "load", completed, false );
document.removeEventListener( "DOMContentLoaded", completed );
window.removeEventListener( "load", completed );
jQuery.ready();
}
@ -85,10 +85,10 @@ jQuery.ready.promise = function( obj ) {
} else {
// Use the handy event callback
document.addEventListener( "DOMContentLoaded", completed, false );
document.addEventListener( "DOMContentLoaded", completed );
// A fallback to window.onload, that will always work
window.addEventListener( "load", completed, false );
window.addEventListener( "load", completed );
}
}
return readyList.promise( obj );

4
src/css/support.js
View File

@ -39,7 +39,7 @@ define([
div.innerHTML = "";
documentElement.appendChild( container );
var divStyle = window.getComputedStyle( div, null );
var divStyle = window.getComputedStyle( div );
pixelPositionVal = divStyle.top !== "1%";
boxSizingReliableVal = divStyle.height === "4px";
pixelMarginRightVal = divStyle.marginRight === "4px";
@ -90,7 +90,7 @@ define([
div.style.width = "1px";
documentElement.appendChild( container );
ret = !parseFloat( window.getComputedStyle( marginDiv, null ).marginRight );
ret = !parseFloat( window.getComputedStyle( marginDiv ).marginRight );
documentElement.removeChild( container );
div.removeChild( marginDiv );

4
src/css/var/getStyles.js
View File

@ -4,9 +4,9 @@ define(function() {
// IE throws on elements created in popups
// FF meanwhile throws on frame elements through "defaultView.getComputedStyle"
if ( elem.ownerDocument.defaultView.opener ) {
return elem.ownerDocument.defaultView.getComputedStyle( elem, null );
return elem.ownerDocument.defaultView.getComputedStyle( elem );
}
return window.getComputedStyle( elem, null );
return window.getComputedStyle( elem );
};
});

5
src/event.js
View File

@ -123,7 +123,7 @@ jQuery.event = {
special.setup.call( elem, data, namespaces, eventHandle ) === false ) {
if ( elem.addEventListener ) {
elem.addEventListener( type, eventHandle, false );
elem.addEventListener( type, eventHandle );
}
}
}
@ -631,9 +631,10 @@ jQuery.event = {
};
jQuery.removeEvent = function( elem, type, handle ) {
// This "if" is needed for plain objects
if ( elem.removeEventListener ) {
elem.removeEventListener( type, handle, false );
elem.removeEventListener( type, handle );
}
};